summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Siarhei Vishniakou <svv@google.com> 2024-09-19 19:02:24 -0700
committer Siarhei Vishniakou <svv@google.com> 2024-09-19 19:24:43 -0700
commita925de1e1487c1f08e690fd1390163b5ceaf7bd6 (patch)
treede88375c98a30f9d1118b5cf3b1e844650f93a3b
parentf53fa6b562d6608197329b94e796012e18d11dc7 (diff)
Move applyInputEventProfile to cpp file
This is an implementation detail, so it doesn't need to be exposed in the header file at all. Bug: 330719044 Flag: EXEMPT refactor Test: none Change-Id: I54b0bac26f1a3a77a2b5c5a43a3d3e7f5a42a20d
-rw-r--r--services/inputflinger/InputThread.cpp26
-rw-r--r--services/inputflinger/include/InputThread.h2
2 files changed, 13 insertions, 15 deletions
diff --git a/services/inputflinger/InputThread.cpp b/services/inputflinger/InputThread.cpp
index bd4b192e22..7cf4e397f9 100644
--- a/services/inputflinger/InputThread.cpp
+++ b/services/inputflinger/InputThread.cpp
@@ -26,6 +26,16 @@ namespace input_flags = com::android::input::flags;
namespace {
+bool applyInputEventProfile(const Thread& thread) {
+#if defined(__ANDROID__)
+ return SetTaskProfiles(thread.getTid(), {"InputPolicy"});
+#else
+ // Since thread information is not available and there's no benefit of
+ // applying the task profile on host, return directly.
+ return true;
+#endif
+}
+
// Implementation of Thread from libutils.
class InputThreadImpl : public Thread {
public:
@@ -47,11 +57,11 @@ private:
InputThread::InputThread(std::string name, std::function<void()> loop, std::function<void()> wake,
bool isInCriticalPath)
- : mName(name), mThreadWake(wake) {
+ : mThreadWake(wake) {
mThread = sp<InputThreadImpl>::make(loop);
- mThread->run(mName.c_str(), ANDROID_PRIORITY_URGENT_DISPLAY);
+ mThread->run(name.c_str(), ANDROID_PRIORITY_URGENT_DISPLAY);
if (input_flags::enable_input_policy_profile() && isInCriticalPath) {
- if (!applyInputEventProfile()) {
+ if (!applyInputEventProfile(*mThread)) {
LOG(ERROR) << "Couldn't apply input policy profile for " << name;
}
}
@@ -75,14 +85,4 @@ bool InputThread::isCallingThread() {
#endif
}
-bool InputThread::applyInputEventProfile() {
-#if defined(__ANDROID__)
- return SetTaskProfiles(mThread->getTid(), {"InputPolicy"});
-#else
- // Since thread information is not available and there's no benefit of
- // applying the task profile on host, return directly.
- return true;
-#endif
-}
-
} // namespace android
diff --git a/services/inputflinger/include/InputThread.h b/services/inputflinger/include/InputThread.h
index 595f5a2b9e..ed92b8f949 100644
--- a/services/inputflinger/include/InputThread.h
+++ b/services/inputflinger/include/InputThread.h
@@ -35,10 +35,8 @@ public:
bool isCallingThread();
private:
- std::string mName;
std::function<void()> mThreadWake;
sp<Thread> mThread;
- bool applyInputEventProfile();
};
} // namespace android