diff options
author | 2016-09-26 13:08:16 -0700 | |
---|---|---|
committer | 2016-09-27 18:09:42 -0700 | |
commit | 8f279960c6ad8803e36503250b7ab89e34c9477b (patch) | |
tree | bbbd2418a6d98701d3cdf951e0b0ec7736f7575d | |
parent | 17576de056a57753eb4af797545db88ef4f81ef0 (diff) |
Use uint32_t consistently for region op
An implicit conversion warning was being hidden by the use of -isystem
to include frameworks/native/include.
Bug: 31752268
Test: m -j
Change-Id: I008ef537a24311d58816fae12ef8c4aeaba07547
-rw-r--r-- | include/private/ui/RegionHelper.h | 2 | ||||
-rw-r--r-- | include/ui/Region.h | 22 | ||||
-rw-r--r-- | libs/ui/Region.cpp | 20 |
3 files changed, 22 insertions, 22 deletions
diff --git a/include/private/ui/RegionHelper.h b/include/private/ui/RegionHelper.h index 6b9b460351..83b05c74c3 100644 --- a/include/private/ui/RegionHelper.h +++ b/include/private/ui/RegionHelper.h @@ -66,7 +66,7 @@ public: virtual ~region_rasterizer() { } }; - inline region_operator(int op, const region& lhs, const region& rhs) + inline region_operator(uint32_t op, const region& lhs, const region& rhs) : op_mask(op), spanner(lhs, rhs) { } diff --git a/include/ui/Region.h b/include/ui/Region.h index 810f09860d..778845295f 100644 --- a/include/ui/Region.h +++ b/include/ui/Region.h @@ -147,21 +147,21 @@ private: class rasterizer; friend class rasterizer; - Region& operationSelf(const Rect& r, int op); - Region& operationSelf(const Region& r, int op); - Region& operationSelf(const Region& r, int dx, int dy, int op); - const Region operation(const Rect& rhs, int op) const; - const Region operation(const Region& rhs, int op) const; - const Region operation(const Region& rhs, int dx, int dy, int op) const; - - static void boolean_operation(int op, Region& dst, + Region& operationSelf(const Rect& r, uint32_t op); + Region& operationSelf(const Region& r, uint32_t op); + Region& operationSelf(const Region& r, int dx, int dy, uint32_t op); + const Region operation(const Rect& rhs, uint32_t op) const; + const Region operation(const Region& rhs, uint32_t op) const; + const Region operation(const Region& rhs, int dx, int dy, uint32_t op) const; + + static void boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Region& rhs, int dx, int dy); - static void boolean_operation(int op, Region& dst, + static void boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Rect& rhs, int dx, int dy); - static void boolean_operation(int op, Region& dst, + static void boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Region& rhs); - static void boolean_operation(int op, Region& dst, + static void boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Rect& rhs); static void translate(Region& reg, int dx, int dy); diff --git a/libs/ui/Region.cpp b/libs/ui/Region.cpp index 246346bb34..a430a31058 100644 --- a/libs/ui/Region.cpp +++ b/libs/ui/Region.cpp @@ -294,7 +294,7 @@ Region& Region::andSelf(const Rect& r) { Region& Region::subtractSelf(const Rect& r) { return operationSelf(r, op_nand); } -Region& Region::operationSelf(const Rect& r, int op) { +Region& Region::operationSelf(const Rect& r, uint32_t op) { Region lhs(*this); boolean_operation(op, *this, lhs, r); return *this; @@ -314,7 +314,7 @@ Region& Region::andSelf(const Region& rhs) { Region& Region::subtractSelf(const Region& rhs) { return operationSelf(rhs, op_nand); } -Region& Region::operationSelf(const Region& rhs, int op) { +Region& Region::operationSelf(const Region& rhs, uint32_t op) { Region lhs(*this); boolean_operation(op, *this, lhs, rhs); return *this; @@ -339,7 +339,7 @@ const Region Region::intersect(const Rect& rhs) const { const Region Region::subtract(const Rect& rhs) const { return operation(rhs, op_nand); } -const Region Region::operation(const Rect& rhs, int op) const { +const Region Region::operation(const Rect& rhs, uint32_t op) const { Region result; boolean_operation(op, result, *this, rhs); return result; @@ -359,7 +359,7 @@ const Region Region::intersect(const Region& rhs) const { const Region Region::subtract(const Region& rhs) const { return operation(rhs, op_nand); } -const Region Region::operation(const Region& rhs, int op) const { +const Region Region::operation(const Region& rhs, uint32_t op) const { Region result; boolean_operation(op, result, *this, rhs); return result; @@ -385,7 +385,7 @@ Region& Region::andSelf(const Region& rhs, int dx, int dy) { Region& Region::subtractSelf(const Region& rhs, int dx, int dy) { return operationSelf(rhs, dx, dy, op_nand); } -Region& Region::operationSelf(const Region& rhs, int dx, int dy, int op) { +Region& Region::operationSelf(const Region& rhs, int dx, int dy, uint32_t op) { Region lhs(*this); boolean_operation(op, *this, lhs, rhs, dx, dy); return *this; @@ -405,7 +405,7 @@ const Region Region::intersect(const Region& rhs, int dx, int dy) const { const Region Region::subtract(const Region& rhs, int dx, int dy) const { return operation(rhs, dx, dy, op_nand); } -const Region Region::operation(const Region& rhs, int dx, int dy, int op) const { +const Region Region::operation(const Region& rhs, int dx, int dy, uint32_t op) const { Region result; boolean_operation(op, result, *this, rhs, dx, dy); return result; @@ -583,7 +583,7 @@ bool Region::validate(const Region& reg, const char* name, bool silent) return result; } -void Region::boolean_operation(int op, Region& dst, +void Region::boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Region& rhs, int dx, int dy) { @@ -693,7 +693,7 @@ void Region::boolean_operation(int op, Region& dst, #endif } -void Region::boolean_operation(int op, Region& dst, +void Region::boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Rect& rhs, int dx, int dy) { @@ -722,13 +722,13 @@ void Region::boolean_operation(int op, Region& dst, #endif } -void Region::boolean_operation(int op, Region& dst, +void Region::boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Region& rhs) { boolean_operation(op, dst, lhs, rhs, 0, 0); } -void Region::boolean_operation(int op, Region& dst, +void Region::boolean_operation(uint32_t op, Region& dst, const Region& lhs, const Rect& rhs) { boolean_operation(op, dst, lhs, rhs, 0, 0); |