summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author John Reck <jreck@google.com> 2018-04-27 17:01:45 -0700
committer John Reck <jreck@google.com> 2018-04-30 15:45:00 +0000
commit82607f30c8a71b6854ca26307e5ab18542eb3952 (patch)
treeb9cd3c40ddb1af732c52adab8facbac0c75c97c0
parent13487078b41679e09d3a661e924389081372bbc9 (diff)
Fix BufferItemConsumer::releaseBuffer error logging
STALE_BUFFER_SLOT is a hint, not an error, and shouldn't be logged. Fixes: 77483431 Test: verified CtsUiRenderingTestCases:.testclasses.HardwareBitmapTests#testCreateFromPicture doesn't log any errors to logcat Change-Id: I570c585b7c55c668d994bf37854a2252b09b9da8
-rw-r--r--libs/gui/BufferItemConsumer.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/libs/gui/BufferItemConsumer.cpp b/libs/gui/BufferItemConsumer.cpp
index 34e6d80061..89bc0c4c2d 100644
--- a/libs/gui/BufferItemConsumer.cpp
+++ b/libs/gui/BufferItemConsumer.cpp
@@ -92,10 +92,13 @@ status_t BufferItemConsumer::releaseBuffer(const BufferItem &item,
Mutex::Autolock _l(mMutex);
err = addReleaseFenceLocked(item.mSlot, item.mGraphicBuffer, releaseFence);
+ if (err != OK) {
+ BI_LOGE("Failed to addReleaseFenceLocked");
+ }
err = releaseBufferLocked(item.mSlot, item.mGraphicBuffer, EGL_NO_DISPLAY,
EGL_NO_SYNC_KHR);
- if (err != OK) {
+ if (err != OK && err != IGraphicBufferConsumer::STALE_BUFFER_SLOT) {
BI_LOGE("Failed to release buffer: %s (%d)",
strerror(-err), err);
}