diff options
author | 2019-03-11 11:23:03 +0800 | |
---|---|---|
committer | 2019-03-21 16:03:14 +0000 | |
commit | 7c3ae9c745ec325690cd60d791bde7ec1183da42 (patch) | |
tree | 7cf26e19242068225ce9772e03ea1488a85c8fcc | |
parent | 106155a2395c539762fb37e5d045fd021352f499 (diff) |
Use std::vector over Vector for InputFlinger (1/3)
Replace Vector<T> with std::vector<T>.
Bug: 112399697
Test: atest inputflinger_tests
Change-Id: I8baec68f7a684d97210077f3e387ca1096586a25
23 files changed, 268 insertions, 335 deletions
diff --git a/include/input/IInputFlinger.h b/include/input/IInputFlinger.h index cd12fcd255..4365a3c4e3 100644 --- a/include/input/IInputFlinger.h +++ b/include/input/IInputFlinger.h @@ -22,7 +22,6 @@ #include <binder/IInterface.h> -#include <utils/Vector.h> #include <input/InputWindow.h> #include <input/ISetInputWindowsListener.h> @@ -36,7 +35,7 @@ class IInputFlinger : public IInterface { public: DECLARE_META_INTERFACE(InputFlinger) - virtual void setInputWindows(const Vector<InputWindowInfo>& inputHandles, + virtual void setInputWindows(const std::vector<InputWindowInfo>& inputHandles, const sp<ISetInputWindowsListener>& setInputWindowsListener) = 0; virtual void transferTouchFocus(const sp<IBinder>& fromToken, const sp<IBinder>& toToken) = 0; virtual void registerInputChannel(const sp<InputChannel>& channel) = 0; diff --git a/include/input/InputDevice.h b/include/input/InputDevice.h index 48ac88d50e..b6efc82fd4 100644 --- a/include/input/InputDevice.h +++ b/include/input/InputDevice.h @@ -19,6 +19,7 @@ #include <input/Input.h> #include <input/KeyCharacterMap.h> +#include <vector> namespace android { @@ -121,7 +122,7 @@ public: inline void setButtonUnderPad(bool hasButton) { mHasButtonUnderPad = hasButton; } inline bool hasButtonUnderPad() const { return mHasButtonUnderPad; } - inline const Vector<MotionRange>& getMotionRanges() const { + inline const std::vector<MotionRange>& getMotionRanges() const { return mMotionRanges; } @@ -139,7 +140,7 @@ private: bool mHasVibrator; bool mHasButtonUnderPad; - Vector<MotionRange> mMotionRanges; + std::vector<MotionRange> mMotionRanges; }; /* Types of input device configuration files. */ diff --git a/include/input/KeyLayoutMap.h b/include/input/KeyLayoutMap.h index 73815fe8b4..26f35012e2 100644 --- a/include/input/KeyLayoutMap.h +++ b/include/input/KeyLayoutMap.h @@ -66,7 +66,7 @@ public: status_t mapKey(int32_t scanCode, int32_t usageCode, int32_t* outKeyCode, uint32_t* outFlags) const; - status_t findScanCodesForKey(int32_t keyCode, Vector<int32_t>* outScanCodes) const; + status_t findScanCodesForKey(int32_t keyCode, std::vector<int32_t>* outScanCodes) const; status_t findScanCodeForLed(int32_t ledCode, int32_t* outScanCode) const; status_t findUsageCodeForLed(int32_t ledCode, int32_t* outUsageCode) const; diff --git a/include/input/VirtualKeyMap.h b/include/input/VirtualKeyMap.h index 4f7cfb6b75..6e8e2c9cf4 100644 --- a/include/input/VirtualKeyMap.h +++ b/include/input/VirtualKeyMap.h @@ -24,6 +24,7 @@ #include <utils/KeyedVector.h> #include <utils/Tokenizer.h> #include <utils/Unicode.h> +#include <vector> namespace android { @@ -51,7 +52,7 @@ public: static std::unique_ptr<VirtualKeyMap> load(const std::string& filename); - inline const Vector<VirtualKeyDefinition>& getVirtualKeys() const { + inline const std::vector<VirtualKeyDefinition>& getVirtualKeys() const { return mVirtualKeys; } @@ -70,7 +71,7 @@ private: bool parseNextIntField(int32_t* outValue); }; - Vector<VirtualKeyDefinition> mVirtualKeys; + std::vector<VirtualKeyDefinition> mVirtualKeys; VirtualKeyMap(); }; diff --git a/libs/input/IInputFlinger.cpp b/libs/input/IInputFlinger.cpp index 4ce5a10e5c..d6a73bfd27 100644 --- a/libs/input/IInputFlinger.cpp +++ b/libs/input/IInputFlinger.cpp @@ -30,7 +30,7 @@ public: explicit BpInputFlinger(const sp<IBinder>& impl) : BpInterface<IInputFlinger>(impl) { } - virtual void setInputWindows(const Vector<InputWindowInfo>& inputInfo, + virtual void setInputWindows(const std::vector<InputWindowInfo>& inputInfo, const sp<ISetInputWindowsListener>& setInputWindowsListener) { Parcel data, reply; data.writeInterfaceToken(IInputFlinger::getInterfaceDescriptor()); @@ -81,10 +81,9 @@ status_t BnInputFlinger::onTransact( if (count > data.dataSize()) { return BAD_VALUE; } - Vector<InputWindowInfo> handles; - handles.setCapacity(count); + std::vector<InputWindowInfo> handles; for (size_t i = 0; i < count; i++) { - handles.add(InputWindowInfo(data)); + handles.push_back(InputWindowInfo::read(data)); } const sp<ISetInputWindowsListener> setInputWindowsListener = ISetInputWindowsListener::asInterface(data.readStrongBinder()); diff --git a/libs/input/InputDevice.cpp b/libs/input/InputDevice.cpp index dab6eac2f4..4db9e06d8d 100644 --- a/libs/input/InputDevice.cpp +++ b/libs/input/InputDevice.cpp @@ -186,7 +186,7 @@ const InputDeviceInfo::MotionRange* InputDeviceInfo::getMotionRange( int32_t axis, uint32_t source) const { size_t numRanges = mMotionRanges.size(); for (size_t i = 0; i < numRanges; i++) { - const MotionRange& range = mMotionRanges.itemAt(i); + const MotionRange& range = mMotionRanges[i]; if (range.axis == axis && range.source == source) { return ⦥ } @@ -201,11 +201,11 @@ void InputDeviceInfo::addSource(uint32_t source) { void InputDeviceInfo::addMotionRange(int32_t axis, uint32_t source, float min, float max, float flat, float fuzz, float resolution) { MotionRange range = { axis, source, min, max, flat, fuzz, resolution }; - mMotionRanges.add(range); + mMotionRanges.push_back(range); } void InputDeviceInfo::addMotionRange(const MotionRange& range) { - mMotionRanges.add(range); + mMotionRanges.push_back(range); } } // namespace android diff --git a/libs/input/KeyLayoutMap.cpp b/libs/input/KeyLayoutMap.cpp index 88cb0dbdb4..efca68d171 100644 --- a/libs/input/KeyLayoutMap.cpp +++ b/libs/input/KeyLayoutMap.cpp @@ -120,11 +120,12 @@ const KeyLayoutMap::Key* KeyLayoutMap::getKey(int32_t scanCode, int32_t usageCod return nullptr; } -status_t KeyLayoutMap::findScanCodesForKey(int32_t keyCode, Vector<int32_t>* outScanCodes) const { +status_t KeyLayoutMap::findScanCodesForKey( + int32_t keyCode, std::vector<int32_t>* outScanCodes) const { const size_t N = mKeysByScanCode.size(); for (size_t i=0; i<N; i++) { if (mKeysByScanCode.valueAt(i).keyCode == keyCode) { - outScanCodes->add(mKeysByScanCode.keyAt(i)); + outScanCodes->push_back(mKeysByScanCode.keyAt(i)); } } return NO_ERROR; diff --git a/libs/input/VirtualKeyMap.cpp b/libs/input/VirtualKeyMap.cpp index 624f152996..865366bcb2 100644 --- a/libs/input/VirtualKeyMap.cpp +++ b/libs/input/VirtualKeyMap.cpp @@ -112,7 +112,7 @@ status_t VirtualKeyMap::Parser::parse() { "width=%d, height=%d", defn.scanCode, defn.centerX, defn.centerY, defn.width, defn.height); #endif - mMap->mVirtualKeys.push(defn); + mMap->mVirtualKeys.push_back(defn); } while (consumeFieldDelimiterAndSkipWhitespace()); if (!mTokenizer->isEol()) { diff --git a/services/inputflinger/EventHub.cpp b/services/inputflinger/EventHub.cpp index 4da1473904..0544ec16c5 100644 --- a/services/inputflinger/EventHub.cpp +++ b/services/inputflinger/EventHub.cpp @@ -415,14 +415,14 @@ int32_t EventHub::getKeyCodeState(int32_t deviceId, int32_t keyCode) const { Device* device = getDeviceLocked(deviceId); if (device && device->hasValidFd() && device->keyMap.haveKeyLayout()) { - Vector<int32_t> scanCodes; + std::vector<int32_t> scanCodes; device->keyMap.keyLayoutMap->findScanCodesForKey(keyCode, &scanCodes); if (scanCodes.size() != 0) { uint8_t keyState[sizeof_bit_array(KEY_MAX + 1)]; memset(keyState, 0, sizeof(keyState)); if (ioctl(device->fd, EVIOCGKEY(sizeof(keyState)), keyState) >= 0) { for (size_t i = 0; i < scanCodes.size(); i++) { - int32_t sc = scanCodes.itemAt(i); + int32_t sc = scanCodes[i]; if (sc >= 0 && sc <= KEY_MAX && test_bit(sc, keyState)) { return AKEY_STATE_DOWN; } @@ -478,7 +478,7 @@ bool EventHub::markSupportedKeyCodes(int32_t deviceId, size_t numCodes, Device* device = getDeviceLocked(deviceId); if (device && device->keyMap.haveKeyLayout()) { - Vector<int32_t> scanCodes; + std::vector<int32_t> scanCodes; for (size_t codeIndex = 0; codeIndex < numCodes; codeIndex++) { scanCodes.clear(); @@ -609,13 +609,15 @@ void EventHub::setLedStateLocked(Device* device, int32_t led, bool on) { } void EventHub::getVirtualKeyDefinitions(int32_t deviceId, - Vector<VirtualKeyDefinition>& outVirtualKeys) const { + std::vector<VirtualKeyDefinition>& outVirtualKeys) const { outVirtualKeys.clear(); AutoMutex _l(mLock); Device* device = getDeviceLocked(deviceId); if (device && device->virtualKeyMap) { - outVirtualKeys.appendVector(device->virtualKeyMap->getVirtualKeys()); + const std::vector<VirtualKeyDefinition> virtualKeys = + device->virtualKeyMap->getVirtualKeys(); + outVirtualKeys.insert(outVirtualKeys.end(), virtualKeys.begin(), virtualKeys.end()); } } @@ -1680,11 +1682,11 @@ bool EventHub::hasKeycodeLocked(Device* device, int keycode) const { return false; } - Vector<int32_t> scanCodes; + std::vector<int32_t> scanCodes; device->keyMap.keyLayoutMap->findScanCodesForKey(keycode, &scanCodes); const size_t N = scanCodes.size(); for (size_t i=0; i<N && i<=KEY_MAX; i++) { - int32_t sc = scanCodes.itemAt(i); + int32_t sc = scanCodes[i]; if (sc >= 0 && sc <= KEY_MAX && test_bit(sc, device->keyBitmask)) { return true; } diff --git a/services/inputflinger/EventHub.h b/services/inputflinger/EventHub.h index 44f7b3715a..63a20ef3e2 100644 --- a/services/inputflinger/EventHub.h +++ b/services/inputflinger/EventHub.h @@ -228,7 +228,7 @@ public: virtual void setLedState(int32_t deviceId, int32_t led, bool on) = 0; virtual void getVirtualKeyDefinitions(int32_t deviceId, - Vector<VirtualKeyDefinition>& outVirtualKeys) const = 0; + std::vector<VirtualKeyDefinition>& outVirtualKeys) const = 0; virtual sp<KeyCharacterMap> getKeyCharacterMap(int32_t deviceId) const = 0; virtual bool setKeyboardLayoutOverlay(int32_t deviceId, const sp<KeyCharacterMap>& map) = 0; @@ -304,7 +304,7 @@ public: virtual void setLedState(int32_t deviceId, int32_t led, bool on); virtual void getVirtualKeyDefinitions(int32_t deviceId, - Vector<VirtualKeyDefinition>& outVirtualKeys) const; + std::vector<VirtualKeyDefinition>& outVirtualKeys) const; virtual sp<KeyCharacterMap> getKeyCharacterMap(int32_t deviceId) const; virtual bool setKeyboardLayoutOverlay(int32_t deviceId, const sp<KeyCharacterMap>& map); diff --git a/services/inputflinger/InputDispatcher.cpp b/services/inputflinger/InputDispatcher.cpp index bcb1ec5fb8..131762060d 100644 --- a/services/inputflinger/InputDispatcher.cpp +++ b/services/inputflinger/InputDispatcher.cpp @@ -524,10 +524,8 @@ void InputDispatcher::addRecentEventLocked(EventEntry* entry) { sp<InputWindowHandle> InputDispatcher::findTouchedWindowAtLocked(int32_t displayId, int32_t x, int32_t y, bool addOutsideTargets, bool addPortalWindows) { // Traverse windows from front to back to find touched window. - const Vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - sp<InputWindowHandle> windowHandle = windowHandles.itemAt(i); + const std::vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); + for (const sp<InputWindowHandle>& windowHandle : windowHandles) { const InputWindowInfo* windowInfo = windowHandle->getInfo(); if (windowInfo->displayId == displayId) { int32_t flags = windowInfo->layoutParamsFlags; @@ -859,7 +857,7 @@ bool InputDispatcher::dispatchKeyLocked(nsecs_t currentTime, KeyEntry* entry, } // Identify targets. - Vector<InputTarget> inputTargets; + std::vector<InputTarget> inputTargets; int32_t injectionResult = findFocusedWindowTargetsLocked(currentTime, entry, inputTargets, nextWakeupTime); if (injectionResult == INPUT_EVENT_INJECTION_PENDING) { @@ -910,7 +908,7 @@ bool InputDispatcher::dispatchMotionLocked( bool isPointerEvent = entry->source & AINPUT_SOURCE_CLASS_POINTER; // Identify targets. - Vector<InputTarget> inputTargets; + std::vector<InputTarget> inputTargets; bool conflictingPointerActions = false; int32_t injectionResult; @@ -946,11 +944,11 @@ bool InputDispatcher::dispatchMotionLocked( ssize_t stateIndex = mTouchStatesByDisplay.indexOfKey(entry->displayId); if (stateIndex >= 0) { const TouchState& state = mTouchStatesByDisplay.valueAt(stateIndex); - if (!state.portalWindows.isEmpty()) { + if (!state.portalWindows.empty()) { // The event has gone through these portal windows, so we add monitoring targets of // the corresponding displays as well. for (size_t i = 0; i < state.portalWindows.size(); i++) { - const InputWindowInfo* windowInfo = state.portalWindows.itemAt(i)->getInfo(); + const InputWindowInfo* windowInfo = state.portalWindows[i]->getInfo(); addMonitoringTargetsLocked(inputTargets, windowInfo->portalToDisplayId, -windowInfo->frameLeft, -windowInfo->frameTop); } @@ -1004,7 +1002,7 @@ void InputDispatcher::logOutboundMotionDetails(const char* prefix, const MotionE } void InputDispatcher::dispatchEventLocked(nsecs_t currentTime, - EventEntry* eventEntry, const Vector<InputTarget>& inputTargets) { + EventEntry* eventEntry, const std::vector<InputTarget>& inputTargets) { #if DEBUG_DISPATCH_CYCLE ALOGD("dispatchEventToCurrentInputTargets"); #endif @@ -1013,9 +1011,7 @@ void InputDispatcher::dispatchEventLocked(nsecs_t currentTime, pokeUserActivityLocked(eventEntry); - for (size_t i = 0; i < inputTargets.size(); i++) { - const InputTarget& inputTarget = inputTargets.itemAt(i); - + for (const InputTarget& inputTarget : inputTargets) { ssize_t connectionIndex = getConnectionIndexLocked(inputTarget.inputChannel); if (connectionIndex >= 0) { sp<Connection> connection = mConnectionsByFd.valueAt(connectionIndex); @@ -1181,7 +1177,7 @@ int32_t InputDispatcher::getTargetDisplayId(const EventEntry* entry) { } int32_t InputDispatcher::findFocusedWindowTargetsLocked(nsecs_t currentTime, - const EventEntry* entry, Vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime) { + const EventEntry* entry, std::vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime) { int32_t injectionResult; std::string reason; @@ -1244,7 +1240,7 @@ Unresponsive: } int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, - const MotionEntry* entry, Vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime, + const MotionEntry* entry, std::vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime, bool* outConflictingPointerActions) { enum InjectionPermission { INJECTION_PERMISSION_UNKNOWN, @@ -1460,8 +1456,7 @@ int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, // is at least one touched foreground window. { bool haveForegroundWindow = false; - for (size_t i = 0; i < mTempTouchState.windows.size(); i++) { - const TouchedWindow& touchedWindow = mTempTouchState.windows[i]; + for (const TouchedWindow& touchedWindow : mTempTouchState.windows) { if (touchedWindow.targetFlags & InputTarget::FLAG_FOREGROUND) { haveForegroundWindow = true; if (! checkInjectionPermission(touchedWindow.windowHandle, @@ -1491,8 +1486,7 @@ int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, sp<InputWindowHandle> foregroundWindowHandle = mTempTouchState.getFirstForegroundWindowHandle(); const int32_t foregroundWindowUid = foregroundWindowHandle->getInfo()->ownerUid; - for (size_t i = 0; i < mTempTouchState.windows.size(); i++) { - const TouchedWindow& touchedWindow = mTempTouchState.windows[i]; + for (const TouchedWindow& touchedWindow : mTempTouchState.windows) { if (touchedWindow.targetFlags & InputTarget::FLAG_DISPATCH_AS_OUTSIDE) { sp<InputWindowHandle> inputWindowHandle = touchedWindow.windowHandle; if (inputWindowHandle->getInfo()->ownerUid != foregroundWindowUid) { @@ -1504,8 +1498,7 @@ int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, } // Ensure all touched foreground windows are ready for new input. - for (size_t i = 0; i < mTempTouchState.windows.size(); i++) { - const TouchedWindow& touchedWindow = mTempTouchState.windows[i]; + for (const TouchedWindow& touchedWindow : mTempTouchState.windows) { if (touchedWindow.targetFlags & InputTarget::FLAG_FOREGROUND) { // Check whether the window is ready for more input. std::string reason = checkWindowReadyForMoreInputLocked(currentTime, @@ -1528,10 +1521,9 @@ int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, sp<InputWindowHandle> foregroundWindowHandle = mTempTouchState.getFirstForegroundWindowHandle(); if (foregroundWindowHandle->getInfo()->hasWallpaper) { - const Vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - sp<InputWindowHandle> windowHandle = windowHandles.itemAt(i); + const std::vector<sp<InputWindowHandle>> windowHandles = + getWindowHandlesLocked(displayId); + for (const sp<InputWindowHandle>& windowHandle : windowHandles) { const InputWindowInfo* info = windowHandle->getInfo(); if (info->displayId == displayId && windowHandle->getInfo()->layoutParamsType @@ -1549,8 +1541,7 @@ int32_t InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, // Success! Output targets. injectionResult = INPUT_EVENT_INJECTION_SUCCEEDED; - for (size_t i = 0; i < mTempTouchState.windows.size(); i++) { - const TouchedWindow& touchedWindow = mTempTouchState.windows.itemAt(i); + for (const TouchedWindow& touchedWindow : mTempTouchState.windows) { addWindowTargetLocked(touchedWindow.windowHandle, touchedWindow.targetFlags, touchedWindow.pointerIds, inputTargets); } @@ -1613,11 +1604,11 @@ Failed: uint32_t pointerId = entry->pointerProperties[pointerIndex].id; for (size_t i = 0; i < mTempTouchState.windows.size(); ) { - TouchedWindow& touchedWindow = mTempTouchState.windows.editItemAt(i); + TouchedWindow& touchedWindow = mTempTouchState.windows[i]; if (touchedWindow.targetFlags & InputTarget::FLAG_SPLIT) { touchedWindow.pointerIds.clearBit(pointerId); if (touchedWindow.pointerIds.isEmpty()) { - mTempTouchState.windows.removeAt(i); + mTempTouchState.windows.erase(mTempTouchState.windows.begin() + i); continue; } } @@ -1664,17 +1655,15 @@ Unresponsive: } void InputDispatcher::addWindowTargetLocked(const sp<InputWindowHandle>& windowHandle, - int32_t targetFlags, BitSet32 pointerIds, Vector<InputTarget>& inputTargets) { + int32_t targetFlags, BitSet32 pointerIds, std::vector<InputTarget>& inputTargets) { sp<InputChannel> inputChannel = getInputChannelLocked(windowHandle->getToken()); if (inputChannel == nullptr) { ALOGW("Window %s already unregistered input channel", windowHandle->getName().c_str()); return; } - inputTargets.push(); - const InputWindowInfo* windowInfo = windowHandle->getInfo(); - InputTarget& target = inputTargets.editTop(); + InputTarget target; target.inputChannel = inputChannel; target.flags = targetFlags; target.xOffset = - windowInfo->frameLeft; @@ -1683,26 +1672,26 @@ void InputDispatcher::addWindowTargetLocked(const sp<InputWindowHandle>& windowH target.windowXScale = windowInfo->windowXScale; target.windowYScale = windowInfo->windowYScale; target.pointerIds = pointerIds; + inputTargets.push_back(target); } -void InputDispatcher::addMonitoringTargetsLocked(Vector<InputTarget>& inputTargets, +void InputDispatcher::addMonitoringTargetsLocked(std::vector<InputTarget>& inputTargets, int32_t displayId, float xOffset, float yOffset) { - std::unordered_map<int32_t, Vector<sp<InputChannel>>>::const_iterator it = + std::unordered_map<int32_t, std::vector<sp<InputChannel>>>::const_iterator it = mMonitoringChannelsByDisplay.find(displayId); if (it != mMonitoringChannelsByDisplay.end()) { - const Vector<sp<InputChannel>>& monitoringChannels = it->second; + const std::vector<sp<InputChannel>>& monitoringChannels = it->second; const size_t numChannels = monitoringChannels.size(); for (size_t i = 0; i < numChannels; i++) { - inputTargets.push(); - - InputTarget& target = inputTargets.editTop(); + InputTarget target; target.inputChannel = monitoringChannels[i]; target.flags = InputTarget::FLAG_DISPATCH_AS_IS; target.xOffset = xOffset; target.yOffset = yOffset; target.pointerIds.clear(); target.globalScaleFactor = 1.0f; + inputTargets.push_back(target); } } else { // If there is no monitor channel registered or all monitor channel unregistered, @@ -1735,10 +1724,8 @@ bool InputDispatcher::checkInjectionPermission(const sp<InputWindowHandle>& wind bool InputDispatcher::isWindowObscuredAtPointLocked( const sp<InputWindowHandle>& windowHandle, int32_t x, int32_t y) const { int32_t displayId = windowHandle->getInfo()->displayId; - const Vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - sp<InputWindowHandle> otherHandle = windowHandles.itemAt(i); + const std::vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); + for (const sp<InputWindowHandle>& otherHandle : windowHandles) { if (otherHandle == windowHandle) { break; } @@ -1756,11 +1743,9 @@ bool InputDispatcher::isWindowObscuredAtPointLocked( bool InputDispatcher::isWindowObscuredLocked(const sp<InputWindowHandle>& windowHandle) const { int32_t displayId = windowHandle->getInfo()->displayId; - const Vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); + const std::vector<sp<InputWindowHandle>> windowHandles = getWindowHandlesLocked(displayId); const InputWindowInfo* windowInfo = windowHandle->getInfo(); - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - sp<InputWindowHandle> otherHandle = windowHandles.itemAt(i); + for (const sp<InputWindowHandle>& otherHandle : windowHandles) { if (otherHandle == windowHandle) { break; } @@ -2333,7 +2318,7 @@ void InputDispatcher::synthesizeCancelationEventsForAllConnectionsLocked ( void InputDispatcher::synthesizeCancelationEventsForMonitorsLocked ( const CancelationOptions& options) { for (auto& it : mMonitoringChannelsByDisplay) { - const Vector<sp<InputChannel>>& monitoringChannels = it.second; + const std::vector<sp<InputChannel>>& monitoringChannels = it.second; const size_t numChannels = monitoringChannels.size(); for (size_t i = 0; i < numChannels; i++) { synthesizeCancelationEventsForInputChannelLocked(monitoringChannels[i], options); @@ -2358,11 +2343,11 @@ void InputDispatcher::synthesizeCancelationEventsForConnectionLocked( nsecs_t currentTime = now(); - Vector<EventEntry*> cancelationEvents; + std::vector<EventEntry*> cancelationEvents; connection->inputState.synthesizeCancelationEvents(currentTime, cancelationEvents, options); - if (!cancelationEvents.isEmpty()) { + if (!cancelationEvents.empty()) { #if DEBUG_OUTBOUND_EVENT_DETAILS ALOGD("channel '%s' ~ Synthesized %zu cancelation events to bring channel back in sync " "with reality: %s, mode=%d.", @@ -2370,7 +2355,7 @@ void InputDispatcher::synthesizeCancelationEventsForConnectionLocked( options.reason, options.mode); #endif for (size_t i = 0; i < cancelationEvents.size(); i++) { - EventEntry* cancelationEventEntry = cancelationEvents.itemAt(i); + EventEntry* cancelationEventEntry = cancelationEvents[i]; switch (cancelationEventEntry->type) { case EventEntry::TYPE_KEY: logOutboundKeyDetails("cancel - ", @@ -3011,24 +2996,23 @@ void InputDispatcher::decrementPendingForegroundDispatches(EventEntry* entry) { } } -Vector<sp<InputWindowHandle>> InputDispatcher::getWindowHandlesLocked(int32_t displayId) const { - std::unordered_map<int32_t, Vector<sp<InputWindowHandle>>>::const_iterator it = +std::vector<sp<InputWindowHandle>> InputDispatcher::getWindowHandlesLocked( + int32_t displayId) const { + std::unordered_map<int32_t, std::vector<sp<InputWindowHandle>>>::const_iterator it = mWindowHandlesByDisplay.find(displayId); if(it != mWindowHandlesByDisplay.end()) { return it->second; } // Return an empty one if nothing found. - return Vector<sp<InputWindowHandle>>(); + return std::vector<sp<InputWindowHandle>>(); } sp<InputWindowHandle> InputDispatcher::getWindowHandleLocked( const sp<IBinder>& windowHandleToken) const { for (auto& it : mWindowHandlesByDisplay) { - const Vector<sp<InputWindowHandle>> windowHandles = it.second; - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - const sp<InputWindowHandle>& windowHandle = windowHandles.itemAt(i); + const std::vector<sp<InputWindowHandle>> windowHandles = it.second; + for (const sp<InputWindowHandle>& windowHandle : windowHandles) { if (windowHandle->getToken() == windowHandleToken) { return windowHandle; } @@ -3039,11 +3023,9 @@ sp<InputWindowHandle> InputDispatcher::getWindowHandleLocked( bool InputDispatcher::hasWindowHandleLocked(const sp<InputWindowHandle>& windowHandle) const { for (auto& it : mWindowHandlesByDisplay) { - const Vector<sp<InputWindowHandle>> windowHandles = it.second; - size_t numWindows = windowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - if (windowHandles.itemAt(i)->getToken() - == windowHandle->getToken()) { + const std::vector<sp<InputWindowHandle>> windowHandles = it.second; + for (const sp<InputWindowHandle>& handle : windowHandles) { + if (handle->getToken() == windowHandle->getToken()) { if (windowHandle->getInfo()->displayId != it.first) { ALOGE("Found window %s in display %" PRId32 ", but it should belong to display %" PRId32, @@ -3072,7 +3054,7 @@ sp<InputChannel> InputDispatcher::getInputChannelLocked(const sp<IBinder>& token * For focused handle, check if need to change and send a cancel event to previous one. * For removed handle, check if need to send a cancel event if already in touch. */ -void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& inputWindowHandles, +void InputDispatcher::setInputWindows(const std::vector<sp<InputWindowHandle>>& inputWindowHandles, int32_t displayId, const sp<ISetInputWindowsListener>& setInputWindowsListener) { #if DEBUG_FOCUS ALOGD("setInputWindows displayId=%" PRId32, displayId); @@ -3081,28 +3063,27 @@ void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& input std::scoped_lock _l(mLock); // Copy old handles for release if they are no longer present. - const Vector<sp<InputWindowHandle>> oldWindowHandles = getWindowHandlesLocked(displayId); + const std::vector<sp<InputWindowHandle>> oldWindowHandles = + getWindowHandlesLocked(displayId); sp<InputWindowHandle> newFocusedWindowHandle = nullptr; bool foundHoveredWindow = false; - if (inputWindowHandles.isEmpty()) { + if (inputWindowHandles.empty()) { // Remove all handles on a display if there are no windows left. mWindowHandlesByDisplay.erase(displayId); } else { // Since we compare the pointer of input window handles across window updates, we need // to make sure the handle object for the same window stays unchanged across updates. - const Vector<sp<InputWindowHandle>>& oldHandles = mWindowHandlesByDisplay[displayId]; + const std::vector<sp<InputWindowHandle>>& oldHandles = + mWindowHandlesByDisplay[displayId]; std::unordered_map<sp<IBinder>, sp<InputWindowHandle>, IBinderHash> oldHandlesByTokens; - for (size_t i = 0; i < oldHandles.size(); i++) { - const sp<InputWindowHandle>& handle = oldHandles.itemAt(i); + for (const sp<InputWindowHandle>& handle : oldHandles) { oldHandlesByTokens[handle->getToken()] = handle; } - const size_t numWindows = inputWindowHandles.size(); - Vector<sp<InputWindowHandle>> newHandles; - for (size_t i = 0; i < numWindows; i++) { - const sp<InputWindowHandle>& handle = inputWindowHandles.itemAt(i); + std::vector<sp<InputWindowHandle>> newHandles; + for (const sp<InputWindowHandle>& handle : inputWindowHandles) { if (!handle->updateInfo() || (getInputChannelLocked(handle->getToken()) == nullptr && handle->getInfo()->portalToDisplayId == ADISPLAY_ID_NONE)) { ALOGE("Window handle %s has no registered input channel", @@ -3127,8 +3108,7 @@ void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& input } } - for (size_t i = 0; i < newHandles.size(); i++) { - const sp<InputWindowHandle>& windowHandle = newHandles.itemAt(i); + for (const sp<InputWindowHandle>& windowHandle : newHandles) { // Set newFocusedWindowHandle to the top most focused window instead of the last one if (!newFocusedWindowHandle && windowHandle->getInfo()->hasFocus && windowHandle->getInfo()->visible) { @@ -3184,7 +3164,7 @@ void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& input if (stateIndex >= 0) { TouchState& state = mTouchStatesByDisplay.editValueAt(stateIndex); for (size_t i = 0; i < state.windows.size(); ) { - TouchedWindow& touchedWindow = state.windows.editItemAt(i); + TouchedWindow& touchedWindow = state.windows[i]; if (!hasWindowHandleLocked(touchedWindow.windowHandle)) { #if DEBUG_FOCUS ALOGD("Touched window was removed: %s in display %" PRId32, @@ -3198,7 +3178,7 @@ void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& input synthesizeCancelationEventsForInputChannelLocked( touchedInputChannel, options); } - state.windows.removeAt(i); + state.windows.erase(state.windows.begin() + i); } else { ++i; } @@ -3209,9 +3189,7 @@ void InputDispatcher::setInputWindows(const Vector<sp<InputWindowHandle>>& input // This ensures that unused input channels are released promptly. // Otherwise, they might stick around until the window handle is destroyed // which might not happen until the next GC. - size_t numWindows = oldWindowHandles.size(); - for (size_t i = 0; i < numWindows; i++) { - const sp<InputWindowHandle>& oldWindowHandle = oldWindowHandles.itemAt(i); + for (const sp<InputWindowHandle>& oldWindowHandle : oldWindowHandles) { if (!hasWindowHandleLocked(oldWindowHandle)) { #if DEBUG_FOCUS ALOGD("Window went away: %s", oldWindowHandle->getName().c_str()); @@ -3415,7 +3393,7 @@ bool InputDispatcher::transferTouchFocus(const sp<IBinder>& fromToken, const sp< int32_t oldTargetFlags = touchedWindow.targetFlags; BitSet32 pointerIds = touchedWindow.pointerIds; - state.windows.removeAt(i); + state.windows.erase(state.windows.begin() + i); int32_t newTargetFlags = oldTargetFlags & (InputTarget::FLAG_FOREGROUND @@ -3531,7 +3509,7 @@ void InputDispatcher::dumpDispatchStateLocked(std::string& dump) { dump += StringPrintf(INDENT2 "%d: down=%s, split=%s, deviceId=%d, source=0x%08x\n", state.displayId, toString(state.down), toString(state.split), state.deviceId, state.source); - if (!state.windows.isEmpty()) { + if (!state.windows.empty()) { dump += INDENT3 "Windows:\n"; for (size_t i = 0; i < state.windows.size(); i++) { const TouchedWindow& touchedWindow = state.windows[i]; @@ -3543,10 +3521,10 @@ void InputDispatcher::dumpDispatchStateLocked(std::string& dump) { } else { dump += INDENT3 "Windows: <none>\n"; } - if (!state.portalWindows.isEmpty()) { + if (!state.portalWindows.empty()) { dump += INDENT3 "Portal windows:\n"; for (size_t i = 0; i < state.portalWindows.size(); i++) { - const sp<InputWindowHandle> portalWindowHandle = state.portalWindows.itemAt(i); + const sp<InputWindowHandle> portalWindowHandle = state.portalWindows[i]; dump += StringPrintf(INDENT4 "%zu: name='%s'\n", i, portalWindowHandle->getName().c_str()); } @@ -3558,12 +3536,12 @@ void InputDispatcher::dumpDispatchStateLocked(std::string& dump) { if (!mWindowHandlesByDisplay.empty()) { for (auto& it : mWindowHandlesByDisplay) { - const Vector<sp<InputWindowHandle>> windowHandles = it.second; + const std::vector<sp<InputWindowHandle>> windowHandles = it.second; dump += StringPrintf(INDENT "Display: %" PRId32 "\n", it.first); - if (!windowHandles.isEmpty()) { + if (!windowHandles.empty()) { dump += INDENT2 "Windows:\n"; for (size_t i = 0; i < windowHandles.size(); i++) { - const sp<InputWindowHandle>& windowHandle = windowHandles.itemAt(i); + const sp<InputWindowHandle>& windowHandle = windowHandles[i]; const InputWindowInfo* windowInfo = windowHandle->getInfo(); dump += StringPrintf(INDENT3 "%zu: name='%s', displayId=%d, " @@ -3600,7 +3578,7 @@ void InputDispatcher::dumpDispatchStateLocked(std::string& dump) { if (!mMonitoringChannelsByDisplay.empty()) { for (auto& it : mMonitoringChannelsByDisplay) { - const Vector<sp<InputChannel>>& monitoringChannels = it.second; + const std::vector<sp<InputChannel>>& monitoringChannels = it.second; dump += StringPrintf(INDENT "MonitoringChannels in display %" PRId32 ":\n", it.first); const size_t numChannels = monitoringChannels.size(); for (size_t i = 0; i < numChannels; i++) { @@ -3754,9 +3732,9 @@ status_t InputDispatcher::registerInputChannel(const sp<InputChannel>& inputChan // Store monitor channel by displayId. if (monitor) { - Vector<sp<InputChannel>>& monitoringChannels = + std::vector<sp<InputChannel>>& monitoringChannels = mMonitoringChannelsByDisplay[displayId]; - monitoringChannels.push(inputChannel); + monitoringChannels.push_back(inputChannel); } mLooper->addFd(fd, 0, ALOOPER_EVENT_INPUT, handleReceiveCallback, this); @@ -3817,11 +3795,11 @@ status_t InputDispatcher::unregisterInputChannelLocked(const sp<InputChannel>& i void InputDispatcher::removeMonitorChannelLocked(const sp<InputChannel>& inputChannel) { for (auto it = mMonitoringChannelsByDisplay.begin(); it != mMonitoringChannelsByDisplay.end(); ) { - Vector<sp<InputChannel>>& monitoringChannels = it->second; + std::vector<sp<InputChannel>>& monitoringChannels = it->second; const size_t numChannels = monitoringChannels.size(); for (size_t i = 0; i < numChannels; i++) { if (monitoringChannels[i] == inputChannel) { - monitoringChannels.removeAt(i); + monitoringChannels.erase(monitoringChannels.begin() + i); break; } } @@ -4495,13 +4473,12 @@ InputDispatcher::InputState::~InputState() { } bool InputDispatcher::InputState::isNeutral() const { - return mKeyMementos.isEmpty() && mMotionMementos.isEmpty(); + return mKeyMementos.empty() && mMotionMementos.empty(); } bool InputDispatcher::InputState::isHovering(int32_t deviceId, uint32_t source, int32_t displayId) const { - for (size_t i = 0; i < mMotionMementos.size(); i++) { - const MotionMemento& memento = mMotionMementos.itemAt(i); + for (const MotionMemento& memento : mMotionMementos) { if (memento.deviceId == deviceId && memento.source == source && memento.displayId == displayId @@ -4527,7 +4504,7 @@ bool InputDispatcher::InputState::trackKey(const KeyEntry* entry, } ssize_t index = findKeyMemento(entry); if (index >= 0) { - mKeyMementos.removeAt(index); + mKeyMementos.erase(mKeyMementos.begin() + index); return true; } /* FIXME: We can't just drop the key up event because that prevents creating @@ -4552,7 +4529,7 @@ bool InputDispatcher::InputState::trackKey(const KeyEntry* entry, case AKEY_EVENT_ACTION_DOWN: { ssize_t index = findKeyMemento(entry); if (index >= 0) { - mKeyMementos.removeAt(index); + mKeyMementos.erase(mKeyMementos.begin() + index); } addKeyMemento(entry, flags); return true; @@ -4571,7 +4548,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, case AMOTION_EVENT_ACTION_CANCEL: { ssize_t index = findMotionMemento(entry, false /*hovering*/); if (index >= 0) { - mMotionMementos.removeAt(index); + mMotionMementos.erase(mMotionMementos.begin() + index); return true; } #if DEBUG_OUTBOUND_EVENT_DETAILS @@ -4585,7 +4562,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, case AMOTION_EVENT_ACTION_DOWN: { ssize_t index = findMotionMemento(entry, false /*hovering*/); if (index >= 0) { - mMotionMementos.removeAt(index); + mMotionMementos.erase(mMotionMementos.begin() + index); } addMotionMemento(entry, flags, false /*hovering*/); return true; @@ -4610,9 +4587,9 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, // anything generating fallback events (e.g. DPad keys for joystick movements). if (index >= 0) { if (entry->pointerCoords[0].isEmpty()) { - mMotionMementos.removeAt(index); + mMotionMementos.erase(mMotionMementos.begin() + index); } else { - MotionMemento& memento = mMotionMementos.editItemAt(index); + MotionMemento& memento = mMotionMementos[index]; memento.setPointers(entry); } } else if (!entry->pointerCoords[0].isEmpty()) { @@ -4623,7 +4600,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, return true; } if (index >= 0) { - MotionMemento& memento = mMotionMementos.editItemAt(index); + MotionMemento& memento = mMotionMementos[index]; memento.setPointers(entry); return true; } @@ -4638,7 +4615,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, case AMOTION_EVENT_ACTION_HOVER_EXIT: { ssize_t index = findMotionMemento(entry, true /*hovering*/); if (index >= 0) { - mMotionMementos.removeAt(index); + mMotionMementos.erase(mMotionMementos.begin() + index); return true; } #if DEBUG_OUTBOUND_EVENT_DETAILS @@ -4653,7 +4630,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, case AMOTION_EVENT_ACTION_HOVER_MOVE: { ssize_t index = findMotionMemento(entry, true /*hovering*/); if (index >= 0) { - mMotionMementos.removeAt(index); + mMotionMementos.erase(mMotionMementos.begin() + index); } addMotionMemento(entry, flags, true /*hovering*/); return true; @@ -4666,7 +4643,7 @@ bool InputDispatcher::InputState::trackMotion(const MotionEntry* entry, ssize_t InputDispatcher::InputState::findKeyMemento(const KeyEntry* entry) const { for (size_t i = 0; i < mKeyMementos.size(); i++) { - const KeyMemento& memento = mKeyMementos.itemAt(i); + const KeyMemento& memento = mKeyMementos[i]; if (memento.deviceId == entry->deviceId && memento.source == entry->source && memento.displayId == entry->displayId @@ -4681,7 +4658,7 @@ ssize_t InputDispatcher::InputState::findKeyMemento(const KeyEntry* entry) const ssize_t InputDispatcher::InputState::findMotionMemento(const MotionEntry* entry, bool hovering) const { for (size_t i = 0; i < mMotionMementos.size(); i++) { - const MotionMemento& memento = mMotionMementos.itemAt(i); + const MotionMemento& memento = mMotionMementos[i]; if (memento.deviceId == entry->deviceId && memento.source == entry->source && memento.displayId == entry->displayId @@ -4693,8 +4670,7 @@ ssize_t InputDispatcher::InputState::findMotionMemento(const MotionEntry* entry, } void InputDispatcher::InputState::addKeyMemento(const KeyEntry* entry, int32_t flags) { - mKeyMementos.push(); - KeyMemento& memento = mKeyMementos.editTop(); + KeyMemento memento; memento.deviceId = entry->deviceId; memento.source = entry->source; memento.displayId = entry->displayId; @@ -4704,12 +4680,12 @@ void InputDispatcher::InputState::addKeyMemento(const KeyEntry* entry, int32_t f memento.flags = flags; memento.downTime = entry->downTime; memento.policyFlags = entry->policyFlags; + mKeyMementos.push_back(memento); } void InputDispatcher::InputState::addMotionMemento(const MotionEntry* entry, int32_t flags, bool hovering) { - mMotionMementos.push(); - MotionMemento& memento = mMotionMementos.editTop(); + MotionMemento memento; memento.deviceId = entry->deviceId; memento.source = entry->source; memento.displayId = entry->displayId; @@ -4720,6 +4696,7 @@ void InputDispatcher::InputState::addMotionMemento(const MotionEntry* entry, memento.setPointers(entry); memento.hovering = hovering; memento.policyFlags = entry->policyFlags; + mMotionMementos.push_back(memento); } void InputDispatcher::InputState::MotionMemento::setPointers(const MotionEntry* entry) { @@ -4731,23 +4708,21 @@ void InputDispatcher::InputState::MotionMemento::setPointers(const MotionEntry* } void InputDispatcher::InputState::synthesizeCancelationEvents(nsecs_t currentTime, - Vector<EventEntry*>& outEvents, const CancelationOptions& options) { - for (size_t i = 0; i < mKeyMementos.size(); i++) { - const KeyMemento& memento = mKeyMementos.itemAt(i); + std::vector<EventEntry*>& outEvents, const CancelationOptions& options) { + for (KeyMemento& memento : mKeyMementos) { if (shouldCancelKey(memento, options)) { - outEvents.push(new KeyEntry(SYNTHESIZED_EVENT_SEQUENCE_NUM, currentTime, + outEvents.push_back(new KeyEntry(SYNTHESIZED_EVENT_SEQUENCE_NUM, currentTime, memento.deviceId, memento.source, memento.displayId, memento.policyFlags, AKEY_EVENT_ACTION_UP, memento.flags | AKEY_EVENT_FLAG_CANCELED, memento.keyCode, memento.scanCode, memento.metaState, 0, memento.downTime)); } } - for (size_t i = 0; i < mMotionMementos.size(); i++) { - const MotionMemento& memento = mMotionMementos.itemAt(i); + for (const MotionMemento& memento : mMotionMementos) { if (shouldCancelMotion(memento, options)) { const int32_t action = memento.hovering ? AMOTION_EVENT_ACTION_HOVER_EXIT : AMOTION_EVENT_ACTION_CANCEL; - outEvents.push(new MotionEntry(SYNTHESIZED_EVENT_SEQUENCE_NUM, currentTime, + outEvents.push_back(new MotionEntry(SYNTHESIZED_EVENT_SEQUENCE_NUM, currentTime, memento.deviceId, memento.source, memento.displayId, memento.policyFlags, action, 0 /*actionButton*/, memento.flags, AMETA_NONE, 0 /*buttonState*/, MotionClassification::NONE, AMOTION_EVENT_EDGE_FLAG_NONE, @@ -4766,19 +4741,19 @@ void InputDispatcher::InputState::clear() { void InputDispatcher::InputState::copyPointerStateTo(InputState& other) const { for (size_t i = 0; i < mMotionMementos.size(); i++) { - const MotionMemento& memento = mMotionMementos.itemAt(i); + const MotionMemento& memento = mMotionMementos[i]; if (memento.source & AINPUT_SOURCE_CLASS_POINTER) { for (size_t j = 0; j < other.mMotionMementos.size(); ) { - const MotionMemento& otherMemento = other.mMotionMementos.itemAt(j); + const MotionMemento& otherMemento = other.mMotionMementos[j]; if (memento.deviceId == otherMemento.deviceId && memento.source == otherMemento.source && memento.displayId == otherMemento.displayId) { - other.mMotionMementos.removeAt(j); + other.mMotionMementos.erase(other.mMotionMementos.begin() + j); } else { j += 1; } } - other.mMotionMementos.push(memento); + other.mMotionMementos.push_back(memento); } } } @@ -4940,7 +4915,7 @@ void InputDispatcher::TouchState::addOrUpdateWindow(const sp<InputWindowHandle>& } for (size_t i = 0; i < windows.size(); i++) { - TouchedWindow& touchedWindow = windows.editItemAt(i); + TouchedWindow& touchedWindow = windows[i]; if (touchedWindow.windowHandle == windowHandle) { touchedWindow.targetFlags |= targetFlags; if (targetFlags & InputTarget::FLAG_DISPATCH_AS_SLIPPERY_EXIT) { @@ -4951,19 +4926,17 @@ void InputDispatcher::TouchState::addOrUpdateWindow(const sp<InputWindowHandle>& } } - windows.push(); - - TouchedWindow& touchedWindow = windows.editTop(); + TouchedWindow touchedWindow; touchedWindow.windowHandle = windowHandle; touchedWindow.targetFlags = targetFlags; touchedWindow.pointerIds = pointerIds; + windows.push_back(touchedWindow); } void InputDispatcher::TouchState::addPortalWindow(const sp<InputWindowHandle>& windowHandle) { size_t numWindows = portalWindows.size(); for (size_t i = 0; i < numWindows; i++) { - sp<InputWindowHandle> portalWindowHandle = portalWindows.itemAt(i); - if (portalWindowHandle == windowHandle) { + if (portalWindows[i] == windowHandle) { return; } } @@ -4972,8 +4945,8 @@ void InputDispatcher::TouchState::addPortalWindow(const sp<InputWindowHandle>& w void InputDispatcher::TouchState::removeWindow(const sp<InputWindowHandle>& windowHandle) { for (size_t i = 0; i < windows.size(); i++) { - if (windows.itemAt(i).windowHandle == windowHandle) { - windows.removeAt(i); + if (windows[i].windowHandle == windowHandle) { + windows.erase(windows.begin() + i); return; } } @@ -4981,8 +4954,8 @@ void InputDispatcher::TouchState::removeWindow(const sp<InputWindowHandle>& wind void InputDispatcher::TouchState::removeWindowByToken(const sp<IBinder>& token) { for (size_t i = 0; i < windows.size(); i++) { - if (windows.itemAt(i).windowHandle->getToken() == token) { - windows.removeAt(i); + if (windows[i].windowHandle->getToken() == token) { + windows.erase(windows.begin() + i); return; } } @@ -4990,21 +4963,21 @@ void InputDispatcher::TouchState::removeWindowByToken(const sp<IBinder>& token) void InputDispatcher::TouchState::filterNonAsIsTouchWindows() { for (size_t i = 0 ; i < windows.size(); ) { - TouchedWindow& window = windows.editItemAt(i); + TouchedWindow& window = windows[i]; if (window.targetFlags & (InputTarget::FLAG_DISPATCH_AS_IS | InputTarget::FLAG_DISPATCH_AS_SLIPPERY_ENTER)) { window.targetFlags &= ~InputTarget::FLAG_DISPATCH_MASK; window.targetFlags |= InputTarget::FLAG_DISPATCH_AS_IS; i += 1; } else { - windows.removeAt(i); + windows.erase(windows.begin() + i); } } } sp<InputWindowHandle> InputDispatcher::TouchState::getFirstForegroundWindowHandle() const { for (size_t i = 0; i < windows.size(); i++) { - const TouchedWindow& window = windows.itemAt(i); + const TouchedWindow& window = windows[i]; if (window.targetFlags & InputTarget::FLAG_FOREGROUND) { return window.windowHandle; } @@ -5015,8 +4988,7 @@ sp<InputWindowHandle> InputDispatcher::TouchState::getFirstForegroundWindowHandl bool InputDispatcher::TouchState::isSlippery() const { // Must have exactly one foreground window. bool haveSlipperyForegroundWindow = false; - for (size_t i = 0; i < windows.size(); i++) { - const TouchedWindow& window = windows.itemAt(i); + for (const TouchedWindow& window : windows) { if (window.targetFlags & InputTarget::FLAG_FOREGROUND) { if (haveSlipperyForegroundWindow || !(window.windowHandle->getInfo()->layoutParamsFlags diff --git a/services/inputflinger/InputDispatcher.h b/services/inputflinger/InputDispatcher.h index 24ae32fcf5..4d2c2167ac 100644 --- a/services/inputflinger/InputDispatcher.h +++ b/services/inputflinger/InputDispatcher.h @@ -23,8 +23,6 @@ #include <input/InputTransport.h> #include <input/InputWindow.h> #include <input/ISetInputWindowsListener.h> -#include <utils/KeyedVector.h> -#include <utils/Vector.h> #include <utils/threads.h> #include <utils/Timers.h> #include <utils/RefBase.h> @@ -315,7 +313,7 @@ public: * * This method may be called on any thread (usually by the input manager). */ - virtual void setInputWindows(const Vector<sp<InputWindowHandle> >& inputWindowHandles, + virtual void setInputWindows(const std::vector<sp<InputWindowHandle> >& inputWindowHandles, int32_t displayId, const sp<ISetInputWindowsListener>& setInputWindowsListener = nullptr) = 0; @@ -407,7 +405,7 @@ public: int32_t injectorPid, int32_t injectorUid, int32_t syncMode, int32_t timeoutMillis, uint32_t policyFlags); - virtual void setInputWindows(const Vector<sp<InputWindowHandle> >& inputWindowHandles, + virtual void setInputWindows(const std::vector<sp<InputWindowHandle> >& inputWindowHandles, int32_t displayId, const sp<ISetInputWindowsListener>& setInputWindowsListener = nullptr); virtual void setFocusedApplication(int32_t displayId, @@ -762,7 +760,7 @@ private: // Synthesizes cancelation events for the current state and resets the tracked state. void synthesizeCancelationEvents(nsecs_t currentTime, - Vector<EventEntry*>& outEvents, const CancelationOptions& options); + std::vector<EventEntry*>& outEvents, const CancelationOptions& options); // Clears the current state. void clear(); @@ -815,8 +813,8 @@ private: void setPointers(const MotionEntry* entry); }; - Vector<KeyMemento> mKeyMementos; - Vector<MotionMemento> mMotionMementos; + std::vector<KeyMemento> mKeyMementos; + std::vector<MotionMemento> mMotionMementos; KeyedVector<int32_t, int32_t> mFallbackKeys; ssize_t findKeyMemento(const KeyEntry* entry) const; @@ -941,7 +939,7 @@ private: ssize_t getConnectionIndexLocked(const sp<InputChannel>& inputChannel) REQUIRES(mLock); // Input channels that will receive a copy of all input events sent to the provided display. - std::unordered_map<int32_t, Vector<sp<InputChannel>>> mMonitoringChannelsByDisplay + std::unordered_map<int32_t, std::vector<sp<InputChannel>>> mMonitoringChannelsByDisplay GUARDED_BY(mLock); // Event injection and synchronization. @@ -998,10 +996,11 @@ private: bool mDispatchFrozen GUARDED_BY(mLock); bool mInputFilterEnabled GUARDED_BY(mLock); - std::unordered_map<int32_t, Vector<sp<InputWindowHandle>>> mWindowHandlesByDisplay + std::unordered_map<int32_t, std::vector<sp<InputWindowHandle>>> mWindowHandlesByDisplay GUARDED_BY(mLock); // Get window handles by display, return an empty vector if not found. - Vector<sp<InputWindowHandle>> getWindowHandlesLocked(int32_t displayId) const REQUIRES(mLock); + std::vector<sp<InputWindowHandle>> getWindowHandlesLocked(int32_t displayId) const + REQUIRES(mLock); sp<InputWindowHandle> getWindowHandleLocked(const sp<IBinder>& windowHandleToken) const REQUIRES(mLock); sp<InputChannel> getInputChannelLocked(const sp<IBinder>& windowToken) const REQUIRES(mLock); @@ -1023,12 +1022,12 @@ private: int32_t deviceId; // id of the device that is currently down, others are rejected uint32_t source; // source of the device that is current down, others are rejected int32_t displayId; // id to the display that currently has a touch, others are rejected - Vector<TouchedWindow> windows; + std::vector<TouchedWindow> windows; // This collects the portal windows that the touch has gone through. Each portal window // targets a display (embedded display for most cases). With this info, we can add the // monitoring channels of the displays touched. - Vector<sp<InputWindowHandle>> portalWindows; + std::vector<sp<InputWindowHandle>> portalWindows; TouchState(); ~TouchState(); @@ -1069,7 +1068,7 @@ private: nsecs_t currentTime, MotionEntry* entry, DropReason* dropReason, nsecs_t* nextWakeupTime) REQUIRES(mLock); void dispatchEventLocked(nsecs_t currentTime, EventEntry* entry, - const Vector<InputTarget>& inputTargets) REQUIRES(mLock); + const std::vector<InputTarget>& inputTargets) REQUIRES(mLock); void logOutboundKeyDetails(const char* prefix, const KeyEntry* entry); void logOutboundMotionDetails(const char* prefix, const MotionEntry* entry); @@ -1105,15 +1104,15 @@ private: int32_t getTargetDisplayId(const EventEntry* entry); int32_t findFocusedWindowTargetsLocked(nsecs_t currentTime, const EventEntry* entry, - Vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime) REQUIRES(mLock); + std::vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime) REQUIRES(mLock); int32_t findTouchedWindowTargetsLocked(nsecs_t currentTime, const MotionEntry* entry, - Vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime, + std::vector<InputTarget>& inputTargets, nsecs_t* nextWakeupTime, bool* outConflictingPointerActions) REQUIRES(mLock); void addWindowTargetLocked(const sp<InputWindowHandle>& windowHandle, - int32_t targetFlags, BitSet32 pointerIds, Vector<InputTarget>& inputTargets) + int32_t targetFlags, BitSet32 pointerIds, std::vector<InputTarget>& inputTargets) REQUIRES(mLock); - void addMonitoringTargetsLocked(Vector<InputTarget>& inputTargets, int32_t displayId, + void addMonitoringTargetsLocked(std::vector<InputTarget>& inputTargets, int32_t displayId, float xOffset = 0, float yOffset = 0) REQUIRES(mLock); void pokeUserActivityLocked(const EventEntry* eventEntry) REQUIRES(mLock); diff --git a/services/inputflinger/InputListener.cpp b/services/inputflinger/InputListener.cpp index a403f31493..423b69cff3 100644 --- a/services/inputflinger/InputListener.cpp +++ b/services/inputflinger/InputListener.cpp @@ -229,23 +229,23 @@ QueuedInputListener::~QueuedInputListener() { void QueuedInputListener::notifyConfigurationChanged( const NotifyConfigurationChangedArgs* args) { - mArgsQueue.push(new NotifyConfigurationChangedArgs(*args)); + mArgsQueue.push_back(new NotifyConfigurationChangedArgs(*args)); } void QueuedInputListener::notifyKey(const NotifyKeyArgs* args) { - mArgsQueue.push(new NotifyKeyArgs(*args)); + mArgsQueue.push_back(new NotifyKeyArgs(*args)); } void QueuedInputListener::notifyMotion(const NotifyMotionArgs* args) { - mArgsQueue.push(new NotifyMotionArgs(*args)); + mArgsQueue.push_back(new NotifyMotionArgs(*args)); } void QueuedInputListener::notifySwitch(const NotifySwitchArgs* args) { - mArgsQueue.push(new NotifySwitchArgs(*args)); + mArgsQueue.push_back(new NotifySwitchArgs(*args)); } void QueuedInputListener::notifyDeviceReset(const NotifyDeviceResetArgs* args) { - mArgsQueue.push(new NotifyDeviceResetArgs(*args)); + mArgsQueue.push_back(new NotifyDeviceResetArgs(*args)); } void QueuedInputListener::flush() { diff --git a/services/inputflinger/InputManager.cpp b/services/inputflinger/InputManager.cpp index b0157a166f..3996cca646 100644 --- a/services/inputflinger/InputManager.cpp +++ b/services/inputflinger/InputManager.cpp @@ -103,14 +103,14 @@ public: } }; -void InputManager::setInputWindows(const Vector<InputWindowInfo>& infos, +void InputManager::setInputWindows(const std::vector<InputWindowInfo>& infos, const sp<ISetInputWindowsListener>& setInputWindowsListener) { - std::unordered_map<int32_t, Vector<sp<InputWindowHandle>>> handlesPerDisplay; + std::unordered_map<int32_t, std::vector<sp<InputWindowHandle>>> handlesPerDisplay; - Vector<sp<InputWindowHandle>> handles; + std::vector<sp<InputWindowHandle>> handles; for (const auto& info : infos) { - handlesPerDisplay.emplace(info.displayId, Vector<sp<InputWindowHandle>>()); - handlesPerDisplay[info.displayId].add(new BinderWindowHandle(info)); + handlesPerDisplay.emplace(info.displayId, std::vector<sp<InputWindowHandle>>()); + handlesPerDisplay[info.displayId].push_back(new BinderWindowHandle(info)); } for (auto const& i : handlesPerDisplay) { mDispatcher->setInputWindows(i.second, i.first, setInputWindowsListener); diff --git a/services/inputflinger/InputManager.h b/services/inputflinger/InputManager.h index ff9a0800da..e568df54df 100644 --- a/services/inputflinger/InputManager.h +++ b/services/inputflinger/InputManager.h @@ -94,7 +94,7 @@ public: virtual sp<InputClassifierInterface> getClassifier(); virtual sp<InputDispatcherInterface> getDispatcher(); - virtual void setInputWindows(const Vector<InputWindowInfo>& handles, + virtual void setInputWindows(const std::vector<InputWindowInfo>& handles, const sp<ISetInputWindowsListener>& setInputWindowsListener); virtual void transferTouchFocus(const sp<IBinder>& fromToken, const sp<IBinder>& toToken); diff --git a/services/inputflinger/InputReader.cpp b/services/inputflinger/InputReader.cpp index 21ba029854..0cc37a016b 100644 --- a/services/inputflinger/InputReader.cpp +++ b/services/inputflinger/InputReader.cpp @@ -287,7 +287,7 @@ void InputReader::loopOnce() { int32_t oldGeneration; int32_t timeoutMillis; bool inputDevicesChanged = false; - Vector<InputDeviceInfo> inputDevices; + std::vector<InputDeviceInfo> inputDevices; { // acquire lock AutoMutex _l(mLock); @@ -590,12 +590,13 @@ void InputReader::notifyExternalStylusPresenceChanged() { refreshConfigurationLocked(InputReaderConfiguration::CHANGE_EXTERNAL_STYLUS_PRESENCE); } -void InputReader::getExternalStylusDevicesLocked(Vector<InputDeviceInfo>& outDevices) { +void InputReader::getExternalStylusDevicesLocked(std::vector<InputDeviceInfo>& outDevices) { for (size_t i = 0; i < mDevices.size(); i++) { InputDevice* device = mDevices.valueAt(i); if (device->getClasses() & INPUT_DEVICE_CLASS_EXTERNAL_STYLUS && !device->isIgnored()) { - outDevices.push(); - device->getDeviceInfo(&outDevices.editTop()); + InputDeviceInfo info; + device->getDeviceInfo(&info); + outDevices.push_back(info); } } } @@ -643,20 +644,21 @@ int32_t InputReader::bumpGenerationLocked() { return ++mGeneration; } -void InputReader::getInputDevices(Vector<InputDeviceInfo>& outInputDevices) { +void InputReader::getInputDevices(std::vector<InputDeviceInfo>& outInputDevices) { AutoMutex _l(mLock); getInputDevicesLocked(outInputDevices); } -void InputReader::getInputDevicesLocked(Vector<InputDeviceInfo>& outInputDevices) { +void InputReader::getInputDevicesLocked(std::vector<InputDeviceInfo>& outInputDevices) { outInputDevices.clear(); size_t numDevices = mDevices.size(); for (size_t i = 0; i < numDevices; i++) { InputDevice* device = mDevices.valueAt(i); if (!device->isIgnored()) { - outInputDevices.push(); - device->getDeviceInfo(&outInputDevices.editTop()); + InputDeviceInfo info; + device->getDeviceInfo(&info); + outInputDevices.push_back(info); } } } @@ -951,7 +953,7 @@ int32_t InputReader::ContextImpl::bumpGeneration() { return mReader->bumpGenerationLocked(); } -void InputReader::ContextImpl::getExternalStylusDevices(Vector<InputDeviceInfo>& outDevices) { +void InputReader::ContextImpl::getExternalStylusDevices(std::vector<InputDeviceInfo>& outDevices) { // lock is already held by whatever called refreshConfigurationLocked mReader->getExternalStylusDevicesLocked(outDevices); } @@ -1031,11 +1033,11 @@ void InputDevice::dump(std::string& dump) { dump += StringPrintf(INDENT2 "Sources: 0x%08x\n", deviceInfo.getSources()); dump += StringPrintf(INDENT2 "KeyboardType: %d\n", deviceInfo.getKeyboardType()); - const Vector<InputDeviceInfo::MotionRange>& ranges = deviceInfo.getMotionRanges(); - if (!ranges.isEmpty()) { + const std::vector<InputDeviceInfo::MotionRange>& ranges = deviceInfo.getMotionRanges(); + if (!ranges.empty()) { dump += INDENT2 "Motion Ranges:\n"; for (size_t i = 0; i < ranges.size(); i++) { - const InputDeviceInfo::MotionRange& range = ranges.itemAt(i); + const InputDeviceInfo::MotionRange& range = ranges[i]; const char* label = getAxisLabel(range.axis); char name[32]; if (label) { @@ -1059,7 +1061,7 @@ void InputDevice::dump(std::string& dump) { } void InputDevice::addMapper(InputMapper* mapper) { - mMappers.add(mapper); + mMappers.push_back(mapper); } void InputDevice::configure(nsecs_t when, const InputReaderConfiguration* config, uint32_t changes) { @@ -1110,9 +1112,7 @@ void InputDevice::configure(nsecs_t when, const InputReaderConfiguration* config } } - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->configure(when, config, changes); mSources |= mapper->getSources(); } @@ -1120,9 +1120,7 @@ void InputDevice::configure(nsecs_t when, const InputReaderConfiguration* config } void InputDevice::reset(nsecs_t when) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->reset(when); } @@ -1137,7 +1135,6 @@ void InputDevice::process(const RawEvent* rawEvents, size_t count) { // have side-effects that must be interleaved. For example, joystick movement events and // gamepad button presses are handled by different mappers but they should be dispatched // in the order received. - size_t numMappers = mMappers.size(); for (const RawEvent* rawEvent = rawEvents; count != 0; rawEvent++) { #if DEBUG_RAW_EVENTS ALOGD("Input event: device=%d type=0x%04x code=0x%04x value=0x%08x when=%" PRId64, @@ -1161,8 +1158,7 @@ void InputDevice::process(const RawEvent* rawEvents, size_t count) { mDropUntilNextSync = true; reset(rawEvent->when); } else { - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->process(rawEvent); } } @@ -1171,17 +1167,13 @@ void InputDevice::process(const RawEvent* rawEvents, size_t count) { } void InputDevice::timeoutExpired(nsecs_t when) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->timeoutExpired(when); } } void InputDevice::updateExternalStylusState(const StylusState& state) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->updateExternalStylusState(state); } } @@ -1189,9 +1181,7 @@ void InputDevice::updateExternalStylusState(const StylusState& state) { void InputDevice::getDeviceInfo(InputDeviceInfo* outDeviceInfo) { outDeviceInfo->initialize(mId, mGeneration, mControllerNumber, mIdentifier, mAlias, mIsExternal, mHasMic); - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->populateDeviceInfo(outDeviceInfo); } } @@ -1210,9 +1200,7 @@ int32_t InputDevice::getSwitchState(uint32_t sourceMask, int32_t switchCode) { int32_t InputDevice::getState(uint32_t sourceMask, int32_t code, GetStateFunc getStateFunc) { int32_t result = AKEY_STATE_UNKNOWN; - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { if (sourcesMatchMask(mapper->getSources(), sourceMask)) { // If any mapper reports AKEY_STATE_DOWN or AKEY_STATE_VIRTUAL, return that // value. Otherwise, return AKEY_STATE_UP as long as one mapper reports it. @@ -1230,9 +1218,7 @@ int32_t InputDevice::getState(uint32_t sourceMask, int32_t code, GetStateFunc ge bool InputDevice::markSupportedKeyCodes(uint32_t sourceMask, size_t numCodes, const int32_t* keyCodes, uint8_t* outFlags) { bool result = false; - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { if (sourcesMatchMask(mapper->getSources(), sourceMask)) { result |= mapper->markSupportedKeyCodes(sourceMask, numCodes, keyCodes, outFlags); } @@ -1242,50 +1228,39 @@ bool InputDevice::markSupportedKeyCodes(uint32_t sourceMask, size_t numCodes, void InputDevice::vibrate(const nsecs_t* pattern, size_t patternSize, ssize_t repeat, int32_t token) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->vibrate(pattern, patternSize, repeat, token); } } void InputDevice::cancelVibrate(int32_t token) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->cancelVibrate(token); } } void InputDevice::cancelTouch(nsecs_t when) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->cancelTouch(when); } } int32_t InputDevice::getMetaState() { int32_t result = 0; - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { result |= mapper->getMetaState(); } return result; } void InputDevice::updateMetaState(int32_t keyCode) { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - mMappers[i]->updateMetaState(keyCode); + for (InputMapper* mapper : mMappers) { + mapper->updateMetaState(keyCode); } } void InputDevice::fadePointer() { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { mapper->fadePointer(); } } @@ -1300,9 +1275,7 @@ void InputDevice::notifyReset(nsecs_t when) { } std::optional<int32_t> InputDevice::getAssociatedDisplay() { - size_t numMappers = mMappers.size(); - for (size_t i = 0; i < numMappers; i++) { - InputMapper* mapper = mMappers[i]; + for (InputMapper* mapper : mMappers) { std::optional<int32_t> associatedDisplayId = mapper->getAssociatedDisplay(); if (associatedDisplayId) { return associatedDisplayId; @@ -2405,7 +2378,7 @@ void KeyboardInputMapper::processKey(nsecs_t when, bool down, int32_t scanCode, ssize_t keyDownIndex = findKeyDown(scanCode); if (keyDownIndex >= 0) { // key repeat, be sure to use same keycode as before in case of rotation - keyCode = mKeyDowns.itemAt(keyDownIndex).keyCode; + keyCode = mKeyDowns[keyDownIndex].keyCode; } else { // key down if ((policyFlags & POLICY_FLAG_VIRTUAL) @@ -2417,10 +2390,10 @@ void KeyboardInputMapper::processKey(nsecs_t when, bool down, int32_t scanCode, mDevice->cancelTouch(when); } - mKeyDowns.push(); - KeyDown& keyDown = mKeyDowns.editTop(); + KeyDown keyDown; keyDown.keyCode = keyCode; keyDown.scanCode = scanCode; + mKeyDowns.push_back(keyDown); } mDownTime = when; @@ -2429,8 +2402,8 @@ void KeyboardInputMapper::processKey(nsecs_t when, bool down, int32_t scanCode, ssize_t keyDownIndex = findKeyDown(scanCode); if (keyDownIndex >= 0) { // key up, be sure to use same keycode as before in case of rotation - keyCode = mKeyDowns.itemAt(keyDownIndex).keyCode; - mKeyDowns.removeAt(size_t(keyDownIndex)); + keyCode = mKeyDowns[keyDownIndex].keyCode; + mKeyDowns.erase(mKeyDowns.begin() + (size_t)keyDownIndex); } else { // key was not actually down ALOGI("Dropping key up from device %s because the key was not down. " @@ -3316,9 +3289,9 @@ void TouchInputMapper::configure(nsecs_t when, } void TouchInputMapper::resolveExternalStylusPresence() { - Vector<InputDeviceInfo> devices; + std::vector<InputDeviceInfo> devices; mContext->getExternalStylusDevices(devices); - mExternalStylusConnected = !devices.isEmpty(); + mExternalStylusConnected = !devices.empty(); if (!mExternalStylusConnected) { resetExternalStylus(); @@ -3967,7 +3940,7 @@ void TouchInputMapper::dumpSurface(std::string& dump) { } void TouchInputMapper::configureVirtualKeys() { - Vector<VirtualKeyDefinition> virtualKeyDefinitions; + std::vector<VirtualKeyDefinition> virtualKeyDefinitions; getEventHub()->getVirtualKeyDefinitions(getDeviceId(), virtualKeyDefinitions); mVirtualKeys.clear(); @@ -3976,19 +3949,13 @@ void TouchInputMapper::configureVirtualKeys() { return; } - mVirtualKeys.setCapacity(virtualKeyDefinitions.size()); - int32_t touchScreenLeft = mRawPointerAxes.x.minValue; int32_t touchScreenTop = mRawPointerAxes.y.minValue; int32_t touchScreenWidth = mRawPointerAxes.getRawWidth(); int32_t touchScreenHeight = mRawPointerAxes.getRawHeight(); - for (size_t i = 0; i < virtualKeyDefinitions.size(); i++) { - const VirtualKeyDefinition& virtualKeyDefinition = - virtualKeyDefinitions[i]; - - mVirtualKeys.add(); - VirtualKey& virtualKey = mVirtualKeys.editTop(); + for (const VirtualKeyDefinition& virtualKeyDefinition : virtualKeyDefinitions) { + VirtualKey virtualKey; virtualKey.scanCode = virtualKeyDefinition.scanCode; int32_t keyCode; @@ -3998,8 +3965,7 @@ void TouchInputMapper::configureVirtualKeys() { &keyCode, &dummyKeyMetaState, &flags)) { ALOGW(INDENT "VirtualKey %d: could not obtain key code, ignoring", virtualKey.scanCode); - mVirtualKeys.pop(); // drop the key - continue; + continue; // drop the key } virtualKey.keyCode = keyCode; @@ -4017,15 +3983,16 @@ void TouchInputMapper::configureVirtualKeys() { * touchScreenHeight / mSurfaceHeight + touchScreenTop; virtualKey.hitBottom = (virtualKeyDefinition.centerY + halfHeight) * touchScreenHeight / mSurfaceHeight + touchScreenTop; + mVirtualKeys.push_back(virtualKey); } } void TouchInputMapper::dumpVirtualKeys(std::string& dump) { - if (!mVirtualKeys.isEmpty()) { + if (!mVirtualKeys.empty()) { dump += INDENT3 "Virtual Keys:\n"; for (size_t i = 0; i < mVirtualKeys.size(); i++) { - const VirtualKey& virtualKey = mVirtualKeys.itemAt(i); + const VirtualKey& virtualKey = mVirtualKeys[i]; dump += StringPrintf(INDENT4 "%zu: scanCode=%d, keyCode=%d, " "hitLeft=%d, hitRight=%d, hitTop=%d, hitBottom=%d\n", i, virtualKey.scanCode, virtualKey.keyCode, @@ -4364,12 +4331,13 @@ void TouchInputMapper::process(const RawEvent* rawEvent) { } void TouchInputMapper::sync(nsecs_t when) { - const RawState* last = mRawStatesPending.isEmpty() ? - &mCurrentRawState : &mRawStatesPending.top(); + const RawState* last = mRawStatesPending.empty() ? + &mCurrentRawState : &mRawStatesPending.back(); // Push a new state. - mRawStatesPending.push(); - RawState* next = &mRawStatesPending.editTop(); + mRawStatesPending.emplace_back(); + + RawState* next = &mRawStatesPending.back(); next->clear(); next->when = when; @@ -4436,7 +4404,7 @@ void TouchInputMapper::processRawTouches(bool timeout) { cookAndDispatch(mCurrentRawState.when); } if (count != 0) { - mRawStatesPending.removeItemsAt(0, count); + mRawStatesPending.erase(mRawStatesPending.begin(), mRawStatesPending.begin() + count); } if (mExternalStylusDataPending) { @@ -6623,12 +6591,9 @@ bool TouchInputMapper::isPointInsideSurface(int32_t x, int32_t y) { && scaledY >= mPhysicalTop && scaledY <= mPhysicalTop + mPhysicalHeight; } -const TouchInputMapper::VirtualKey* TouchInputMapper::findVirtualKeyHit( - int32_t x, int32_t y) { - size_t numVirtualKeys = mVirtualKeys.size(); - for (size_t i = 0; i < numVirtualKeys; i++) { - const VirtualKey& virtualKey = mVirtualKeys[i]; +const TouchInputMapper::VirtualKey* TouchInputMapper::findVirtualKeyHit(int32_t x, int32_t y) { + for (const VirtualKey& virtualKey: mVirtualKeys) { #if DEBUG_VIRTUAL_KEYS ALOGD("VirtualKeys: Hit test (%d, %d): keyCode=%d, scanCode=%d, " "left=%d, top=%d, right=%d, bottom=%d", @@ -6838,9 +6803,7 @@ int32_t TouchInputMapper::getKeyCodeState(uint32_t sourceMask, int32_t keyCode) return AKEY_STATE_VIRTUAL; } - size_t numVirtualKeys = mVirtualKeys.size(); - for (size_t i = 0; i < numVirtualKeys; i++) { - const VirtualKey& virtualKey = mVirtualKeys[i]; + for (const VirtualKey& virtualKey : mVirtualKeys) { if (virtualKey.keyCode == keyCode) { return AKEY_STATE_UP; } @@ -6854,9 +6817,7 @@ int32_t TouchInputMapper::getScanCodeState(uint32_t sourceMask, int32_t scanCode return AKEY_STATE_VIRTUAL; } - size_t numVirtualKeys = mVirtualKeys.size(); - for (size_t i = 0; i < numVirtualKeys; i++) { - const VirtualKey& virtualKey = mVirtualKeys[i]; + for (const VirtualKey& virtualKey : mVirtualKeys) { if (virtualKey.scanCode == scanCode) { return AKEY_STATE_UP; } @@ -6867,10 +6828,7 @@ int32_t TouchInputMapper::getScanCodeState(uint32_t sourceMask, int32_t scanCode bool TouchInputMapper::markSupportedKeyCodes(uint32_t sourceMask, size_t numCodes, const int32_t* keyCodes, uint8_t* outFlags) { - size_t numVirtualKeys = mVirtualKeys.size(); - for (size_t i = 0; i < numVirtualKeys; i++) { - const VirtualKey& virtualKey = mVirtualKeys[i]; - + for (const VirtualKey& virtualKey : mVirtualKeys) { for (size_t i = 0; i < numCodes; i++) { if (virtualKey.keyCode == keyCodes[i]) { outFlags[i] = 1; diff --git a/services/inputflinger/InputReader.h b/services/inputflinger/InputReader.h index fed55ac0e6..9777779e7d 100644 --- a/services/inputflinger/InputReader.h +++ b/services/inputflinger/InputReader.h @@ -90,7 +90,7 @@ public: virtual void requestTimeoutAtTime(nsecs_t when) = 0; virtual int32_t bumpGeneration() = 0; - virtual void getExternalStylusDevices(Vector<InputDeviceInfo>& outDevices) = 0; + virtual void getExternalStylusDevices(std::vector<InputDeviceInfo>& outDevices) = 0; virtual void dispatchExternalStylusState(const StylusState& outState) = 0; virtual InputReaderPolicyInterface* getPolicy() = 0; @@ -124,7 +124,7 @@ public: virtual void loopOnce(); - virtual void getInputDevices(Vector<InputDeviceInfo>& outInputDevices); + virtual void getInputDevices(std::vector<InputDeviceInfo>& outInputDevices); virtual bool isInputDeviceEnabled(int32_t deviceId); @@ -166,7 +166,7 @@ protected: virtual void fadePointer(); virtual void requestTimeoutAtTime(nsecs_t when); virtual int32_t bumpGeneration(); - virtual void getExternalStylusDevices(Vector<InputDeviceInfo>& outDevices); + virtual void getExternalStylusDevices(std::vector<InputDeviceInfo>& outDevices); virtual void dispatchExternalStylusState(const StylusState& outState); virtual InputReaderPolicyInterface* getPolicy(); virtual InputListenerInterface* getListener(); @@ -211,7 +211,7 @@ private: int32_t getGlobalMetaStateLocked(); void notifyExternalStylusPresenceChanged(); - void getExternalStylusDevicesLocked(Vector<InputDeviceInfo>& outDevices); + void getExternalStylusDevicesLocked(std::vector<InputDeviceInfo>& outDevices); void dispatchExternalStylusState(const StylusState& state); void fadePointerLocked(); @@ -219,7 +219,7 @@ private: int32_t mGeneration; int32_t bumpGenerationLocked(); - void getInputDevicesLocked(Vector<InputDeviceInfo>& outInputDevices); + void getInputDevicesLocked(std::vector<InputDeviceInfo>& outInputDevices); nsecs_t mDisableVirtualKeysTimeout; void disableVirtualKeysUntilLocked(nsecs_t time); @@ -266,7 +266,7 @@ public: inline void setMic(bool hasMic) { mHasMic = hasMic; } inline bool hasMic() const { return mHasMic; } - inline bool isIgnored() { return mMappers.isEmpty(); } + inline bool isIgnored() { return mMappers.empty(); } bool isEnabled(); void setEnabled(bool enabled, nsecs_t when); @@ -331,7 +331,7 @@ private: std::string mAlias; uint32_t mClasses; - Vector<InputMapper*> mMappers; + std::vector<InputMapper*> mMappers; uint32_t mSources; bool mIsExternal; @@ -877,7 +877,7 @@ private: uint32_t mSource; int32_t mKeyboardType; - Vector<KeyDown> mKeyDowns; // keys that are down + std::vector<KeyDown> mKeyDowns; // keys that are down int32_t mMetaState; nsecs_t mDownTime; // time of most recent key down @@ -1235,7 +1235,7 @@ protected: } }; - Vector<RawState> mRawStatesPending; + std::vector<RawState> mRawStatesPending; RawState mCurrentRawState; CookedState mCurrentCookedState; RawState mLastRawState; @@ -1262,7 +1262,7 @@ protected: // The pointer controller, or null if the device is not a pointer. sp<PointerControllerInterface> mPointerController; - Vector<VirtualKey> mVirtualKeys; + std::vector<VirtualKey> mVirtualKeys; virtual void configureParameters(); virtual void dumpParameters(std::string& dump); diff --git a/services/inputflinger/host/InputFlinger.h b/services/inputflinger/host/InputFlinger.h index a00b5fbc13..d8b352cbc6 100644 --- a/services/inputflinger/host/InputFlinger.h +++ b/services/inputflinger/host/InputFlinger.h @@ -40,7 +40,8 @@ public: InputFlinger() ANDROID_API; virtual status_t dump(int fd, const Vector<String16>& args); - void setInputWindows(const Vector<InputWindowInfo>&, const sp<ISetInputWindowsListener>&) {} + void setInputWindows(const std::vector<InputWindowInfo>&, + const sp<ISetInputWindowsListener>&) {} void transferTouchFocus(const sp<IBinder>&, const sp<IBinder>&) {} void registerInputChannel(const sp<InputChannel>&) {} void unregisterInputChannel(const sp<InputChannel>&) {} diff --git a/services/inputflinger/include/InputListener.h b/services/inputflinger/include/InputListener.h index cd8caf7530..b51dcb6cad 100644 --- a/services/inputflinger/include/InputListener.h +++ b/services/inputflinger/include/InputListener.h @@ -221,7 +221,7 @@ public: private: sp<InputListenerInterface> mInnerListener; - Vector<NotifyArgs*> mArgsQueue; + std::vector<NotifyArgs*> mArgsQueue; }; } // namespace android diff --git a/services/inputflinger/include/InputReaderBase.h b/services/inputflinger/include/InputReaderBase.h index fe1d4d0bf7..8ad5dd0785 100644 --- a/services/inputflinger/include/InputReaderBase.h +++ b/services/inputflinger/include/InputReaderBase.h @@ -74,7 +74,7 @@ public: * * This method may be called on any thread (usually by the input manager). */ - virtual void getInputDevices(Vector<InputDeviceInfo>& outInputDevices) = 0; + virtual void getInputDevices(std::vector<InputDeviceInfo>& outInputDevices) = 0; /* Query current input state. */ virtual int32_t getScanCodeState(int32_t deviceId, uint32_t sourceMask, @@ -333,7 +333,7 @@ public: /* Notifies the input reader policy that some input devices have changed * and provides information about all current input devices. */ - virtual void notifyInputDevicesChanged(const Vector<InputDeviceInfo>& inputDevices) = 0; + virtual void notifyInputDevicesChanged(const std::vector<InputDeviceInfo>& inputDevices) = 0; /* Gets the keyboard layout for a particular input device. */ virtual sp<KeyCharacterMap> getKeyboardLayoutOverlay( diff --git a/services/inputflinger/tests/InputDispatcher_test.cpp b/services/inputflinger/tests/InputDispatcher_test.cpp index 3b6fe52a5a..d63ff8c2d6 100644 --- a/services/inputflinger/tests/InputDispatcher_test.cpp +++ b/services/inputflinger/tests/InputDispatcher_test.cpp @@ -571,8 +571,8 @@ TEST_F(InputDispatcherTest, SetInputWindow_SingleWindowTouch) { sp<FakeWindowHandle> window = new FakeWindowHandle(application, mDispatcher, "Fake Window", ADISPLAY_ID_DEFAULT); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.add(window); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(window); mDispatcher->setInputWindows(inputWindowHandles, ADISPLAY_ID_DEFAULT); ASSERT_EQ(INPUT_EVENT_INJECTION_SUCCEEDED, injectMotionDown(mDispatcher, @@ -591,9 +591,9 @@ TEST_F(InputDispatcherTest, SetInputWindow_MultiWindowsTouch) { sp<FakeWindowHandle> windowSecond = new FakeWindowHandle(application, mDispatcher, "Second", ADISPLAY_ID_DEFAULT); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.add(windowTop); - inputWindowHandles.add(windowSecond); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(windowTop); + inputWindowHandles.push_back(windowSecond); mDispatcher->setInputWindows(inputWindowHandles, ADISPLAY_ID_DEFAULT); ASSERT_EQ(INPUT_EVENT_INJECTION_SUCCEEDED, injectMotionDown(mDispatcher, @@ -617,9 +617,9 @@ TEST_F(InputDispatcherTest, SetInputWindow_FocusedWindow) { // Expect one focus window exist in display. windowSecond->setFocus(); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.add(windowTop); - inputWindowHandles.add(windowSecond); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(windowTop); + inputWindowHandles.push_back(windowSecond); mDispatcher->setInputWindows(inputWindowHandles, ADISPLAY_ID_DEFAULT); ASSERT_EQ(INPUT_EVENT_INJECTION_SUCCEEDED, injectKeyDown(mDispatcher)) @@ -643,9 +643,9 @@ TEST_F(InputDispatcherTest, SetInputWindow_FocusPriority) { // Display has two focused windows. Add them to inputWindowsHandles in z-order (top most first) windowTop->setFocus(); windowSecond->setFocus(); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.add(windowTop); - inputWindowHandles.add(windowSecond); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(windowTop); + inputWindowHandles.push_back(windowSecond); mDispatcher->setInputWindows(inputWindowHandles, ADISPLAY_ID_DEFAULT); ASSERT_EQ(INPUT_EVENT_INJECTION_SUCCEEDED, injectKeyDown(mDispatcher)) @@ -669,9 +669,9 @@ TEST_F(InputDispatcherTest, SetInputWindow_InputWindowInfo) { windowTop->setFocus(); windowSecond->setFocus(); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.add(windowTop); - inputWindowHandles.add(windowSecond); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(windowTop); + inputWindowHandles.push_back(windowSecond); // Release channel for window is no longer valid. windowTop->releaseChannel(); mDispatcher->setInputWindows(inputWindowHandles, ADISPLAY_ID_DEFAULT); @@ -695,8 +695,8 @@ public: application1 = new FakeApplicationHandle(); windowInPrimary = new FakeWindowHandle(application1, mDispatcher, "D_1", ADISPLAY_ID_DEFAULT); - Vector<sp<InputWindowHandle>> inputWindowHandles; - inputWindowHandles.push(windowInPrimary); + std::vector<sp<InputWindowHandle>> inputWindowHandles; + inputWindowHandles.push_back(windowInPrimary); // Set focus window for primary display, but focused display would be second one. mDispatcher->setFocusedApplication(ADISPLAY_ID_DEFAULT, application1); windowInPrimary->setFocus(); @@ -706,8 +706,8 @@ public: windowInSecondary = new FakeWindowHandle(application2, mDispatcher, "D_2", SECOND_DISPLAY_ID); // Set focus to second display window. - Vector<sp<InputWindowHandle>> inputWindowHandles_Second; - inputWindowHandles_Second.push(windowInSecondary); + std::vector<sp<InputWindowHandle>> inputWindowHandles_Second; + inputWindowHandles_Second.push_back(windowInSecondary); // Set focus display to second one. mDispatcher->setFocusedDisplay(SECOND_DISPLAY_ID); // Set focus window for second display. @@ -762,7 +762,7 @@ TEST_F(InputDispatcherFocusOnTwoDisplaysTest, SetInputWindow_MultiDisplayFocus) windowInSecondary->consumeEvent(AINPUT_EVENT_TYPE_KEY, ADISPLAY_ID_NONE); // Remove secondary display. - Vector<sp<InputWindowHandle>> noWindows; + std::vector<sp<InputWindowHandle>> noWindows; mDispatcher->setInputWindows(noWindows, SECOND_DISPLAY_ID); // Expect old focus should receive a cancel event. diff --git a/services/inputflinger/tests/InputReader_test.cpp b/services/inputflinger/tests/InputReader_test.cpp index 80a55f1a65..d35302885d 100644 --- a/services/inputflinger/tests/InputReader_test.cpp +++ b/services/inputflinger/tests/InputReader_test.cpp @@ -158,7 +158,7 @@ private: class FakeInputReaderPolicy : public InputReaderPolicyInterface { InputReaderConfiguration mConfig; KeyedVector<int32_t, sp<FakePointerController> > mPointerControllers; - Vector<InputDeviceInfo> mInputDevices; + std::vector<InputDeviceInfo> mInputDevices; std::vector<DisplayViewport> mViewports; TouchAffineTransformation transform; @@ -226,7 +226,7 @@ public: return &mConfig; } - const Vector<InputDeviceInfo>& getInputDevices() const { + const std::vector<InputDeviceInfo>& getInputDevices() const { return mInputDevices; } @@ -280,7 +280,7 @@ private: return mPointerControllers.valueFor(deviceId); } - virtual void notifyInputDevicesChanged(const Vector<InputDeviceInfo>& inputDevices) { + virtual void notifyInputDevicesChanged(const std::vector<InputDeviceInfo>& inputDevices) { mInputDevices = inputDevices; } @@ -314,7 +314,7 @@ class FakeEventHub : public EventHubInterface { KeyedVector<int32_t, KeyInfo> keysByScanCode; KeyedVector<int32_t, KeyInfo> keysByUsageCode; KeyedVector<int32_t, bool> leds; - Vector<VirtualKeyDefinition> virtualKeys; + std::vector<VirtualKeyDefinition> virtualKeys; bool enabled; status_t enable() { @@ -482,7 +482,7 @@ public: void addVirtualKeyDefinition(int32_t deviceId, const VirtualKeyDefinition& definition) { Device* device = getDevice(deviceId); - device->virtualKeys.push(definition); + device->virtualKeys.push_back(definition); } void enqueueEvent(nsecs_t when, int32_t deviceId, int32_t type, @@ -728,12 +728,12 @@ private: } virtual void getVirtualKeyDefinitions(int32_t deviceId, - Vector<VirtualKeyDefinition>& outVirtualKeys) const { + std::vector<VirtualKeyDefinition>& outVirtualKeys) const { outVirtualKeys.clear(); Device* device = getDevice(deviceId); if (device) { - outVirtualKeys.appendVector(device->virtualKeys); + outVirtualKeys = device->virtualKeys; } } @@ -842,7 +842,7 @@ private: return ++mGeneration; } - virtual void getExternalStylusDevices(Vector<InputDeviceInfo>& outDevices) { + virtual void getExternalStylusDevices(std::vector<InputDeviceInfo>& outDevices) { } @@ -865,7 +865,7 @@ class FakeInputMapper : public InputMapper { KeyedVector<int32_t, int32_t> mKeyCodeStates; KeyedVector<int32_t, int32_t> mScanCodeStates; KeyedVector<int32_t, int32_t> mSwitchStates; - Vector<int32_t> mSupportedKeyCodes; + std::vector<int32_t> mSupportedKeyCodes; RawEvent mLastEvent; bool mConfigureWasCalled; @@ -925,7 +925,7 @@ public: } void addSupportedKeyCode(int32_t keyCode) { - mSupportedKeyCodes.add(keyCode); + mSupportedKeyCodes.push_back(keyCode); } private: @@ -1309,7 +1309,7 @@ TEST_F(InputReaderTest, GetInputDevices) { 0, nullptr)); // no classes so device will be ignored - Vector<InputDeviceInfo> inputDevices; + std::vector<InputDeviceInfo> inputDevices; mReader->getInputDevices(inputDevices); ASSERT_EQ(1U, inputDevices.size()); @@ -4436,7 +4436,7 @@ TEST_F(SingleTouchInputMapperTest, Process_ShouldHandleAllToolTypes) { ASSERT_EQ(AMOTION_EVENT_ACTION_MOVE, motionArgs.action); ASSERT_EQ(AMOTION_EVENT_TOOL_TYPE_STYLUS, motionArgs.pointerProperties[0].toolType); - // airbrush + // air-brush processKey(mapper, BTN_TOOL_PENCIL, 0); processKey(mapper, BTN_TOOL_AIRBRUSH, 1); processSync(mapper); @@ -5943,7 +5943,7 @@ TEST_F(MultiTouchInputMapperTest, Process_ShouldHandleAllToolTypes) { ASSERT_EQ(AMOTION_EVENT_ACTION_MOVE, motionArgs.action); ASSERT_EQ(AMOTION_EVENT_TOOL_TYPE_STYLUS, motionArgs.pointerProperties[0].toolType); - // airbrush + // air-brush processKey(mapper, BTN_TOOL_PENCIL, 0); processKey(mapper, BTN_TOOL_AIRBRUSH, 1); processSync(mapper); diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 4c4a29b544..77c8d109f9 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -2906,13 +2906,13 @@ void SurfaceFlinger::updateInputFlinger() { } void SurfaceFlinger::updateInputWindowInfo() { - Vector<InputWindowInfo> inputHandles; + std::vector<InputWindowInfo> inputHandles; mDrawingState.traverseInReverseZOrder([&](Layer* layer) { if (layer->hasInput()) { // When calculating the screen bounds we ignore the transparent region since it may // result in an unwanted offset. - inputHandles.add(layer->fillInputInfo()); + inputHandles.push_back(layer->fillInputInfo()); } }); |