diff options
author | 2024-09-18 01:18:48 +0000 | |
---|---|---|
committer | 2024-09-18 01:18:48 +0000 | |
commit | 68e2ee2272917fca0c01f85968979748c8a80294 (patch) | |
tree | 9f49c45d8a803bb04accfc5e62b3b0424d1fed8f | |
parent | 2347908d77bd52cc0031dce4c7ffc29411f34aa3 (diff) |
binderRpcTest: remove parallelization test
This test is much flakier these days, and we test
calls can run in parallel elsewher.
Change-Id: If3ea0aeff03acc59a396964a706099ae080eadaf
Fixes: 365294257
Test: TH
-rw-r--r-- | libs/binder/tests/binderRpcTest.cpp | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/libs/binder/tests/binderRpcTest.cpp b/libs/binder/tests/binderRpcTest.cpp index a1e53c5ebc..0ef200bcbe 100644 --- a/libs/binder/tests/binderRpcTest.cpp +++ b/libs/binder/tests/binderRpcTest.cpp @@ -499,11 +499,11 @@ static void testThreadPoolOverSaturated(sp<IBinderRpcTest> iface, size_t numCall EXPECT_GE(epochMsAfter, epochMsBefore + 2 * sleepMs); - // Potential flake, but make sure calls are handled in parallel. Due - // to past flakes, this only checks that the amount of time taken has - // some parallelism. Other tests such as ThreadPoolGreaterThanEqualRequested - // check this more exactly. - EXPECT_LE(epochMsAfter, epochMsBefore + (numCalls - 1) * sleepMs); + // b/272429574, b/365294257 + // This flakes too much to test. Parallelization is tested + // in ThreadPoolGreaterThanEqualRequested and other tests. + // Test to make sure calls are handled in parallel. + // EXPECT_LE(epochMsAfter, epochMsBefore + (numCalls - 1) * sleepMs); } TEST_P(BinderRpc, ThreadPoolOverSaturated) { @@ -515,8 +515,7 @@ TEST_P(BinderRpc, ThreadPoolOverSaturated) { constexpr size_t kNumCalls = kNumThreads + 3; auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads}); - // b/272429574 - below 500ms, the test fails - testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/); + testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 200 /*ms*/); } TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { @@ -530,8 +529,7 @@ TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { auto proc = createRpcTestSocketServerProcess( {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections}); - // b/272429574 - below 500ms, the test fails - testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/); + testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 200 /*ms*/); } TEST_P(BinderRpc, ThreadingStressTest) { |