summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chih-Hung Hsieh <chh@google.com> 2017-10-05 15:20:11 -0700
committer Chih-Hung Hsieh <chh@google.com> 2017-10-05 15:20:43 -0700
commit687a0d19345bb5fc669e594397370c76172362e1 (patch)
treef21fb667797c5ff4394de82972cddb3ea07a072f
parent0c47ec9a824963f42640927b8d0a237bf8ce2ea7 (diff)
Use -Werror in frameworks/native/libs
* Suppress unused-variable and user-defined warnings. * Keep sign-compare warnings to fix later. Bug: 66996870 Test: build with WITH_TIDY=1 Change-Id: I6eee1532aa22c92ed19515ad5574734d1016d967
-rw-r--r--libs/diskusage/Android.bp1
-rw-r--r--libs/graphicsenv/Android.bp2
-rw-r--r--libs/hwc2on1adapter/Android.bp6
-rw-r--r--libs/input/tests/Android.bp8
-rw-r--r--libs/math/tests/Android.bp4
5 files changed, 20 insertions, 1 deletions
diff --git a/libs/diskusage/Android.bp b/libs/diskusage/Android.bp
index 156ddff2c6..a8263069de 100644
--- a/libs/diskusage/Android.bp
+++ b/libs/diskusage/Android.bp
@@ -15,4 +15,5 @@
cc_library_static {
name: "libdiskusage",
srcs: ["dirsize.c"],
+ cflags: ["-Wall", "-Werror"],
}
diff --git a/libs/graphicsenv/Android.bp b/libs/graphicsenv/Android.bp
index f2686d5748..9f995380bd 100644
--- a/libs/graphicsenv/Android.bp
+++ b/libs/graphicsenv/Android.bp
@@ -19,6 +19,8 @@ cc_library_shared {
"GraphicsEnv.cpp",
],
+ cflags: ["-Wall", "-Werror"],
+
shared_libs: [
"libnativeloader",
"liblog",
diff --git a/libs/hwc2on1adapter/Android.bp b/libs/hwc2on1adapter/Android.bp
index ec9cbf8429..420a1f6066 100644
--- a/libs/hwc2on1adapter/Android.bp
+++ b/libs/hwc2on1adapter/Android.bp
@@ -17,9 +17,13 @@ cc_library_shared {
vendor: true,
clang: true,
+ cflags: [
+ "-Wall",
+ "-Werror",
+ "-Wno-user-defined-warnings",
+ ],
cppflags: [
"-Weverything",
- "-Wall",
"-Wunused",
"-Wunreachable-code",
diff --git a/libs/input/tests/Android.bp b/libs/input/tests/Android.bp
index 029a42091e..0028655075 100644
--- a/libs/input/tests/Android.bp
+++ b/libs/input/tests/Android.bp
@@ -7,6 +7,12 @@ cc_test {
"InputEvent_test.cpp",
"InputPublisherAndConsumer_test.cpp",
],
+ cflags: [
+ "-Wall",
+ "-Werror",
+ "-Wno-error=sign-compare", // to fix later
+ "-Wno-unused-variable",
+ ],
shared_libs: [
"libinput",
"libcutils",
@@ -24,5 +30,7 @@ cc_library_static {
srcs: ["StructLayout_test.cpp"],
cflags: [
"-O0",
+ "-Wall",
+ "-Werror",
],
}
diff --git a/libs/math/tests/Android.bp b/libs/math/tests/Android.bp
index 0ed24a2a1e..0184f56dc4 100644
--- a/libs/math/tests/Android.bp
+++ b/libs/math/tests/Android.bp
@@ -18,22 +18,26 @@ cc_test {
name: "vec_test",
srcs: ["vec_test.cpp"],
static_libs: ["libmath"],
+ cflags: ["-Wall", "-Werror"],
}
cc_test {
name: "mat_test",
srcs: ["mat_test.cpp"],
static_libs: ["libmath"],
+ cflags: ["-Wall", "-Werror"],
}
cc_test {
name: "half_test",
srcs: ["half_test.cpp"],
static_libs: ["libmath"],
+ cflags: ["-Wall", "-Werror"],
}
cc_test {
name: "quat_test",
srcs: ["quat_test.cpp"],
static_libs: ["libmath"],
+ cflags: ["-Wall", "-Werror"],
}