diff options
author | 2023-10-02 20:34:18 +0000 | |
---|---|---|
committer | 2023-10-20 18:54:53 +0000 | |
commit | 55e3103c33bdb6da73d45be50bff0161e5a5822f (patch) | |
tree | 3b5cfc544a606eaf4fa2ee2abc50d5016cf1ed8e | |
parent | 535e95b90706c08bf7fbcd2a2aa3fbce90250d2d (diff) |
Rename DisplayMode::refreshRate to peakRefreshRate
Peak refresh rate is a more clear name
Bug: 301462354
Test: builds, boots
Test: dumpsys display
Change-Id: I2f7f98859ae2a1d9191b1e377921eb7a04e784bf
-rw-r--r-- | libs/gui/SurfaceComposerClient.cpp | 2 | ||||
-rw-r--r-- | libs/gui/aidl/android/gui/DisplayMode.aidl | 2 | ||||
-rw-r--r-- | libs/gui/tests/EndToEndNativeInputTest.cpp | 2 | ||||
-rw-r--r-- | libs/nativedisplay/ADisplay.cpp | 2 | ||||
-rw-r--r-- | libs/ui/include/ui/DisplayMode.h | 2 | ||||
-rw-r--r-- | services/surfaceflinger/SurfaceFlinger.cpp | 10 | ||||
-rw-r--r-- | services/surfaceflinger/tests/DisplayConfigs_test.cpp | 4 | ||||
-rw-r--r-- | services/surfaceflinger/tests/LayerTransactionTest.h | 2 |
8 files changed, 13 insertions, 13 deletions
diff --git a/libs/gui/SurfaceComposerClient.cpp b/libs/gui/SurfaceComposerClient.cpp index 05e2ddf198..a3518110cd 100644 --- a/libs/gui/SurfaceComposerClient.cpp +++ b/libs/gui/SurfaceComposerClient.cpp @@ -2604,7 +2604,7 @@ void SurfaceComposerClient::getDynamicDisplayInfoInternal(gui::DynamicDisplayInf outMode.resolution.height = mode.resolution.height; outMode.xDpi = mode.xDpi; outMode.yDpi = mode.yDpi; - outMode.refreshRate = mode.refreshRate; + outMode.peakRefreshRate = mode.peakRefreshRate; outMode.vsyncRate = mode.vsyncRate; outMode.appVsyncOffset = mode.appVsyncOffset; outMode.sfVsyncOffset = mode.sfVsyncOffset; diff --git a/libs/gui/aidl/android/gui/DisplayMode.aidl b/libs/gui/aidl/android/gui/DisplayMode.aidl index b057653200..f605177cfd 100644 --- a/libs/gui/aidl/android/gui/DisplayMode.aidl +++ b/libs/gui/aidl/android/gui/DisplayMode.aidl @@ -30,7 +30,7 @@ parcelable DisplayMode { int[] supportedHdrTypes; // Some modes have peak refresh rate lower than the panel vsync rate. - float refreshRate = 0.0f; + float peakRefreshRate = 0.0f; float vsyncRate = 0.0f; long appVsyncOffset = 0; long sfVsyncOffset = 0; diff --git a/libs/gui/tests/EndToEndNativeInputTest.cpp b/libs/gui/tests/EndToEndNativeInputTest.cpp index 662e9fe74a..d4b8dbeeb9 100644 --- a/libs/gui/tests/EndToEndNativeInputTest.cpp +++ b/libs/gui/tests/EndToEndNativeInputTest.cpp @@ -394,7 +394,7 @@ public: // After a new buffer is queued, SurfaceFlinger is notified and will // latch the new buffer on next vsync. Let's heuristically wait for 3 // vsyncs. - mBufferPostDelay = static_cast<int32_t>(1e6 / mode.refreshRate) * 3; + mBufferPostDelay = static_cast<int32_t>(1e6 / mode.peakRefreshRate) * 3; } void TearDown() { diff --git a/libs/nativedisplay/ADisplay.cpp b/libs/nativedisplay/ADisplay.cpp index bf0805b46c..e3be3bc8f8 100644 --- a/libs/nativedisplay/ADisplay.cpp +++ b/libs/nativedisplay/ADisplay.cpp @@ -155,7 +155,7 @@ int ADisplay_acquirePhysicalDisplays(ADisplay*** outDisplays) { const ui::DisplayMode& mode = modes[j]; modesPerDisplay[i].emplace_back( DisplayConfigImpl{static_cast<size_t>(mode.id), mode.resolution.getWidth(), - mode.resolution.getHeight(), mode.refreshRate, + mode.resolution.getHeight(), mode.peakRefreshRate, mode.sfVsyncOffset, mode.appVsyncOffset}); } } diff --git a/libs/ui/include/ui/DisplayMode.h b/libs/ui/include/ui/DisplayMode.h index a469c78070..ddb9bbd4bc 100644 --- a/libs/ui/include/ui/DisplayMode.h +++ b/libs/ui/include/ui/DisplayMode.h @@ -38,7 +38,7 @@ struct DisplayMode { std::vector<ui::Hdr> supportedHdrTypes; // Some modes have peak refresh rate lower than the panel vsync rate. - float refreshRate = 0.f; + float peakRefreshRate = 0.f; float vsyncRate = 0.f; nsecs_t appVsyncOffset = 0; nsecs_t sfVsyncOffset = 0; diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 9b9a67aa5f..fc517212ea 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -266,7 +266,7 @@ bool getKernelIdleTimerSyspropConfig(DisplayId displayId) { bool isAbove4k30(const ui::DisplayMode& outMode) { using fps_approx_ops::operator>; - Fps refreshRate = Fps::fromValue(outMode.refreshRate); + Fps refreshRate = Fps::fromValue(outMode.peakRefreshRate); return outMode.resolution.getWidth() >= FOUR_K_WIDTH && outMode.resolution.getHeight() >= FOUR_K_HEIGHT && refreshRate > 30_Hz; } @@ -1046,11 +1046,11 @@ void SurfaceFlinger::getDynamicDisplayInfoInternal(ui::DynamicDisplayInfo*& info outMode.yDpi = yDpi; const auto peakFps = mode->getPeakFps(); - outMode.refreshRate = peakFps.getValue(); + outMode.peakRefreshRate = peakFps.getValue(); outMode.vsyncRate = mode->getVsyncRate().getValue(); - const auto vsyncConfigSet = - mVsyncConfiguration->getConfigsForRefreshRate(Fps::fromValue(outMode.refreshRate)); + const auto vsyncConfigSet = mVsyncConfiguration->getConfigsForRefreshRate( + Fps::fromValue(outMode.peakRefreshRate)); outMode.appVsyncOffset = vsyncConfigSet.late.appOffset; outMode.sfVsyncOffset = vsyncConfigSet.late.sfOffset; outMode.group = mode->getGroup(); @@ -9221,7 +9221,7 @@ void SurfaceComposerAIDL::getDynamicDisplayInfoInternal(ui::DynamicDisplayInfo& outMode.resolution.height = mode.resolution.height; outMode.xDpi = mode.xDpi; outMode.yDpi = mode.yDpi; - outMode.refreshRate = mode.refreshRate; + outMode.peakRefreshRate = mode.peakRefreshRate; outMode.vsyncRate = mode.vsyncRate; outMode.appVsyncOffset = mode.appVsyncOffset; outMode.sfVsyncOffset = mode.sfVsyncOffset; diff --git a/services/surfaceflinger/tests/DisplayConfigs_test.cpp b/services/surfaceflinger/tests/DisplayConfigs_test.cpp index 4be961bda1..0a951d49e3 100644 --- a/services/surfaceflinger/tests/DisplayConfigs_test.cpp +++ b/services/surfaceflinger/tests/DisplayConfigs_test.cpp @@ -75,8 +75,8 @@ TEST_F(RefreshRateRangeTest, setAllConfigs) { setSpecs.allowGroupSwitching = false; for (size_t i = 0; i < modes.size(); i++) { setSpecs.defaultMode = modes[i].id; - setSpecs.primaryRanges.physical.min = modes[i].refreshRate; - setSpecs.primaryRanges.physical.max = modes[i].refreshRate; + setSpecs.primaryRanges.physical.min = modes[i].peakRefreshRate; + setSpecs.primaryRanges.physical.max = modes[i].peakRefreshRate; setSpecs.primaryRanges.render = setSpecs.primaryRanges.physical; setSpecs.appRequestRanges = setSpecs.primaryRanges; res = SurfaceComposerClient::setDesiredDisplayModeSpecs(mDisplayToken, setSpecs); diff --git a/services/surfaceflinger/tests/LayerTransactionTest.h b/services/surfaceflinger/tests/LayerTransactionTest.h index 2bdb8a452d..9269e7c8a0 100644 --- a/services/surfaceflinger/tests/LayerTransactionTest.h +++ b/services/surfaceflinger/tests/LayerTransactionTest.h @@ -299,7 +299,7 @@ private: // After a new buffer is queued, SurfaceFlinger is notified and will // latch the new buffer on next vsync. Let's heuristically wait for 3 // vsyncs. - mBufferPostDelay = static_cast<int32_t>(1e6 / mode.refreshRate) * 3; + mBufferPostDelay = static_cast<int32_t>(1e6 / mode.peakRefreshRate) * 3; mBlackBgSurface = createSurface(mClient, "BaseSurface", 0 /* buffer width */, 0 /* buffer height */, |