summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Cody Northrop <cnorthrop@google.com> 2022-12-19 15:32:11 -0700
committer Cody Northrop <cnorthrop@google.com> 2022-12-20 14:37:13 -0700
commit2a66e5457bb43316e78f511d9e89013f63b6f200 (patch)
treec37102a2e0d96fa398acb7db84040020ca00519a
parent2fdbd6c634209e28c72c82726bae10b980019d10 (diff)
OpenGL: Update test mapping to include EGL_test
We need to get EGL tests running continuously in order to make modifications to blobcache. Skipping one failing test, will address or remove after we get the test running. Also add hasWideColorDisplay checks to two tests that require Display P3 gamut. Test: adb shell /data/nativetest64/EGL_test/EGL_test Bug: b/120714942 Bug: b/246966894 Change-Id: I985f871900ab72553bcf0e73987b843800fcac89
-rw-r--r--opengl/TEST_MAPPING3
-rw-r--r--opengl/tests/EGLTest/Android.bp2
-rw-r--r--opengl/tests/EGLTest/EGL_test.cpp17
3 files changed, 21 insertions, 1 deletions
diff --git a/opengl/TEST_MAPPING b/opengl/TEST_MAPPING
index d391dce2de..7c50a945fa 100644
--- a/opengl/TEST_MAPPING
+++ b/opengl/TEST_MAPPING
@@ -2,6 +2,9 @@
"presubmit": [
{
"name": "CtsGpuToolsHostTestCases"
+ },
+ {
+ "name": "EGL_test"
}
]
}
diff --git a/opengl/tests/EGLTest/Android.bp b/opengl/tests/EGLTest/Android.bp
index 51c937614f..d96a89564d 100644
--- a/opengl/tests/EGLTest/Android.bp
+++ b/opengl/tests/EGLTest/Android.bp
@@ -1,4 +1,3 @@
-
package {
// See: http://go/android-license-faq
// A large-scale-change added 'default_applicable_licenses' to import
@@ -11,6 +10,7 @@ package {
cc_test {
name: "EGL_test",
+ test_suites: ["general-tests"],
srcs: [
"egl_cache_test.cpp",
diff --git a/opengl/tests/EGLTest/EGL_test.cpp b/opengl/tests/EGLTest/EGL_test.cpp
index bbd786d155..cbe4ef9c40 100644
--- a/opengl/tests/EGLTest/EGL_test.cpp
+++ b/opengl/tests/EGLTest/EGL_test.cpp
@@ -343,6 +343,11 @@ TEST_F(EGLTest, EGLDisplayP3Passthrough) {
}
TEST_F(EGLTest, EGLDisplayP31010102) {
+ // This test has been failing since:
+ // libEGL: When driver doesn't understand P3, map sRGB-encoded P3 to sRGB
+ // https://android-review.git.corp.google.com/c/platform/frameworks/native/+/793504
+ GTEST_SKIP() << "Skipping broken test. See b/120714942 and b/117104367";
+
EGLint numConfigs;
EGLConfig config;
EGLBoolean success;
@@ -866,6 +871,12 @@ TEST_F(EGLTest, EGLUnsupportedColorspaceFormatCombo) {
EGLConfig config;
EGLBoolean success;
+ if (!hasWideColorDisplay) {
+ // skip this test if device does not have wide-color display
+ RecordProperty("hasWideColorDisplay", false);
+ return;
+ }
+
const EGLint attrs[] = {
// clang-format off
EGL_SURFACE_TYPE, EGL_WINDOW_BIT,
@@ -951,6 +962,12 @@ TEST_F(EGLTest, EGLCreateWindowFailAndSucceed) {
TEST_F(EGLTest, EGLCreateWindowTwoColorspaces) {
EGLConfig config;
+ if (!hasWideColorDisplay) {
+ // skip this test if device does not have wide-color display
+ RecordProperty("hasWideColorDisplay", false);
+ return;
+ }
+
ASSERT_NO_FATAL_FAILURE(get8BitConfig(config));
struct MockConsumer : public BnConsumerListener {