diff options
author | 2023-02-10 20:16:57 +0000 | |
---|---|---|
committer | 2023-02-10 21:43:20 +0000 | |
commit | 02dd059d9460c178eb188c9ca61ceb8c98db6b48 (patch) | |
tree | ed42e89b863c964d6de08ed9e02a2c2306c9a813 | |
parent | 8a878356682afb9801816785ab7ade6f68384108 (diff) |
JPEG/R refactory: rename jpegencoder and jpegdecoder
Rename those to ***helper
Bug: 264715926
Test: build
Change-Id: Ibcfd8554538a711b264f3d4227a9037302437af1
-rw-r--r-- | libs/jpegrecoverymap/Android.bp | 4 | ||||
-rw-r--r-- | libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoderhelper.h (renamed from libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoder.h) | 13 | ||||
-rw-r--r-- | libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoderhelper.h (renamed from libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoder.h) | 12 | ||||
-rw-r--r-- | libs/jpegrecoverymap/jpegdecoderhelper.cpp (renamed from libs/jpegrecoverymap/jpegdecoder.cpp) | 36 | ||||
-rw-r--r-- | libs/jpegrecoverymap/jpegencoderhelper.cpp (renamed from libs/jpegrecoverymap/jpegencoder.cpp) | 36 | ||||
-rw-r--r-- | libs/jpegrecoverymap/recoverymap.cpp | 20 | ||||
-rw-r--r-- | libs/jpegrecoverymap/tests/Android.bp | 8 | ||||
-rw-r--r-- | libs/jpegrecoverymap/tests/jpegdecoderhelper_test.cpp (renamed from libs/jpegrecoverymap/tests/jpegdecoder_test.cpp) | 26 | ||||
-rw-r--r-- | libs/jpegrecoverymap/tests/jpegencoderhelper_test.cpp (renamed from libs/jpegrecoverymap/tests/jpegencoder_test.cpp) | 30 |
9 files changed, 92 insertions, 93 deletions
diff --git a/libs/jpegrecoverymap/Android.bp b/libs/jpegrecoverymap/Android.bp index 2c4b3bff77..ee112e802c 100644 --- a/libs/jpegrecoverymap/Android.bp +++ b/libs/jpegrecoverymap/Android.bp @@ -57,7 +57,7 @@ cc_library { export_include_dirs: ["include"], srcs: [ - "jpegencoder.cpp", + "jpegencoderhelper.cpp", ], } @@ -73,6 +73,6 @@ cc_library { export_include_dirs: ["include"], srcs: [ - "jpegdecoder.cpp", + "jpegdecoderhelper.cpp", ], } diff --git a/libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoder.h b/libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoderhelper.h index 419b63d1de..485869da25 100644 --- a/libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoder.h +++ b/libs/jpegrecoverymap/include/jpegrecoverymap/jpegdecoderhelper.h @@ -1,4 +1,3 @@ - /* * Copyright 2022 The Android Open Source Project * @@ -15,8 +14,8 @@ * limitations under the License. */ -#ifndef ANDROID_JPEGRECOVERYMAP_JPEGDECODER_H -#define ANDROID_JPEGRECOVERYMAP_JPEGDECODER_H +#ifndef ANDROID_JPEGRECOVERYMAP_JPEGDECODERHELPER_H +#define ANDROID_JPEGRECOVERYMAP_JPEGDECODERHELPER_H // We must include cstdio before jpeglib.h. It is a requirement of libjpeg. #include <cstdio> @@ -31,10 +30,10 @@ namespace android::recoverymap { * Encapsulates a converter from JPEG to raw image (YUV420planer or grey-scale) format. * This class is not thread-safe. */ -class JpegDecoder { +class JpegDecoderHelper { public: - JpegDecoder(); - ~JpegDecoder(); + JpegDecoderHelper(); + ~JpegDecoderHelper(); /* * Decompresses JPEG image to raw image (YUV420planer, grey-scale or RGBA) format. After * calling this method, call getDecompressedImage() to get the image. @@ -118,4 +117,4 @@ private: }; } /* namespace android */ -#endif // ANDROID_JPEGRECOVERYMAP_JPEGDECODER_H +#endif // ANDROID_JPEGRECOVERYMAP_JPEGDECODERHELPER_H diff --git a/libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoder.h b/libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoderhelper.h index 61aeb8ace7..f087b55b6f 100644 --- a/libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoder.h +++ b/libs/jpegrecoverymap/include/jpegrecoverymap/jpegencoderhelper.h @@ -14,8 +14,8 @@ * limitations under the License. */ -#ifndef ANDROID_JPEGRECOVERYMAP_JPEGENCODER_H -#define ANDROID_JPEGRECOVERYMAP_JPEGENCODER_H +#ifndef ANDROID_JPEGRECOVERYMAP_JPEGENCODERHELPER_H +#define ANDROID_JPEGRECOVERYMAP_JPEGENCODERHELPER_H // We must include cstdio before jpeglib.h. It is a requirement of libjpeg. #include <cstdio> @@ -34,10 +34,10 @@ namespace android::recoverymap { * Encapsulates a converter from raw image (YUV420planer or grey-scale) to JPEG format. * This class is not thread-safe. */ -class JpegEncoder { +class JpegEncoderHelper { public: - JpegEncoder(); - ~JpegEncoder(); + JpegEncoderHelper(); + ~JpegEncoderHelper(); /* * Compresses YUV420Planer image to JPEG format. After calling this method, call @@ -92,4 +92,4 @@ private: } /* namespace android */ -#endif // ANDROID_JPEGRECOVERYMAP_JPEGENCODER_H +#endif // ANDROID_JPEGRECOVERYMAP_JPEGENCODERHELPER_H diff --git a/libs/jpegrecoverymap/jpegdecoder.cpp b/libs/jpegrecoverymap/jpegdecoderhelper.cpp index 1bf609a54c..0754ec9dd6 100644 --- a/libs/jpegrecoverymap/jpegdecoder.cpp +++ b/libs/jpegrecoverymap/jpegdecoderhelper.cpp @@ -14,7 +14,7 @@ * limitations under the License. */ -#include <jpegrecoverymap/jpegdecoder.h> +#include <jpegrecoverymap/jpegdecoderhelper.h> #include <utils/Log.h> @@ -90,14 +90,14 @@ static void jpegrerror_exit(j_common_ptr cinfo) { longjmp(err->setjmp_buffer, 1); } -JpegDecoder::JpegDecoder() { +JpegDecoderHelper::JpegDecoderHelper() { mExifPos = 0; } -JpegDecoder::~JpegDecoder() { +JpegDecoderHelper::~JpegDecoderHelper() { } -bool JpegDecoder::decompressImage(const void* image, int length, bool decodeToRGBA) { +bool JpegDecoderHelper::decompressImage(const void* image, int length, bool decodeToRGBA) { if (image == nullptr || length <= 0) { ALOGE("Image size can not be handled: %d", length); return false; @@ -112,39 +112,39 @@ bool JpegDecoder::decompressImage(const void* image, int length, bool decodeToRG return true; } -void* JpegDecoder::getDecompressedImagePtr() { +void* JpegDecoderHelper::getDecompressedImagePtr() { return mResultBuffer.data(); } -size_t JpegDecoder::getDecompressedImageSize() { +size_t JpegDecoderHelper::getDecompressedImageSize() { return mResultBuffer.size(); } -void* JpegDecoder::getXMPPtr() { +void* JpegDecoderHelper::getXMPPtr() { return mXMPBuffer.data(); } -size_t JpegDecoder::getXMPSize() { +size_t JpegDecoderHelper::getXMPSize() { return mXMPBuffer.size(); } -void* JpegDecoder::getEXIFPtr() { +void* JpegDecoderHelper::getEXIFPtr() { return mEXIFBuffer.data(); } -size_t JpegDecoder::getEXIFSize() { +size_t JpegDecoderHelper::getEXIFSize() { return mEXIFBuffer.size(); } -size_t JpegDecoder::getDecompressedImageWidth() { +size_t JpegDecoderHelper::getDecompressedImageWidth() { return mWidth; } -size_t JpegDecoder::getDecompressedImageHeight() { +size_t JpegDecoderHelper::getDecompressedImageHeight() { return mHeight; } -bool JpegDecoder::decode(const void* image, int length, bool decodeToRGBA) { +bool JpegDecoderHelper::decode(const void* image, int length, bool decodeToRGBA) { jpeg_decompress_struct cinfo; jpegr_source_mgr mgr(static_cast<const uint8_t*>(image), length); jpegrerror_mgr myerr; @@ -248,7 +248,7 @@ bool JpegDecoder::decode(const void* image, int length, bool decodeToRGBA) { return true; } -bool JpegDecoder::decompress(jpeg_decompress_struct* cinfo, const uint8_t* dest, +bool JpegDecoderHelper::decompress(jpeg_decompress_struct* cinfo, const uint8_t* dest, bool isSingleChannel) { if (isSingleChannel) { return decompressSingleChannel(cinfo, dest); @@ -259,7 +259,7 @@ bool JpegDecoder::decompress(jpeg_decompress_struct* cinfo, const uint8_t* dest, return decompressYUV(cinfo, dest); } -bool JpegDecoder::getCompressedImageParameters(const void* image, int length, +bool JpegDecoderHelper::getCompressedImageParameters(const void* image, int length, size_t *pWidth, size_t *pHeight, std::vector<uint8_t> *iccData , std::vector<uint8_t> *exifData) { jpeg_decompress_struct cinfo; @@ -326,7 +326,7 @@ bool JpegDecoder::getCompressedImageParameters(const void* image, int length, return true; } -bool JpegDecoder::decompressRGBA(jpeg_decompress_struct* cinfo, const uint8_t* dest) { +bool JpegDecoderHelper::decompressRGBA(jpeg_decompress_struct* cinfo, const uint8_t* dest) { JSAMPLE* decodeDst = (JSAMPLE*) dest; uint32_t lines = 0; // TODO: use batches for more effectiveness @@ -341,7 +341,7 @@ bool JpegDecoder::decompressRGBA(jpeg_decompress_struct* cinfo, const uint8_t* d return lines == cinfo->image_height; } -bool JpegDecoder::decompressYUV(jpeg_decompress_struct* cinfo, const uint8_t* dest) { +bool JpegDecoderHelper::decompressYUV(jpeg_decompress_struct* cinfo, const uint8_t* dest) { JSAMPROW y[kCompressBatchSize]; JSAMPROW cb[kCompressBatchSize / 2]; @@ -386,7 +386,7 @@ bool JpegDecoder::decompressYUV(jpeg_decompress_struct* cinfo, const uint8_t* de return true; } -bool JpegDecoder::decompressSingleChannel(jpeg_decompress_struct* cinfo, const uint8_t* dest) { +bool JpegDecoderHelper::decompressSingleChannel(jpeg_decompress_struct* cinfo, const uint8_t* dest) { JSAMPROW y[kCompressBatchSize]; JSAMPARRAY planes[1] {y}; diff --git a/libs/jpegrecoverymap/jpegencoder.cpp b/libs/jpegrecoverymap/jpegencoderhelper.cpp index 627dcdf6ee..54b184d2ef 100644 --- a/libs/jpegrecoverymap/jpegencoder.cpp +++ b/libs/jpegrecoverymap/jpegencoderhelper.cpp @@ -14,7 +14,7 @@ * limitations under the License. */ -#include <jpegrecoverymap/jpegencoder.h> +#include <jpegrecoverymap/jpegencoderhelper.h> #include <utils/Log.h> @@ -22,20 +22,20 @@ namespace android::recoverymap { -// The destination manager that can access |mResultBuffer| in JpegEncoder. +// The destination manager that can access |mResultBuffer| in JpegEncoderHelper. struct destination_mgr { public: struct jpeg_destination_mgr mgr; - JpegEncoder* encoder; + JpegEncoderHelper* encoder; }; -JpegEncoder::JpegEncoder() { +JpegEncoderHelper::JpegEncoderHelper() { } -JpegEncoder::~JpegEncoder() { +JpegEncoderHelper::~JpegEncoderHelper() { } -bool JpegEncoder::compressImage(const void* image, int width, int height, int quality, +bool JpegEncoderHelper::compressImage(const void* image, int width, int height, int quality, const void* iccBuffer, unsigned int iccSize, bool isSingleChannel) { if (width % 8 != 0 || height % 2 != 0) { @@ -52,15 +52,15 @@ bool JpegEncoder::compressImage(const void* image, int width, int height, int qu return true; } -void* JpegEncoder::getCompressedImagePtr() { +void* JpegEncoderHelper::getCompressedImagePtr() { return mResultBuffer.data(); } -size_t JpegEncoder::getCompressedImageSize() { +size_t JpegEncoderHelper::getCompressedImageSize() { return mResultBuffer.size(); } -void JpegEncoder::initDestination(j_compress_ptr cinfo) { +void JpegEncoderHelper::initDestination(j_compress_ptr cinfo) { destination_mgr* dest = reinterpret_cast<destination_mgr*>(cinfo->dest); std::vector<JOCTET>& buffer = dest->encoder->mResultBuffer; buffer.resize(kBlockSize); @@ -68,7 +68,7 @@ void JpegEncoder::initDestination(j_compress_ptr cinfo) { dest->mgr.free_in_buffer = buffer.size(); } -boolean JpegEncoder::emptyOutputBuffer(j_compress_ptr cinfo) { +boolean JpegEncoderHelper::emptyOutputBuffer(j_compress_ptr cinfo) { destination_mgr* dest = reinterpret_cast<destination_mgr*>(cinfo->dest); std::vector<JOCTET>& buffer = dest->encoder->mResultBuffer; size_t oldsize = buffer.size(); @@ -78,13 +78,13 @@ boolean JpegEncoder::emptyOutputBuffer(j_compress_ptr cinfo) { return true; } -void JpegEncoder::terminateDestination(j_compress_ptr cinfo) { +void JpegEncoderHelper::terminateDestination(j_compress_ptr cinfo) { destination_mgr* dest = reinterpret_cast<destination_mgr*>(cinfo->dest); std::vector<JOCTET>& buffer = dest->encoder->mResultBuffer; buffer.resize(buffer.size() - dest->mgr.free_in_buffer); } -void JpegEncoder::outputErrorMessage(j_common_ptr cinfo) { +void JpegEncoderHelper::outputErrorMessage(j_common_ptr cinfo) { char buffer[JMSG_LENGTH_MAX]; /* Create the message */ @@ -92,7 +92,7 @@ void JpegEncoder::outputErrorMessage(j_common_ptr cinfo) { ALOGE("%s\n", buffer); } -bool JpegEncoder::encode(const void* image, int width, int height, int jpegQuality, +bool JpegEncoderHelper::encode(const void* image, int width, int height, int jpegQuality, const void* iccBuffer, unsigned int iccSize, bool isSingleChannel) { jpeg_compress_struct cinfo; jpeg_error_mgr jerr; @@ -118,7 +118,7 @@ bool JpegEncoder::encode(const void* image, int width, int height, int jpegQuali return true; } -void JpegEncoder::setJpegDestination(jpeg_compress_struct* cinfo) { +void JpegEncoderHelper::setJpegDestination(jpeg_compress_struct* cinfo) { destination_mgr* dest = static_cast<struct destination_mgr *>((*cinfo->mem->alloc_small) ( (j_common_ptr) cinfo, JPOOL_PERMANENT, sizeof(destination_mgr))); dest->encoder = this; @@ -128,7 +128,7 @@ void JpegEncoder::setJpegDestination(jpeg_compress_struct* cinfo) { cinfo->dest = reinterpret_cast<struct jpeg_destination_mgr*>(dest); } -void JpegEncoder::setJpegCompressStruct(int width, int height, int quality, +void JpegEncoderHelper::setJpegCompressStruct(int width, int height, int quality, jpeg_compress_struct* cinfo, bool isSingleChannel) { cinfo->image_width = width; cinfo->image_height = height; @@ -158,7 +158,7 @@ void JpegEncoder::setJpegCompressStruct(int width, int height, int quality, } } -bool JpegEncoder::compress( +bool JpegEncoderHelper::compress( jpeg_compress_struct* cinfo, const uint8_t* image, bool isSingleChannel) { if (isSingleChannel) { return compressSingleChannel(cinfo, image); @@ -166,7 +166,7 @@ bool JpegEncoder::compress( return compressYuv(cinfo, image); } -bool JpegEncoder::compressYuv(jpeg_compress_struct* cinfo, const uint8_t* yuv) { +bool JpegEncoderHelper::compressYuv(jpeg_compress_struct* cinfo, const uint8_t* yuv) { JSAMPROW y[kCompressBatchSize]; JSAMPROW cb[kCompressBatchSize / 2]; JSAMPROW cr[kCompressBatchSize / 2]; @@ -210,7 +210,7 @@ bool JpegEncoder::compressYuv(jpeg_compress_struct* cinfo, const uint8_t* yuv) { return true; } -bool JpegEncoder::compressSingleChannel(jpeg_compress_struct* cinfo, const uint8_t* image) { +bool JpegEncoderHelper::compressSingleChannel(jpeg_compress_struct* cinfo, const uint8_t* image) { JSAMPROW y[kCompressBatchSize]; JSAMPARRAY planes[1] {y}; diff --git a/libs/jpegrecoverymap/recoverymap.cpp b/libs/jpegrecoverymap/recoverymap.cpp index 8b8c2e7fe8..218c43017b 100644 --- a/libs/jpegrecoverymap/recoverymap.cpp +++ b/libs/jpegrecoverymap/recoverymap.cpp @@ -15,8 +15,8 @@ */ #include <jpegrecoverymap/recoverymap.h> -#include <jpegrecoverymap/jpegencoder.h> -#include <jpegrecoverymap/jpegdecoder.h> +#include <jpegrecoverymap/jpegencoderhelper.h> +#include <jpegrecoverymap/jpegdecoderhelper.h> #include <jpegrecoverymap/recoverymapmath.h> #include <jpegrecoverymap/recoverymaputils.h> @@ -146,7 +146,7 @@ status_t RecoveryMap::encodeJPEGR(jr_uncompressed_ptr uncompressed_p010_image, jrTransFunc_to_skTransFunc.at(JPEGR_TF_SRGB), jrGamut_to_skGamut.at(uncompressed_yuv_420_image.colorGamut)); - JpegEncoder jpeg_encoder; + JpegEncoderHelper jpeg_encoder; if (!jpeg_encoder.compressImage(uncompressed_yuv_420_image.data, uncompressed_yuv_420_image.width, uncompressed_yuv_420_image.height, quality, @@ -210,7 +210,7 @@ status_t RecoveryMap::encodeJPEGR(jr_uncompressed_ptr uncompressed_p010_image, jrTransFunc_to_skTransFunc.at(JPEGR_TF_SRGB), jrGamut_to_skGamut.at(uncompressed_yuv_420_image->colorGamut)); - JpegEncoder jpeg_encoder; + JpegEncoderHelper jpeg_encoder; if (!jpeg_encoder.compressImage(uncompressed_yuv_420_image->data, uncompressed_yuv_420_image->width, uncompressed_yuv_420_image->height, quality, @@ -289,7 +289,7 @@ status_t RecoveryMap::encodeJPEGR(jr_uncompressed_ptr uncompressed_p010_image, return ERROR_JPEGR_INVALID_INPUT_TYPE; } - JpegDecoder jpeg_decoder; + JpegDecoderHelper jpeg_decoder; if (!jpeg_decoder.decompressImage(compressed_jpeg_image->data, compressed_jpeg_image->length)) { return ERROR_JPEGR_DECODE_ERROR; } @@ -334,7 +334,7 @@ status_t RecoveryMap::getJPEGRInfo(jr_compressed_ptr compressed_jpegr_image, JPEGR_CHECK(extractPrimaryImageAndRecoveryMap(compressed_jpegr_image, &primary_image, &recovery_map)); - JpegDecoder jpeg_decoder; + JpegDecoderHelper jpeg_decoder; if (!jpeg_decoder.getCompressedImageParameters(primary_image.data, primary_image.length, &jpegr_info->width, &jpegr_info->height, jpegr_info->iccData, jpegr_info->exifData)) { @@ -356,7 +356,7 @@ status_t RecoveryMap::decodeJPEGR(jr_compressed_ptr compressed_jpegr_image, (void) exif; if (request_sdr) { - JpegDecoder jpeg_decoder; + JpegDecoderHelper jpeg_decoder; if (!jpeg_decoder.decompressImage(compressed_jpegr_image->data, compressed_jpegr_image->length, true)) { return ERROR_JPEGR_DECODE_ERROR; @@ -376,12 +376,12 @@ status_t RecoveryMap::decodeJPEGR(jr_compressed_ptr compressed_jpegr_image, jpegr_metadata metadata; JPEGR_CHECK(extractRecoveryMap(compressed_jpegr_image, &compressed_map)); - JpegDecoder jpeg_decoder; + JpegDecoderHelper jpeg_decoder; if (!jpeg_decoder.decompressImage(compressed_jpegr_image->data, compressed_jpegr_image->length)) { return ERROR_JPEGR_DECODE_ERROR; } - JpegDecoder recovery_map_decoder; + JpegDecoderHelper recovery_map_decoder; if (!recovery_map_decoder.decompressImage(compressed_map.data, compressed_map.length)) { return ERROR_JPEGR_DECODE_ERROR; } @@ -411,7 +411,7 @@ status_t RecoveryMap::compressRecoveryMap(jr_uncompressed_ptr uncompressed_recov return ERROR_JPEGR_INVALID_NULL_PTR; } - JpegEncoder jpeg_encoder; + JpegEncoderHelper jpeg_encoder; if (!jpeg_encoder.compressImage(uncompressed_recovery_map->data, uncompressed_recovery_map->width, uncompressed_recovery_map->height, diff --git a/libs/jpegrecoverymap/tests/Android.bp b/libs/jpegrecoverymap/tests/Android.bp index e381caf025..e416db9e2d 100644 --- a/libs/jpegrecoverymap/tests/Android.bp +++ b/libs/jpegrecoverymap/tests/Android.bp @@ -44,10 +44,10 @@ cc_test { } cc_test { - name: "libjpegencoder_test", + name: "libjpegencoderhelper_test", test_suites: ["device-tests"], srcs: [ - "jpegencoder_test.cpp", + "jpegencoderhelper_test.cpp", ], shared_libs: [ "libjpeg", @@ -60,10 +60,10 @@ cc_test { } cc_test { - name: "libjpegdecoder_test", + name: "libjpegdecoderhelper_test", test_suites: ["device-tests"], srcs: [ - "jpegdecoder_test.cpp", + "jpegdecoderhelper_test.cpp", ], shared_libs: [ "libjpeg", diff --git a/libs/jpegrecoverymap/tests/jpegdecoder_test.cpp b/libs/jpegrecoverymap/tests/jpegdecoderhelper_test.cpp index 8e013517fb..278bf3b847 100644 --- a/libs/jpegrecoverymap/tests/jpegdecoder_test.cpp +++ b/libs/jpegrecoverymap/tests/jpegdecoderhelper_test.cpp @@ -14,7 +14,7 @@ * limitations under the License. */ -#include <jpegrecoverymap/jpegdecoder.h> +#include <jpegrecoverymap/jpegdecoderhelper.h> #include <gtest/gtest.h> #include <utils/Log.h> @@ -27,14 +27,14 @@ namespace android::recoverymap { #define GREY_IMAGE "/sdcard/Documents/minnie-320x240-y.jpg" #define GREY_IMAGE_SIZE 20193 -class JpegDecoderTest : public testing::Test { +class JpegDecoderHelperTest : public testing::Test { public: struct Image { std::unique_ptr<uint8_t[]> buffer; size_t size; }; - JpegDecoderTest(); - ~JpegDecoderTest(); + JpegDecoderHelperTest(); + ~JpegDecoderHelperTest(); protected: virtual void SetUp(); virtual void TearDown(); @@ -42,9 +42,9 @@ protected: Image mYuvImage, mGreyImage; }; -JpegDecoderTest::JpegDecoderTest() {} +JpegDecoderHelperTest::JpegDecoderHelperTest() {} -JpegDecoderTest::~JpegDecoderTest() {} +JpegDecoderHelperTest::~JpegDecoderHelperTest() {} static size_t getFileSize(int fd) { struct stat st; @@ -55,7 +55,7 @@ static size_t getFileSize(int fd) { return st.st_size; // bytes } -static bool loadFile(const char filename[], JpegDecoderTest::Image* result) { +static bool loadFile(const char filename[], JpegDecoderHelperTest::Image* result) { int fd = open(filename, O_CLOEXEC); if (fd < 0) { return false; @@ -74,7 +74,7 @@ static bool loadFile(const char filename[], JpegDecoderTest::Image* result) { return true; } -void JpegDecoderTest::SetUp() { +void JpegDecoderHelperTest::SetUp() { if (!loadFile(YUV_IMAGE, &mYuvImage)) { FAIL() << "Load file " << YUV_IMAGE << " failed"; } @@ -85,16 +85,16 @@ void JpegDecoderTest::SetUp() { mGreyImage.size = GREY_IMAGE_SIZE; } -void JpegDecoderTest::TearDown() {} +void JpegDecoderHelperTest::TearDown() {} -TEST_F(JpegDecoderTest, decodeYuvImage) { - JpegDecoder decoder; +TEST_F(JpegDecoderHelperTest, decodeYuvImage) { + JpegDecoderHelper decoder; EXPECT_TRUE(decoder.decompressImage(mYuvImage.buffer.get(), mYuvImage.size)); ASSERT_GT(decoder.getDecompressedImageSize(), static_cast<uint32_t>(0)); } -TEST_F(JpegDecoderTest, decodeGreyImage) { - JpegDecoder decoder; +TEST_F(JpegDecoderHelperTest, decodeGreyImage) { + JpegDecoderHelper decoder; EXPECT_TRUE(decoder.decompressImage(mGreyImage.buffer.get(), mGreyImage.size)); ASSERT_GT(decoder.getDecompressedImageSize(), static_cast<uint32_t>(0)); } diff --git a/libs/jpegrecoverymap/tests/jpegencoder_test.cpp b/libs/jpegrecoverymap/tests/jpegencoderhelper_test.cpp index 4cd2a5ef8c..532688d06f 100644 --- a/libs/jpegrecoverymap/tests/jpegencoder_test.cpp +++ b/libs/jpegrecoverymap/tests/jpegencoderhelper_test.cpp @@ -14,7 +14,7 @@ * limitations under the License. */ -#include <jpegrecoverymap/jpegencoder.h> +#include <jpegrecoverymap/jpegencoderhelper.h> #include <gtest/gtest.h> #include <utils/Log.h> @@ -33,15 +33,15 @@ namespace android::recoverymap { #define INVALID_SIZE_IMAGE_HEIGHT 240 #define JPEG_QUALITY 90 -class JpegEncoderTest : public testing::Test { +class JpegEncoderHelperTest : public testing::Test { public: struct Image { std::unique_ptr<uint8_t[]> buffer; size_t width; size_t height; }; - JpegEncoderTest(); - ~JpegEncoderTest(); + JpegEncoderHelperTest(); + ~JpegEncoderHelperTest(); protected: virtual void SetUp(); virtual void TearDown(); @@ -49,9 +49,9 @@ protected: Image mValidImage, mInvalidSizeImage, mSingleChannelImage; }; -JpegEncoderTest::JpegEncoderTest() {} +JpegEncoderHelperTest::JpegEncoderHelperTest() {} -JpegEncoderTest::~JpegEncoderTest() {} +JpegEncoderHelperTest::~JpegEncoderHelperTest() {} static size_t getFileSize(int fd) { struct stat st; @@ -62,7 +62,7 @@ static size_t getFileSize(int fd) { return st.st_size; // bytes } -static bool loadFile(const char filename[], JpegEncoderTest::Image* result) { +static bool loadFile(const char filename[], JpegEncoderHelperTest::Image* result) { int fd = open(filename, O_CLOEXEC); if (fd < 0) { return false; @@ -81,7 +81,7 @@ static bool loadFile(const char filename[], JpegEncoderTest::Image* result) { return true; } -void JpegEncoderTest::SetUp() { +void JpegEncoderHelperTest::SetUp() { if (!loadFile(VALID_IMAGE, &mValidImage)) { FAIL() << "Load file " << VALID_IMAGE << " failed"; } @@ -99,23 +99,23 @@ void JpegEncoderTest::SetUp() { mSingleChannelImage.height = SINGLE_CHANNEL_IMAGE_HEIGHT; } -void JpegEncoderTest::TearDown() {} +void JpegEncoderHelperTest::TearDown() {} -TEST_F(JpegEncoderTest, validImage) { - JpegEncoder encoder; +TEST_F(JpegEncoderHelperTest, validImage) { + JpegEncoderHelper encoder; EXPECT_TRUE(encoder.compressImage(mValidImage.buffer.get(), mValidImage.width, mValidImage.height, JPEG_QUALITY, NULL, 0)); ASSERT_GT(encoder.getCompressedImageSize(), static_cast<uint32_t>(0)); } -TEST_F(JpegEncoderTest, invalidSizeImage) { - JpegEncoder encoder; +TEST_F(JpegEncoderHelperTest, invalidSizeImage) { + JpegEncoderHelper encoder; EXPECT_FALSE(encoder.compressImage(mInvalidSizeImage.buffer.get(), mInvalidSizeImage.width, mInvalidSizeImage.height, JPEG_QUALITY, NULL, 0)); } -TEST_F(JpegEncoderTest, singleChannelImage) { - JpegEncoder encoder; +TEST_F(JpegEncoderHelperTest, singleChannelImage) { + JpegEncoderHelper encoder; EXPECT_TRUE(encoder.compressImage(mSingleChannelImage.buffer.get(), mSingleChannelImage.width, mSingleChannelImage.height, JPEG_QUALITY, NULL, 0, true)); ASSERT_GT(encoder.getCompressedImageSize(), static_cast<uint32_t>(0)); |