summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Cody Northrop <cnorthrop@google.com> 2023-01-06 17:06:03 -0700
committer Cody Northrop <cnorthrop@google.com> 2023-01-09 15:26:56 -0700
commit0278db49d358943cd52655b4d63f1c46efa4e76a (patch)
tree21739d3255c03824227b4a49e417029180774613
parent990ff7ba368f3d24ba6ac25321e326c82f13d620 (diff)
EGL BlobCache: Disable multifile to address Wembley perf
Need to investigate multifile performance on Wembley, which does not use SkiaVk. That means many small/simple GL programs are taking longer to start. Accessing the filesystem is taking longer than a quick return from a sub 1MB cache. Test: Build and inspect cache locally Test: /data/nativetest64/EGL_test/EGL_test Bug: b/263574392 Change-Id: Iacc725f902fd91c7cbd06b293ec96f5ab5eeb1c3
-rw-r--r--opengl/libs/EGL/egl_cache.cpp4
-rw-r--r--opengl/tests/EGLTest/egl_cache_test.cpp3
2 files changed, 4 insertions, 3 deletions
diff --git a/opengl/libs/EGL/egl_cache.cpp b/opengl/libs/EGL/egl_cache.cpp
index 55979444ee..1e8a34863d 100644
--- a/opengl/libs/EGL/egl_cache.cpp
+++ b/opengl/libs/EGL/egl_cache.cpp
@@ -69,7 +69,7 @@ static EGLsizeiANDROID getBlob(const void* key, EGLsizeiANDROID keySize, void* v
//
egl_cache_t::egl_cache_t()
: mInitialized(false),
- mMultifileMode(true),
+ mMultifileMode(false),
mCacheByteLimit(maxTotalSize),
mMultifileCleanupPending(false) {}
@@ -114,8 +114,6 @@ void egl_cache_t::initialize(egl_display_t* display) {
}
}
- mMultifileMode = true;
-
// Allow forcing monolithic cache for debug purposes
if (base::GetProperty("debug.egl.blobcache.multifilemode", "") == "false") {
ALOGD("Forcing monolithic cache due to debug.egl.blobcache.multifilemode == \"false\"");
diff --git a/opengl/tests/EGLTest/egl_cache_test.cpp b/opengl/tests/EGLTest/egl_cache_test.cpp
index c4fa65f044..265bec492e 100644
--- a/opengl/tests/EGLTest/egl_cache_test.cpp
+++ b/opengl/tests/EGLTest/egl_cache_test.cpp
@@ -134,6 +134,9 @@ std::string EGLCacheTest::getCachefileName() {
}
TEST_F(EGLCacheTest, ModifiedCacheMisses) {
+ // Turn this back on if multifile becomes the default
+ GTEST_SKIP() << "Skipping test designed for multifile, see b/263574392 and b/246966894";
+
uint8_t buf[4] = { 0xee, 0xee, 0xee, 0xee };
mCache->initialize(egl_display_t::get(EGL_DEFAULT_DISPLAY));