summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Chung-yih Wang <cywang@google.com> 2009-07-06 11:22:18 -0700
committer The Android Open Source Project <initial-contribution@android.com> 2009-07-06 11:22:18 -0700
commite439029f8a99217d030f859039e597468381af7f (patch)
tree92b76e91b37213cfddd391bb98b950ce858fc765
parente68a938829a6a07c94a60993c57081a5c274f94f (diff)
parent6ac03019e68e6cd8732c5c1670eb71f4840010e2 (diff)
am 699ca3f2: Add password field for WiFi configuration.
Merge commit '699ca3f2518360ea3250ff5a0e5d39e122c64a91' * commit '699ca3f2518360ea3250ff5a0e5d39e122c64a91': Add password field for WiFi configuration.
-rw-r--r--cmds/keystore/certtool.h16
1 files changed, 12 insertions, 4 deletions
diff --git a/cmds/keystore/certtool.h b/cmds/keystore/certtool.h
index 7cd316b0fd..aefad668d1 100644
--- a/cmds/keystore/certtool.h
+++ b/cmds/keystore/certtool.h
@@ -26,21 +26,29 @@
#include "common.h"
#include "netkeystore.h"
+#define CERT_NAME_LEN (2 * MAX_KEY_NAME_LENGTH + 2)
+
/*
* The specific function 'get_cert' is used in daemons to get the key value
* from keystore. Caller should allocate the buffer and the length of the buffer
* should be MAX_KEY_VALUE_LENGTH.
*/
-static inline int get_cert(char *certname, unsigned char *value, int *size)
+static inline int get_cert(const char *certname, unsigned char *value, int *size)
{
int count, fd, ret = -1;
LPC_MARSHAL cmd;
char delimiter[] = "_";
char *namespace, *keyname;
char *context = NULL;
+ char cname[CERT_NAME_LEN];
+
+ if ((certname == NULL) || (value == NULL)) {
+ LOGE("get_cert: certname or value is null\n");
+ return -1;
+ }
- if (value == NULL) {
- LOGE("get_cert: value is null\n");
+ if (strlcpy(cname, certname, CERT_NAME_LEN) >= CERT_NAME_LEN) {
+ LOGE("get_cert: keyname is too long\n");
return -1;
}
@@ -53,7 +61,7 @@ static inline int get_cert(char *certname, unsigned char *value, int *size)
}
cmd.opcode = GET;
- if (((namespace = strtok_r(certname, delimiter, &context)) == NULL) ||
+ if (((namespace = strtok_r(cname, delimiter, &context)) == NULL) ||
((keyname = strtok_r(NULL, delimiter, &context)) == NULL)) {
goto err;
}