summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <treehugger-gerrit@google.com> 2020-11-24 00:41:21 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2020-11-24 00:41:21 +0000
commite42a54b17768ea80f198c1b00bc6c4797a4485d8 (patch)
tree99794ba792fc06afb7ce7f08b19b165287c7749c
parent80315724d28a80451874874232a8dbcd2e57a6ad (diff)
parent12623df409ab8ada80e344ca852bdbc41736adb4 (diff)
Merge "setParcelable uses const ref instead of pointer"
-rw-r--r--libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h8
1 files changed, 5 insertions, 3 deletions
diff --git a/libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h b/libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h
index dfcf4dc26f..4858514164 100644
--- a/libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h
+++ b/libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h
@@ -82,13 +82,13 @@ class AParcelableHolder {
}
template <typename T>
- bool setParcelable(T* p) {
- if (p && this->mStability > T::_aidl_stability) {
+ bool setParcelable(const T& p) {
+ if (this->mStability > T::_aidl_stability) {
return false;
}
AParcel_reset(mParcel.get());
AParcel_writeString(mParcel.get(), T::descriptor, strlen(T::descriptor));
- p->writeToParcel(mParcel.get());
+ p.writeToParcel(mParcel.get());
return true;
}
@@ -112,6 +112,8 @@ class AParcelableHolder {
return std::move(ret);
}
+ void reset() { AParcel_reset(mParcel.get()); }
+
private:
mutable ndk::ScopedAParcel mParcel;
parcelable_stability_t mStability;