diff options
| author | 2020-11-11 20:25:34 -0800 | |
|---|---|---|
| committer | 2020-11-11 20:25:34 -0800 | |
| commit | df6a4f6d788b591b65ad14dc872b3520f0cf4a7c (patch) | |
| tree | aca85e97d978750ecdfbe0c11623845d121d7d0b | |
| parent | 7899958a90a124b5c136c50b36f9b2c86920d403 (diff) | |
Statically link missing libraries to libsurfaceflinger_unittest
Some targets do not have the library in their system or
vendor image so the test fails to run.
Fixes: 170341496
Test: atest -a libsurfaceflinger_unittest on cf_x86_64_phone-userdebug
Change-Id: I61e7702e6b36f218bebc7c87853001861a92741e
6 files changed, 55 insertions, 25 deletions
diff --git a/services/surfaceflinger/TimeStats/Android.bp b/services/surfaceflinger/TimeStats/Android.bp index 39017575b7..0a23da2e9c 100644 --- a/services/surfaceflinger/TimeStats/Android.bp +++ b/services/surfaceflinger/TimeStats/Android.bp @@ -1,4 +1,4 @@ -cc_library_shared { +cc_library { name: "libtimestats", srcs: [ "TimeStats.cpp", diff --git a/services/surfaceflinger/TimeStats/timestatsproto/Android.bp b/services/surfaceflinger/TimeStats/timestatsproto/Android.bp index 9513cabfb6..fae4e94dd9 100644 --- a/services/surfaceflinger/TimeStats/timestatsproto/Android.bp +++ b/services/surfaceflinger/TimeStats/timestatsproto/Android.bp @@ -1,4 +1,4 @@ -cc_library_shared { +cc_library { name: "libtimestats_proto", export_include_dirs: ["include"], diff --git a/services/surfaceflinger/layerproto/Android.bp b/services/surfaceflinger/layerproto/Android.bp index 0a73b23240..e2a28a2ae5 100644 --- a/services/surfaceflinger/layerproto/Android.bp +++ b/services/surfaceflinger/layerproto/Android.bp @@ -1,5 +1,5 @@ -cc_defaults { - name: "liblayers_proto_defaults", +cc_library { + name: "liblayers_proto", export_include_dirs: ["include"], srcs: [ @@ -19,7 +19,7 @@ cc_defaults { proto: { export_proto_headers: true, }, - + cppflags: [ "-Werror", "-Wno-unused-parameter", @@ -35,20 +35,6 @@ cc_defaults { ], } -cc_library_shared { - name: "liblayers_proto", - defaults: [ - "liblayers_proto_defaults", - ], -} - -cc_library_static { - name: "liblayers_proto_static", - defaults: [ - "liblayers_proto_defaults", - ], -} - java_library_static { name: "layersprotosnano", host_supported: true, diff --git a/services/surfaceflinger/tests/Android.bp b/services/surfaceflinger/tests/Android.bp index 02b4308123..e8b24b49bc 100644 --- a/services/surfaceflinger/tests/Android.bp +++ b/services/surfaceflinger/tests/Android.bp @@ -46,7 +46,7 @@ cc_test { data: ["SurfaceFlinger_test.filter"], static_libs: [ "libtrace_proto", - "liblayers_proto_static", + "liblayers_proto", "android.hardware.graphics.composer@2.1", ], shared_libs: [ diff --git a/services/surfaceflinger/tests/unittests/Android.bp b/services/surfaceflinger/tests/unittests/Android.bp index 8097a88f30..18f3745ed9 100644 --- a/services/surfaceflinger/tests/unittests/Android.bp +++ b/services/surfaceflinger/tests/unittests/Android.bp @@ -14,7 +14,7 @@ cc_test { name: "libsurfaceflinger_unittest", - defaults: ["libsurfaceflinger_defaults"], + defaults: ["surfaceflinger_defaults"], test_suites: ["device-tests"], sanitize: { // Using the address sanitizer not only helps uncover issues in the code @@ -94,22 +94,65 @@ cc_test { "mock/system/window/MockNativeWindow.cpp", ], static_libs: [ - "libgmock", - "libcompositionengine", + "android.hardware.graphics.composer@2.1", + "android.hardware.graphics.composer@2.2", + "android.hardware.graphics.composer@2.3", + "android.hardware.graphics.composer@2.4", + "android.hardware.power@1.0", + "android.hardware.power@1.1", + "android.hardware.power@1.2", + "android.hardware.power@1.3", "libcompositionengine_mocks", + "libcompositionengine", "libframetimeline", + "libgmock", "libgui_mocks", + "liblayers_proto", "libperfetto_client_experimental", "librenderengine_mocks", + "librenderengine", + "libserviceutils", + "libtimestats", + "libtimestats_proto", + "libtrace_proto", "perfetto_trace_protos", ], shared_libs: [ + "android.hardware.configstore-utils", + "android.hardware.configstore@1.0", + "android.hardware.configstore@1.1", + "android.hardware.graphics.allocator@2.0", + "android.hardware.graphics.allocator@3.0", + "android.hardware.graphics.common@1.2", + "android.hardware.power-cpp", + "libbase", + "libbinder", + "libcutils", + "libEGL", + "libfmq", + "libGLESv1_CM", + "libGLESv2", + "libgui", + "libhidlbase", + "libinput", + "liblog", + "libnativewindow", + "libprocessgroup", + "libprotobuf-cpp-lite", "libprotoutil", + "libstatslog", "libstatssocket", - "libtimestats", - "libtimestats_proto", + "libSurfaceFlingerProp", + "libsync", + "libui", + "libutils", + "libstatspull", ], header_libs: [ + "android.hardware.graphics.composer@2.1-command-buffer", + "android.hardware.graphics.composer@2.2-command-buffer", + "android.hardware.graphics.composer@2.3-command-buffer", + "android.hardware.graphics.composer@2.4-command-buffer", "libsurfaceflinger_headers", ], } diff --git a/services/surfaceflinger/tests/unittests/mock/DisplayHardware/MockComposer.cpp b/services/surfaceflinger/tests/unittests/mock/DisplayHardware/MockComposer.cpp index 251ab36d14..7de187207e 100644 --- a/services/surfaceflinger/tests/unittests/mock/DisplayHardware/MockComposer.cpp +++ b/services/surfaceflinger/tests/unittests/mock/DisplayHardware/MockComposer.cpp @@ -18,6 +18,7 @@ #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wconversion" +#define LOG_TAG "MockComposer" #include "mock/DisplayHardware/MockComposer.h" namespace android::Hwc2::mock { |