diff options
author | 2021-09-16 22:28:04 +0000 | |
---|---|---|
committer | 2021-09-16 22:28:04 +0000 | |
commit | bf90a44985f8ed9a41b6d65acd44886d1f43ef26 (patch) | |
tree | 74645a49dba2f25c179e142e456d1efa59332cda | |
parent | 00e163d9dcca9ae3928c611ce9f3611f942386e5 (diff) | |
parent | 631e2e1900c4ca6ee3e4244930dbab5ebbdc9a7d (diff) |
Remove the redundant getProcessFreezeInfo() am: 4e678b9830 am: 631e2e1900
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/15842844
Change-Id: Ie6a327b6456bb543937dc54bda8f91b83cb99e59
-rw-r--r-- | libs/binder/IPCThreadState.cpp | 18 | ||||
-rw-r--r-- | libs/binder/include/binder/IPCThreadState.h | 8 | ||||
-rw-r--r-- | libs/binder/tests/binderLibTest.cpp | 12 |
3 files changed, 3 insertions, 35 deletions
diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp index 9e04ffeb11..55d3d70bd4 100644 --- a/libs/binder/IPCThreadState.cpp +++ b/libs/binder/IPCThreadState.cpp @@ -1410,23 +1410,6 @@ void IPCThreadState::threadDestructor(void *st) } } -status_t IPCThreadState::getProcessFreezeInfo(pid_t pid, bool *sync_received, bool *async_received) -{ - int ret = 0; - binder_frozen_status_info info; - info.pid = pid; - -#if defined(__ANDROID__) - if (ioctl(self()->mProcess->mDriverFD, BINDER_GET_FROZEN_INFO, &info) < 0) - ret = -errno; -#endif - *sync_received = info.sync_recv; - *async_received = info.async_recv; - - return ret; -} - -#ifndef __ANDROID_VNDK__ status_t IPCThreadState::getProcessFreezeInfo(pid_t pid, uint32_t *sync_received, uint32_t *async_received) { @@ -1443,7 +1426,6 @@ status_t IPCThreadState::getProcessFreezeInfo(pid_t pid, uint32_t *sync_received return ret; } -#endif status_t IPCThreadState::freeze(pid_t pid, bool enable, uint32_t timeout_ms) { struct binder_freeze_info info; diff --git a/libs/binder/include/binder/IPCThreadState.h b/libs/binder/include/binder/IPCThreadState.h index 065e6e3b1d..82bebc95f4 100644 --- a/libs/binder/include/binder/IPCThreadState.h +++ b/libs/binder/include/binder/IPCThreadState.h @@ -51,17 +51,11 @@ public: static status_t freeze(pid_t pid, bool enabled, uint32_t timeout_ms); // Provide information about the state of a frozen process - static status_t getProcessFreezeInfo(pid_t pid, bool *sync_received, - bool *async_received); - - // TODO: Remove the above legacy duplicated function in next version -#ifndef __ANDROID_VNDK__ static status_t getProcessFreezeInfo(pid_t pid, uint32_t *sync_received, uint32_t *async_received); -#endif sp<ProcessState> process(); - + status_t clearLastError(); /** diff --git a/libs/binder/tests/binderLibTest.cpp b/libs/binder/tests/binderLibTest.cpp index 639876ffe3..c69203be2d 100644 --- a/libs/binder/tests/binderLibTest.cpp +++ b/libs/binder/tests/binderLibTest.cpp @@ -491,7 +491,7 @@ TEST_F(BinderLibTest, Freeze) { EXPECT_EQ(NO_ERROR, IPCThreadState::self()->freeze(pid, true, 1000)); EXPECT_EQ(FAILED_TRANSACTION, m_server->transact(BINDER_LIB_TEST_NOP_TRANSACTION, data, &reply)); - bool sync_received, async_received; + uint32_t sync_received, async_received; EXPECT_EQ(NO_ERROR, IPCThreadState::self()->getProcessFreezeInfo(pid, &sync_received, &async_received)); @@ -499,15 +499,7 @@ TEST_F(BinderLibTest, Freeze) { EXPECT_EQ(sync_received, 1); EXPECT_EQ(async_received, 0); - uint32_t sync_received2, async_received2; - - EXPECT_EQ(NO_ERROR, IPCThreadState::self()->getProcessFreezeInfo(pid, &sync_received2, - &async_received2)); - - EXPECT_EQ(sync_received2, 1); - EXPECT_EQ(async_received2, 0); - - EXPECT_EQ(NO_ERROR, IPCThreadState::self()->freeze(pid, 0, 0)); + EXPECT_EQ(NO_ERROR, IPCThreadState::self()->freeze(pid, false, 0)); EXPECT_EQ(NO_ERROR, m_server->transact(BINDER_LIB_TEST_NOP_TRANSACTION, data, &reply)); } |