summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Mathias Agopian <mathias@google.com> 2010-03-25 18:42:34 -0700
committer Android (Google) Code Review <android-gerrit@google.com> 2010-03-25 18:42:34 -0700
commitba5b381d010193729e4837e1af649269b54a6b8e (patch)
treeb289d7614f9950bdf8de025be2daa984a1f9ceb6
parentd1eeb2c682f80d246dc80fb379aaf3845e75a0cb (diff)
parentc8620b60d67390d2bd0fa0ce53cc63fc18c50244 (diff)
Merge "fix [2545826] calling into gralloc with external lock held"
-rw-r--r--include/ui/GraphicBufferAllocator.h1
-rw-r--r--libs/ui/GraphicBufferAllocator.cpp4
2 files changed, 0 insertions, 5 deletions
diff --git a/include/ui/GraphicBufferAllocator.h b/include/ui/GraphicBufferAllocator.h
index be9c79bef7..741d763561 100644
--- a/include/ui/GraphicBufferAllocator.h
+++ b/include/ui/GraphicBufferAllocator.h
@@ -86,7 +86,6 @@ private:
GraphicBufferAllocator();
~GraphicBufferAllocator();
- mutable Mutex mLock;
alloc_device_t *mAllocDev;
};
diff --git a/libs/ui/GraphicBufferAllocator.cpp b/libs/ui/GraphicBufferAllocator.cpp
index 57d5fc34c6..6ae7e741b6 100644
--- a/libs/ui/GraphicBufferAllocator.cpp
+++ b/libs/ui/GraphicBufferAllocator.cpp
@@ -78,8 +78,6 @@ static inline uint32_t clamp(uint32_t c) {
status_t GraphicBufferAllocator::alloc(uint32_t w, uint32_t h, PixelFormat format,
int usage, buffer_handle_t* handle, int32_t* stride)
{
- Mutex::Autolock _l(mLock);
-
// make sure to not allocate a 0 x 0 buffer
w = clamp(w);
h = clamp(h);
@@ -118,8 +116,6 @@ status_t GraphicBufferAllocator::alloc(uint32_t w, uint32_t h, PixelFormat forma
status_t GraphicBufferAllocator::free(buffer_handle_t handle)
{
- Mutex::Autolock _l(mLock);
-
status_t err;
if (sw_gralloc_handle_t::validate(handle) < 0) {
err = mAllocDev->free(mAllocDev, handle);