summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Steven Moreland <smoreland@google.com> 2022-08-01 18:57:59 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2022-08-01 18:57:59 +0000
commitb50bc9cd1dec3e4dd679aed44582b8d24628e985 (patch)
tree7a4ca8564abef7499f39cf8013620a638fd2cdc3
parent3fa44d30c2d797585b3c44869f63e94bc441e7b2 (diff)
parentb002684b4eb1dbf1381b2b5afbb7e079efcce4b9 (diff)
Merge "libbinder: ~BBinder checks for all values" am: ddcb34e027 am: 2c7a0602cf am: d07469c8f9 am: 618044fa7e am: b002684b4e
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2170233 Change-Id: Ifc2ed22b61e046087490bd7e476d8035a677bd4f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--libs/binder/Binder.cpp18
1 files changed, 16 insertions, 2 deletions
diff --git a/libs/binder/Binder.cpp b/libs/binder/Binder.cpp
index 532bacbdfe..2541265ba5 100644
--- a/libs/binder/Binder.cpp
+++ b/libs/binder/Binder.cpp
@@ -610,8 +610,22 @@ void BBinder::removeRpcServerLink(const sp<RpcServerLink>& link) {
BBinder::~BBinder()
{
- if (!wasParceled() && getExtension()) {
- ALOGW("Binder %p destroyed with extension attached before being parceled.", this);
+ if (!wasParceled()) {
+ if (getExtension()) {
+ ALOGW("Binder %p destroyed with extension attached before being parceled.", this);
+ }
+ if (isRequestingSid()) {
+ ALOGW("Binder %p destroyed when requesting SID before being parceled.", this);
+ }
+ if (isInheritRt()) {
+ ALOGW("Binder %p destroyed after setInheritRt before being parceled.", this);
+ }
+ if (getMinSchedulerPolicy() != SCHED_NORMAL) {
+ ALOGW("Binder %p destroyed after setMinSchedulerPolicy before being parceled.", this);
+ }
+ if (getMinSchedulerPriority() != 0) {
+ ALOGW("Binder %p destroyed after setMinSchedulerPolicy before being parceled.", this);
+ }
}
Extras* e = mExtras.load(std::memory_order_relaxed);