diff options
| author | 2022-03-23 18:52:15 +0000 | |
|---|---|---|
| committer | 2022-03-23 18:52:15 +0000 | |
| commit | af5fa6bf7519e780e017cd1af87ed0a4b3dcb5b8 (patch) | |
| tree | 5508ceb8eac8106fd91337e1d6b0f855cf232afa | |
| parent | 5364e03665cff63b7fd4b55565e636bb03cf4851 (diff) | |
| parent | 76236e1ece625b02f0875697ee61a1f53d212626 (diff) | |
Merge "Disable normalization for power hint by default" into tm-dev
| -rw-r--r-- | services/surfaceflinger/DisplayHardware/PowerAdvisor.cpp | 4 | ||||
| -rw-r--r-- | services/surfaceflinger/SurfaceFlinger.cpp | 22 |
2 files changed, 13 insertions, 13 deletions
diff --git a/services/surfaceflinger/DisplayHardware/PowerAdvisor.cpp b/services/surfaceflinger/DisplayHardware/PowerAdvisor.cpp index 3dab38975c..44c086d7d3 100644 --- a/services/surfaceflinger/DisplayHardware/PowerAdvisor.cpp +++ b/services/surfaceflinger/DisplayHardware/PowerAdvisor.cpp @@ -542,7 +542,7 @@ private: static constexpr double kAllowedTargetDeviationPercent = 0.05; // Target used for init and normalization, the actual value does not really matter static constexpr const std::chrono::nanoseconds kDefaultTarget = 50ms; - // amount of time after the last message was sent before the session goes stale + // Amount of time after the last message was sent before the session goes stale // actually 100ms but we use 80 here to ideally avoid going stale static constexpr const std::chrono::nanoseconds kStaleTimeout = 80ms; }; @@ -551,7 +551,7 @@ const bool AidlPowerHalWrapper::sTraceHintSessionData = base::GetBoolProperty(std::string("debug.sf.trace_hint_sessions"), false); const bool AidlPowerHalWrapper::sNormalizeTarget = - base::GetBoolProperty(std::string("debug.sf.normalize_hint_session_durations"), true); + base::GetBoolProperty(std::string("debug.sf.normalize_hint_session_durations"), false); PowerAdvisor::HalWrapper* PowerAdvisor::getPowerHal() { static std::unique_ptr<HalWrapper> sHalWrapper = nullptr; diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 2edc05bc08..89594f22cb 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -721,15 +721,15 @@ void SurfaceFlinger::bootFinished() { } readPersistentProperties(); - std::optional<pid_t> renderEngineTid = getRenderEngine().getRenderEngineTid(); - std::vector<int32_t> tidList; - tidList.emplace_back(gettid()); - if (renderEngineTid.has_value()) { - tidList.emplace_back(*renderEngineTid); - } mPowerAdvisor.onBootFinished(); mPowerAdvisor.enablePowerHint(mFlagManager->use_adpf_cpu_hint()); if (mPowerAdvisor.usePowerHintSession()) { + std::optional<pid_t> renderEngineTid = getRenderEngine().getRenderEngineTid(); + std::vector<int32_t> tidList; + tidList.emplace_back(gettid()); + if (renderEngineTid.has_value()) { + tidList.emplace_back(*renderEngineTid); + } mPowerAdvisor.startPowerHintSession(tidList); } @@ -3729,8 +3729,8 @@ int SurfaceFlinger::flushPendingTransactionQueues( break; } transaction.traverseStatesWithBuffers([&](const layer_state_t& state) { - const bool frameNumberChanged = - state.bufferData->flags.test(BufferData::BufferDataChange::frameNumberChanged); + const bool frameNumberChanged = state.bufferData->flags.test( + BufferData::BufferDataChange::frameNumberChanged); if (frameNumberChanged) { bufferLayersReadyToPresent[state.surface] = state.bufferData->frameNumber; } else { @@ -3810,8 +3810,8 @@ bool SurfaceFlinger::flushTransactionQueues(int64_t vsyncId) { mPendingTransactionQueues[transaction.applyToken].push(std::move(transaction)); } else { transaction.traverseStatesWithBuffers([&](const layer_state_t& state) { - const bool frameNumberChanged = - state.bufferData->flags.test(BufferData::BufferDataChange::frameNumberChanged); + const bool frameNumberChanged = state.bufferData->flags.test( + BufferData::BufferDataChange::frameNumberChanged); if (frameNumberChanged) { bufferLayersReadyToPresent[state.surface] = state.bufferData->frameNumber; } else { @@ -3820,7 +3820,7 @@ bool SurfaceFlinger::flushTransactionQueues(int64_t vsyncId) { bufferLayersReadyToPresent[state.surface] = std::numeric_limits<uint64_t>::max(); } - }); + }); transactions.emplace_back(std::move(transaction)); } mTransactionQueue.pop_front(); |