summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jiyong Park <jiyong@google.com> 2023-02-06 14:01:09 +0900
committer Jiyong Park <jiyong@google.com> 2023-02-06 14:12:12 +0900
commit97c922710018c10e61cc8b6e0c64e9255e11afbc (patch)
treefbdb712054ad3d6ff874dab5f23fde61526e9585
parent2d50087557ca563cdc111b3fcb2e46c13d85b448 (diff)
Early crash of servicemanager shouldn't start apexd
If servicemanager crashes when apexd isn't started yet, apexd shouldn't be started. Otherwise, apexd will start much earlier than it is supposed to be. It can cause various issues because apexd has many assumptions around it (like some directories must have been created, etc.). Adding `--only-if-running` ensures that. Bug: N/A Test: inject an error in servicemanager and see if apexd is not started upon the servicemanager crash Change-Id: I0b20a31115aaf7607cc0340e02183871e60d4178
-rw-r--r--cmds/servicemanager/servicemanager.rc2
1 files changed, 1 insertions, 1 deletions
diff --git a/cmds/servicemanager/servicemanager.rc b/cmds/servicemanager/servicemanager.rc
index 3bd6db5ef6..4f92b3a374 100644
--- a/cmds/servicemanager/servicemanager.rc
+++ b/cmds/servicemanager/servicemanager.rc
@@ -5,7 +5,7 @@ service servicemanager /system/bin/servicemanager
critical
file /dev/kmsg w
onrestart setprop servicemanager.ready false
- onrestart restart apexd
+ onrestart restart --only-if-running apexd
onrestart restart audioserver
onrestart restart gatekeeperd
onrestart class_restart --only-enabled main