summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Yiwei Zhang <zzyiwei@google.com> 2020-11-12 20:23:00 +0000
committer Yiwei Zhang <zzyiwei@google.com> 2020-11-13 17:45:15 +0000
commit9058b8fe8c00609768a828e3e1476d7f24754fed (patch)
treee5ae32ff7ce03b5e0953dd019e8a63e4416c1b70
parentd7c0aa947c9c1adc70b35d649b3b3222ea75b49b (diff)
Vulkan/OpenGL: log dlerror for loading updatable gfx driver
Test: build Change-Id: Ifcb57266f5d93767ba911f70695e0bbbeace98e6
-rw-r--r--libs/graphicsenv/GraphicsEnv.cpp2
-rw-r--r--opengl/libs/EGL/Loader.cpp2
-rw-r--r--vulkan/libvulkan/driver.cpp2
3 files changed, 5 insertions, 1 deletions
diff --git a/libs/graphicsenv/GraphicsEnv.cpp b/libs/graphicsenv/GraphicsEnv.cpp
index 55c5de9477..d54de4999c 100644
--- a/libs/graphicsenv/GraphicsEnv.cpp
+++ b/libs/graphicsenv/GraphicsEnv.cpp
@@ -548,7 +548,7 @@ void GraphicsEnv::setDebugLayersGLES(const std::string layers) {
}
// Return true if all the required libraries from vndk and sphal namespace are
-// linked to the Game Driver namespace correctly.
+// linked to the updatable gfx driver namespace correctly.
bool GraphicsEnv::linkDriverNamespaceLocked(android_namespace_t* vndkNamespace) {
const std::string llndkLibraries = getSystemNativeLibraries(NativeLibrary::LLNDK);
if (llndkLibraries.empty()) {
diff --git a/opengl/libs/EGL/Loader.cpp b/opengl/libs/EGL/Loader.cpp
index 1afc6934f6..76fd7f0f3f 100644
--- a/opengl/libs/EGL/Loader.cpp
+++ b/opengl/libs/EGL/Loader.cpp
@@ -514,6 +514,8 @@ static void* load_updated_driver(const char* kind, android_namespace_t* ns) {
if (so) {
return so;
}
+ ALOGE("Could not load %s from updatable gfx driver namespace: %s.", name.c_str(),
+ dlerror());
}
return nullptr;
}
diff --git a/vulkan/libvulkan/driver.cpp b/vulkan/libvulkan/driver.cpp
index 6f09a8c45b..d7fdab5586 100644
--- a/vulkan/libvulkan/driver.cpp
+++ b/vulkan/libvulkan/driver.cpp
@@ -183,6 +183,8 @@ int LoadDriver(android_namespace_t* library_namespace,
.library_namespace = library_namespace,
};
so = android_dlopen_ext(lib_name.c_str(), LIB_DL_FLAGS, &dlextinfo);
+ ALOGE("Could not load %s from updatable gfx driver namespace: %s.",
+ lib_name.c_str(), dlerror());
} else {
// load built-in driver
so = android_load_sphal_library(lib_name.c_str(), LIB_DL_FLAGS);