summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <treehugger-gerrit@google.com> 2019-12-09 17:27:59 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2019-12-09 17:27:59 +0000
commit8fc7c37cfd27b544cc625017f2de554b65fc4eb6 (patch)
tree2b6119e236ee3ede5b05ff938a86d68ec157a5d7
parent15d82e51f9c6257ebc0588ca8b314405c83a71f5 (diff)
parent42b60ba8a110d28c6a86bfff4b189f54896e818e (diff)
Merge "libui: use uint64_t in dump and getTotalSize to avoid overflow issues"
-rw-r--r--libs/ui/GraphicBufferAllocator.cpp6
-rw-r--r--libs/ui/include/ui/GraphicBufferAllocator.h2
2 files changed, 4 insertions, 4 deletions
diff --git a/libs/ui/GraphicBufferAllocator.cpp b/libs/ui/GraphicBufferAllocator.cpp
index f1aa89ca36..5f1c71ec4f 100644
--- a/libs/ui/GraphicBufferAllocator.cpp
+++ b/libs/ui/GraphicBufferAllocator.cpp
@@ -61,9 +61,9 @@ GraphicBufferAllocator::GraphicBufferAllocator() : mMapper(GraphicBufferMapper::
GraphicBufferAllocator::~GraphicBufferAllocator() {}
-size_t GraphicBufferAllocator::getTotalSize() const {
+uint64_t GraphicBufferAllocator::getTotalSize() const {
Mutex::Autolock _l(sLock);
- size_t total = 0;
+ uint64_t total = 0;
for (size_t i = 0; i < sAllocList.size(); ++i) {
total += sAllocList.valueAt(i).size;
}
@@ -73,7 +73,7 @@ size_t GraphicBufferAllocator::getTotalSize() const {
void GraphicBufferAllocator::dump(std::string& result) const {
Mutex::Autolock _l(sLock);
KeyedVector<buffer_handle_t, alloc_rec_t>& list(sAllocList);
- size_t total = 0;
+ uint64_t total = 0;
result.append("Allocated buffers:\n");
const size_t c = list.size();
for (size_t i=0 ; i<c ; i++) {
diff --git a/libs/ui/include/ui/GraphicBufferAllocator.h b/libs/ui/include/ui/GraphicBufferAllocator.h
index 25d4512859..faec97855a 100644
--- a/libs/ui/include/ui/GraphicBufferAllocator.h
+++ b/libs/ui/include/ui/GraphicBufferAllocator.h
@@ -49,7 +49,7 @@ public:
status_t free(buffer_handle_t handle);
- size_t getTotalSize() const;
+ uint64_t getTotalSize() const;
void dump(std::string& res) const;
static void dumpToSystemLog();