summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Narayan Kamath <narayan@google.com> 2019-01-04 15:09:51 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2019-01-04 15:09:51 +0000
commit8f3776a7ace3d5c7bd4832367c495f63825a51b1 (patch)
treece221ba5ca8ee93f7800644404a056175469b204
parent6d1dc6eab1e35df3d4d36766fef76f1c777258e8 (diff)
parent92c7d70d7ce9ca5bae4686d415267802bd69be85 (diff)
Merge "dumpstate: Improve error message for failed dumps."
-rw-r--r--cmds/dumpstate/utils.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/cmds/dumpstate/utils.cpp b/cmds/dumpstate/utils.cpp
index d97ffbf2ed..990fd43fd4 100644
--- a/cmds/dumpstate/utils.cpp
+++ b/cmds/dumpstate/utils.cpp
@@ -871,7 +871,11 @@ const char* dump_traces() {
is_java_process ? 5 : 20, fd);
if (ret == -1) {
- dprintf(fd, "dumping failed, likely due to a timeout\n");
+ // For consistency, the header and footer to this message match those
+ // dumped by debuggerd in the success case.
+ dprintf(fd, "\n---- pid %d at [unknown] ----\n", pid);
+ dprintf(fd, "Dump failed, likely due to a timeout.\n");
+ dprintf(fd, "---- end %d ----", pid);
timeout_failures++;
continue;
}