diff options
| author | 2017-04-06 15:29:57 -0700 | |
|---|---|---|
| committer | 2017-04-06 16:25:45 -0700 | |
| commit | 85fcaa2365c843b2c75d19aa16b15b9bb24c4968 (patch) | |
| tree | 67245915bd56f16f2fcff3bfc58cc59c26bed069 | |
| parent | 42b5469646974552d2de5b0e89c04ccda0d48159 (diff) | |
vr_hwc: Address ion buffer leakage
Problem:
system is running out of memory while switching between apps back and forth.
Root-cause:
vr_hwc is leaking ion buffers by holding an unreleased reference.
Solution:
No need to register the buffer when getting buffer info. This removes the
additional (unreleased) reference on the buffer.
Test: Validated vr_hwc is no longer leaking ion buffers when switching
apps.
Bug: 36449218
Change-Id: I1c1c5d2cca35c50a4bcbcf7b879d37914b8d835f
| -rw-r--r-- | services/vr/vr_window_manager/composer/impl/vr_hwc.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp b/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp index d142729d23..b5724ca714 100644 --- a/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp +++ b/services/vr/vr_window_manager/composer/impl/vr_hwc.cpp @@ -49,12 +49,6 @@ sp<GraphicBuffer> GetBufferFromHandle(const native_handle_t* handle) { int32_t format = 0; GraphicBufferMapper& mapper = GraphicBufferMapper::get(); - // Need to register |handle| otherwise we can't read its properties. - if (mapper.registerBuffer(handle) != OK) { - ALOGE("Failed to register buffer"); - return nullptr; - } - if (mapper.getDimensions(handle, &width, &height) || mapper.getStride(handle, &stride) || mapper.getFormat(handle, &format) || |