summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Steven Moreland <smoreland@google.com> 2021-05-11 17:28:22 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2021-05-11 17:28:22 +0000
commit75a9dc09754ce2a49c8aead9069bfa4fa69debb0 (patch)
tree5c7046b4d3efad7f84921526a6484bdb5952a62f
parent8155b0de079ac42a01b3b2eeb6dd462098ce5c83 (diff)
parent5cf70afccd66c33f8d41a855370eb5e93fc1eef9 (diff)
Merge "libbinder: RPC - add DOS TODO" am: a416e7b190 am: f9df1ab9f2 am: 5cf70afccd
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/1702013 Change-Id: Ie46b3dd0f002fb3e3bd7374c09205f86832bc9d2
-rw-r--r--libs/binder/RpcServer.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/libs/binder/RpcServer.cpp b/libs/binder/RpcServer.cpp
index a6850ff6aa..51c770e85d 100644
--- a/libs/binder/RpcServer.cpp
+++ b/libs/binder/RpcServer.cpp
@@ -134,7 +134,8 @@ void RpcServer::join() {
}
LOG_RPC_DETAIL("accept4 on fd %d yields fd %d", mServer.get(), clientFd.get());
- // TODO(b/183988761): cannot trust this simple ID
+ // TODO(b/183988761): cannot trust this simple ID, should not block this
+ // thread
LOG_ALWAYS_FATAL_IF(!mAgreedExperimental, "no!");
int32_t id;
if (sizeof(id) != read(clientFd.get(), &id, sizeof(id))) {