BufferHubProducer: don't check user_metadata_size

Now we are using canonical metadata for all BufferHubQueue, it's
actually wrong to enforce user_metadata_size.

Bug: 75962234
Bug: 77655695
Test: buffer_hub_queue-test, buffer_hub_queue_producer-test,
      SurfaceParcelable_test, dvr_buffer_queue-test, libgui_test
Change-Id: I6736ed277f7ac08d1f4a7288ce4a101bc89ca35b

5 files changed, 3 insertions, 13 deletions

diff --git a/libs/gui/BufferHubProducer.cpp b/libs/gui/BufferHubProducer.cpp
index 70321caa96..061710a1b4 100644
--- a/libs/gui/BufferHubProducer.cpp
+++ b/libs/gui/BufferHubProducer.cpp
@@ -26,12 +26,6 @@ using namespace dvr;
 
 /* static */
 sp<BufferHubProducer> BufferHubProducer::Create(const std::shared_ptr<ProducerQueue>& queue) {
-    if (queue->metadata_size() != sizeof(DvrNativeBufferMetadata)) {
-        ALOGE("BufferHubProducer::Create producer's metadata size is different "
-              "than the size of DvrNativeBufferMetadata");
-        return nullptr;
-    }
-
     sp<BufferHubProducer> producer = new BufferHubProducer;
     producer->queue_ = queue;
     return producer;
diff --git a/libs/gui/BufferQueue.cpp b/libs/gui/BufferQueue.cpp
index 198869075d..2917f45164 100644
--- a/libs/gui/BufferQueue.cpp
+++ b/libs/gui/BufferQueue.cpp
@@ -113,8 +113,7 @@ void BufferQueue::createBufferHubQueue(sp<IGraphicBufferProducer>* outProducer,
 
     dvr::ProducerQueueConfigBuilder configBuilder;
     std::shared_ptr<dvr::ProducerQueue> producerQueue =
-            dvr::ProducerQueue::Create(configBuilder.SetMetadata<DvrNativeBufferMetadata>().Build(),
-                                       dvr::UsagePolicy{});
+            dvr::ProducerQueue::Create(configBuilder.Build(), dvr::UsagePolicy{});
     LOG_ALWAYS_FATAL_IF(producerQueue == NULL, "BufferQueue: failed to create ProducerQueue.");
 
     std::shared_ptr<dvr::ConsumerQueue> consumerQueue = producerQueue->CreateConsumerQueue();
diff --git a/libs/gui/tests/SurfaceParcelable_test.cpp b/libs/gui/tests/SurfaceParcelable_test.cpp
index 99a8a7a591..686dc82f3e 100644
--- a/libs/gui/tests/SurfaceParcelable_test.cpp
+++ b/libs/gui/tests/SurfaceParcelable_test.cpp
@@ -49,7 +49,6 @@ public:
         mProducerQueue = dvr::ProducerQueue::Create(configBuilder.SetDefaultWidth(kBufferWidth)
                                                             .SetDefaultHeight(kBufferHeight)
                                                             .SetDefaultFormat(kBufferFormat)
-                                                            .SetMetadata<DvrNativeBufferMetadata>()
                                                             .Build(),
                                                     dvr::UsagePolicy{});
         mBufferHubProducer = BufferHubProducer::Create(mProducerQueue);
diff --git a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp
index 3e9698940c..4f10f83211 100644
--- a/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp
+++ b/libs/vr/libbufferhubqueue/tests/buffer_hub_queue_producer-test.cpp
@@ -94,9 +94,7 @@ class BufferHubQueueProducerTest : public ::testing::Test {
     ALOGD_IF(TRACE, "Begin test: %s.%s", testInfo->test_case_name(),
              testInfo->name());
 
-    auto config = ProducerQueueConfigBuilder()
-                      .SetMetadata<DvrNativeBufferMetadata>()
-                      .Build();
+    auto config = ProducerQueueConfigBuilder().Build();
     auto queue = ProducerQueue::Create(config, UsagePolicy{});
     ASSERT_TRUE(queue != nullptr);
 
diff --git a/libs/vr/libdvr/tests/dvr_buffer_queue-test.cpp b/libs/vr/libdvr/tests/dvr_buffer_queue-test.cpp
index 301458a546..5d9d8b5665 100644
--- a/libs/vr/libdvr/tests/dvr_buffer_queue-test.cpp
+++ b/libs/vr/libdvr/tests/dvr_buffer_queue-test.cpp
@@ -221,7 +221,7 @@ TEST_F(DvrBufferQueueTest, AcquirePostGainRelease) {
 TEST_F(DvrBufferQueueTest, GetANativeWindow) {
   int ret = api_.WriteBufferQueueCreate(
       kBufferWidth, kBufferHeight, kBufferFormat, kLayerCount, kBufferUsage,
-      /*capacity=*/0, sizeof(DvrNativeBufferMetadata), &write_queue_);
+      /*capacity=*/0, /*user_metadata_size=*/0, &write_queue_);
   ASSERT_EQ(0, ret);
   ASSERT_NE(nullptr, write_queue_);