diff options
| author | 2019-02-25 17:25:57 -0800 | |
|---|---|---|
| committer | 2019-02-25 17:26:29 -0800 | |
| commit | 51988ef2241b2dad4b115f22c35de69c2437995f (patch) | |
| tree | d40416b42e4ca7cdb0bc0fcceb4b8c522ea3bdfc | |
| parent | 447052e2f69efb01023dcc0dce230dd649f0475f (diff) | |
SurfaceFlinger: fix flakiness in IdleTimerTest
Increase the timeout of waiting for reset callback to avoid flakinessas
a result of poor scheduling.
Test: adb shell /data/nativetest64/libsurfaceflinger_unittest/libsurfaceflinger_unittest --gtest_filter=IdleTimerTest* --gtest_repeat=1000
Change-Id: Ib87aebab4474baaa6583b9481137a268fafed368
| -rw-r--r-- | services/surfaceflinger/tests/unittests/IdleTimerTest.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/services/surfaceflinger/tests/unittests/IdleTimerTest.cpp b/services/surfaceflinger/tests/unittests/IdleTimerTest.cpp index 5e82225dfa..ea39bf561b 100644 --- a/services/surfaceflinger/tests/unittests/IdleTimerTest.cpp +++ b/services/surfaceflinger/tests/unittests/IdleTimerTest.cpp @@ -140,7 +140,7 @@ TEST_F(IdleTimerTest, startNotCalledTest) { mExpiredTimerCallback.getInvocable()); // The start hasn't happened, so the callback does not happen. EXPECT_FALSE(mExpiredTimerCallback.waitForCall(waitTimeForUnexpected3msCallback).has_value()); - EXPECT_FALSE(mResetTimerCallback.waitForCall(1us).has_value()); + EXPECT_FALSE(mResetTimerCallback.waitForCall().has_value()); mIdleTimer->stop(); // Final quick check that no more callback were observed. EXPECT_FALSE(mExpiredTimerCallback.waitForCall(0ms).has_value()); @@ -159,7 +159,7 @@ TEST_F(IdleTimerTest, idleTimerIdlesTest) { EXPECT_FALSE(mExpiredTimerCallback.waitForCall(waitTimeForUnexpected3msCallback).has_value()); // Once reset, it should generate another mIdleTimer->reset(); - EXPECT_TRUE(mResetTimerCallback.waitForCall(1ms).has_value()); + EXPECT_TRUE(mResetTimerCallback.waitForCall().has_value()); EXPECT_TRUE(mExpiredTimerCallback.waitForCall(waitTimeForExpected3msCallback).has_value()); mIdleTimer->stop(); // Final quick check that no more callback were observed. @@ -171,7 +171,7 @@ TEST_F(IdleTimerTest, timeoutCallbackExecutionTest) { mIdleTimer = std::make_unique<scheduler::IdleTimer>(3ms, mResetTimerCallback.getInvocable(), mExpiredTimerCallback.getInvocable()); mIdleTimer->start(); - EXPECT_TRUE(mResetTimerCallback.waitForCall(1us).has_value()); + EXPECT_TRUE(mResetTimerCallback.waitForCall().has_value()); EXPECT_TRUE(mExpiredTimerCallback.waitForCall(waitTimeForExpected3msCallback).has_value()); mIdleTimer->stop(); } @@ -180,21 +180,21 @@ TEST_F(IdleTimerTest, noCallbacksAfterStopAndResetTest) { mIdleTimer = std::make_unique<scheduler::IdleTimer>(3ms, mResetTimerCallback.getInvocable(), mExpiredTimerCallback.getInvocable()); mIdleTimer->start(); - EXPECT_TRUE(mResetTimerCallback.waitForCall(1ms).has_value()); + EXPECT_TRUE(mResetTimerCallback.waitForCall().has_value()); EXPECT_TRUE(mExpiredTimerCallback.waitForCall(waitTimeForExpected3msCallback).has_value()); mIdleTimer->stop(); clearPendingCallbacks(); mIdleTimer->reset(); EXPECT_FALSE(mExpiredTimerCallback.waitForCall(waitTimeForUnexpected3msCallback).has_value()); - EXPECT_FALSE(mResetTimerCallback.waitForCall(1ms).has_value()); + EXPECT_FALSE(mResetTimerCallback.waitForCall().has_value()); } TEST_F(IdleTimerTest, noCallbacksAfterStopTest) { mIdleTimer = std::make_unique<scheduler::IdleTimer>(3ms, mResetTimerCallback.getInvocable(), mExpiredTimerCallback.getInvocable()); mIdleTimer->start(); - EXPECT_TRUE(mResetTimerCallback.waitForCall(1ms).has_value()); + EXPECT_TRUE(mResetTimerCallback.waitForCall().has_value()); mIdleTimer->stop(); clearPendingCallbacks(); @@ -202,7 +202,7 @@ TEST_F(IdleTimerTest, noCallbacksAfterStopTest) { // No more idle events should be observed EXPECT_FALSE(mExpiredTimerCallback.waitForCall(waitTimeForUnexpected3msCallback).has_value()); - EXPECT_FALSE(mResetTimerCallback.waitForCall(1ms).has_value()); + EXPECT_FALSE(mResetTimerCallback.waitForCall().has_value()); } } // namespace |