summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Tomasz Wasilczyk <twasilczyk@google.com> 2023-10-07 03:22:38 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2023-10-07 03:22:38 +0000
commit4a8483fc30fe9c938f1a46ab23fc28d4d6222cd2 (patch)
tree7c32930cbcd2380df4db38b4134b5a2a8acdffd3
parentef03242b2165f36b96db1883c17f2277a5c6243f (diff)
parentd6f648d3fbe30f001bf3f6a8ffc9cf6d3b06b6ee (diff)
Merge "Add missing "override" annotations" into main am: 3b7bc1dd91 am: 8b63de41dd am: 0e2b254dc0 am: d6f648d3fb
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2645615 Change-Id: I125774f8a9964345d5c4db7a6e18a67b9cc80c49 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--libs/binder/RpcTransportRaw.cpp5
-rw-r--r--libs/binder/RpcTransportTls.cpp2
2 files changed, 4 insertions, 3 deletions
diff --git a/libs/binder/RpcTransportRaw.cpp b/libs/binder/RpcTransportRaw.cpp
index f3575cc7d8..ddbcb573b1 100644
--- a/libs/binder/RpcTransportRaw.cpp
+++ b/libs/binder/RpcTransportRaw.cpp
@@ -79,7 +79,7 @@ public:
altPoll);
}
- virtual bool isWaiting() { return mSocket.isInPollingState(); }
+ bool isWaiting() override { return mSocket.isInPollingState(); }
private:
android::RpcTransportFd mSocket;
@@ -88,7 +88,8 @@ private:
// RpcTransportCtx with TLS disabled.
class RpcTransportCtxRaw : public RpcTransportCtx {
public:
- std::unique_ptr<RpcTransport> newTransport(android::RpcTransportFd socket, FdTrigger*) const {
+ std::unique_ptr<RpcTransport> newTransport(android::RpcTransportFd socket,
+ FdTrigger*) const override {
return std::make_unique<RpcTransportRaw>(std::move(socket));
}
std::vector<uint8_t> getCertificate(RpcCertificateFormat) const override { return {}; }
diff --git a/libs/binder/RpcTransportTls.cpp b/libs/binder/RpcTransportTls.cpp
index 785f6ce2ce..efb09e9004 100644
--- a/libs/binder/RpcTransportTls.cpp
+++ b/libs/binder/RpcTransportTls.cpp
@@ -292,7 +292,7 @@ public:
const std::optional<android::base::function_ref<status_t()>>& altPoll,
std::vector<std::variant<base::unique_fd, base::borrowed_fd>>* ancillaryFds) override;
- bool isWaiting() { return mSocket.isInPollingState(); };
+ bool isWaiting() override { return mSocket.isInPollingState(); };
private:
android::RpcTransportFd mSocket;