diff options
| author | 2022-07-08 19:08:48 +0800 | |
|---|---|---|
| committer | 2022-07-09 12:50:15 +0800 | |
| commit | 440cf722a94cabafd177330df5dd15520eed65ae (patch) | |
| tree | 9e25b5f194d2eb55812457b6978419b80256c7ab | |
| parent | 09ba064c131cf6e9fb92bbd02b912867e6b8517d (diff) | |
Rename gpu_mem.o to gpuMem.o
Underscore character may cause bpf prog/map naming collision. For
example, x.o with map y_z and x_y.o with map z both result in x_y_z
prog/map name, which should be prevented during compile-time.
aosp/2147825 will prohibit underscore character in bpf source name
(source name derives the obj name). Existing bpf modules with underscore
characters in source name need to be updated accordingly.
Bug: 236706995
Test: adb root; adb shell ls -l /sys/fs/bpf/ | grep gpuMem
Change-Id: I34e7a786d88fec1bd4dc0e3fe322fd46b3876bc5
| -rw-r--r-- | services/gpuservice/Android.bp | 2 | ||||
| -rw-r--r-- | services/gpuservice/CleanSpec.mk | 10 | ||||
| -rw-r--r-- | services/gpuservice/bpfprogs/Android.bp | 4 | ||||
| -rw-r--r-- | services/gpuservice/bpfprogs/gpuMem.c (renamed from services/gpuservice/bpfprogs/gpu_mem.c) | 0 | ||||
| -rw-r--r-- | services/gpuservice/gpumem/include/gpumem/GpuMem.h | 4 | ||||
| -rw-r--r-- | services/gpuservice/tests/unittests/GpuMemTest.cpp | 4 |
6 files changed, 12 insertions, 12 deletions
diff --git a/services/gpuservice/Android.bp b/services/gpuservice/Android.bp index b9b6a19606..0411b31234 100644 --- a/services/gpuservice/Android.bp +++ b/services/gpuservice/Android.bp @@ -98,7 +98,7 @@ cc_binary { init_rc: ["gpuservice.rc"], required: [ "bpfloader", - "gpu_mem.o", + "gpuMem.o", ], srcs: [":gpuservice_binary_sources"], shared_libs: [ diff --git a/services/gpuservice/CleanSpec.mk b/services/gpuservice/CleanSpec.mk index 482fc6dfc3..c51f6aa5f0 100644 --- a/services/gpuservice/CleanSpec.mk +++ b/services/gpuservice/CleanSpec.mk @@ -44,9 +44,9 @@ #$(call add-clean-step, find $(OUT_DIR) -type f -name "IGTalkSession*" -print0 | xargs -0 rm -f) #$(call add-clean-step, rm -rf $(PRODUCT_OUT)/data/*) -# Remove gpu_mem.o +# Remove gpuMem.o $(call add-clean-step, rm -rf $(OUT_DIR)/soong/.intermediates/frameworks/native/services/gpuservice/bpf) -$(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/FAKE/gpu_mem.o_intermediates) -$(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/ETC/gpu_mem.o_gpu_mem.o_intermediates) -$(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/etc/bpf/gpu_mem.o) -$(call add-clean-step, rm -rf $(PRODUCT_OUT)/fake_packages/gpu_mem.o-timestamp) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/FAKE/gpuMem.o_intermediates) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/obj/ETC/gpuMem.o_gpuMem.o_intermediates) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/system/etc/bpf/gpuMem.o) +$(call add-clean-step, rm -rf $(PRODUCT_OUT)/fake_packages/gpuMem.o-timestamp) diff --git a/services/gpuservice/bpfprogs/Android.bp b/services/gpuservice/bpfprogs/Android.bp index 076affda5a..680b291fe3 100644 --- a/services/gpuservice/bpfprogs/Android.bp +++ b/services/gpuservice/bpfprogs/Android.bp @@ -22,8 +22,8 @@ package { } bpf { - name: "gpu_mem.o", - srcs: ["gpu_mem.c"], + name: "gpuMem.o", + srcs: ["gpuMem.c"], btf: true, cflags: [ "-Wall", diff --git a/services/gpuservice/bpfprogs/gpu_mem.c b/services/gpuservice/bpfprogs/gpuMem.c index 16e1e8a1ef..16e1e8a1ef 100644 --- a/services/gpuservice/bpfprogs/gpu_mem.c +++ b/services/gpuservice/bpfprogs/gpuMem.c diff --git a/services/gpuservice/gpumem/include/gpumem/GpuMem.h b/services/gpuservice/gpumem/include/gpumem/GpuMem.h index de691e2b75..7588b54818 100644 --- a/services/gpuservice/gpumem/include/gpumem/GpuMem.h +++ b/services/gpuservice/gpumem/include/gpumem/GpuMem.h @@ -57,9 +57,9 @@ private: static constexpr char kGpuMemTotalTracepoint[] = "gpu_mem_total"; // pinned gpu memory total bpf c program path in bpf sysfs static constexpr char kGpuMemTotalProgPath[] = - "/sys/fs/bpf/prog_gpu_mem_tracepoint_gpu_mem_gpu_mem_total"; + "/sys/fs/bpf/prog_gpuMem_tracepoint_gpu_mem_gpu_mem_total"; // pinned gpu memory total bpf map path in bpf sysfs - static constexpr char kGpuMemTotalMapPath[] = "/sys/fs/bpf/map_gpu_mem_gpu_mem_total_map"; + static constexpr char kGpuMemTotalMapPath[] = "/sys/fs/bpf/map_gpuMem_gpu_mem_total_map"; // 30 seconds timeout for trying to attach bpf program to tracepoint static constexpr int kGpuWaitTimeout = 30; }; diff --git a/services/gpuservice/tests/unittests/GpuMemTest.cpp b/services/gpuservice/tests/unittests/GpuMemTest.cpp index 36ae179ab7..8dabe4fbdb 100644 --- a/services/gpuservice/tests/unittests/GpuMemTest.cpp +++ b/services/gpuservice/tests/unittests/GpuMemTest.cpp @@ -90,8 +90,8 @@ TEST_F(GpuMemTest, validGpuMemTotalBpfPaths) { EXPECT_EQ(mTestableGpuMem.getGpuMemTraceGroup(), "gpu_mem"); EXPECT_EQ(mTestableGpuMem.getGpuMemTotalTracepoint(), "gpu_mem_total"); EXPECT_EQ(mTestableGpuMem.getGpuMemTotalProgPath(), - "/sys/fs/bpf/prog_gpu_mem_tracepoint_gpu_mem_gpu_mem_total"); - EXPECT_EQ(mTestableGpuMem.getGpuMemTotalMapPath(), "/sys/fs/bpf/map_gpu_mem_gpu_mem_total_map"); + "/sys/fs/bpf/prog_gpuMem_tracepoint_gpu_mem_gpu_mem_total"); + EXPECT_EQ(mTestableGpuMem.getGpuMemTotalMapPath(), "/sys/fs/bpf/map_gpuMem_gpu_mem_total_map"); } TEST_F(GpuMemTest, bpfInitializationFailed) { |