summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kalle Raita <kraita@google.com> 2016-11-19 01:07:56 +0000
committer Android (Google) Code Review <android-gerrit@google.com> 2016-11-19 01:07:56 +0000
commit41d2fdbf24cd5c3950aadb078b4d9dee90bcbdb9 (patch)
tree99a6f2a6a1a0767c4d17fa5e4849e3f64bb6788d
parentdf02bffc32c2c89ee3d9955bb7beb2c408227fbf (diff)
parent454c92e07e7248b6d41c547842031ae37b053950 (diff)
Merge "Switch from deprecated tempnam to TemporaryFile"
-rw-r--r--opengl/tests/EGLTest/Android.mk1
-rw-r--r--opengl/tests/EGLTest/egl_cache_test.cpp15
2 files changed, 9 insertions, 7 deletions
diff --git a/opengl/tests/EGLTest/Android.mk b/opengl/tests/EGLTest/Android.mk
index 80e4867b2e..b7724509b2 100644
--- a/opengl/tests/EGLTest/Android.mk
+++ b/opengl/tests/EGLTest/Android.mk
@@ -17,6 +17,7 @@ LOCAL_SHARED_LIBRARIES := \
libbinder \
libutils \
libgui \
+ libbase \
LOCAL_C_INCLUDES := \
bionic/libc/private \
diff --git a/opengl/tests/EGLTest/egl_cache_test.cpp b/opengl/tests/EGLTest/egl_cache_test.cpp
index c5bf296e49..c974f63c13 100644
--- a/opengl/tests/EGLTest/egl_cache_test.cpp
+++ b/opengl/tests/EGLTest/egl_cache_test.cpp
@@ -21,9 +21,13 @@
#include <utils/Log.h>
+#include <android-base/test_utils.h>
+
#include "egl_cache.h"
#include "egl_display.h"
+#include <memory>
+
namespace android {
class EGLCacheTest : public ::testing::Test {
@@ -79,23 +83,20 @@ protected:
virtual void SetUp() {
EGLCacheTest::SetUp();
-
- char* tn = tempnam("/sdcard", "EGL_test-cache-");
- mFilename = tn;
- free(tn);
+ mTempFile.reset(new TemporaryFile());
}
virtual void TearDown() {
- unlink(mFilename.string());
+ mTempFile.reset(nullptr);
EGLCacheTest::TearDown();
}
- String8 mFilename;
+ std::unique_ptr<TemporaryFile> mTempFile;
};
TEST_F(EGLCacheSerializationTest, ReinitializedCacheContainsValues) {
uint8_t buf[4] = { 0xee, 0xee, 0xee, 0xee };
- mCache->setCacheFilename(mFilename);
+ mCache->setCacheFilename(&mTempFile->path[0]);
mCache->initialize(egl_display_t::get(EGL_DEFAULT_DISPLAY));
mCache->setBlob("abcd", 4, "efgh", 4);
mCache->terminate();