From 2f5dd12af0c78ba077a9dc2b9cf77b772b618cd1 Mon Sep 17 00:00:00 2001 From: Anton Hansson Date: Fri, 23 Nov 2018 15:21:20 +0000 Subject: Add linter for strings attribute names Only one bad example for now, which is a misspelling that's not entirely uncommon and can lead to real problems (see linked bug). Example output: Line 58: 'my_new': Misspelled attribute. Actual: translateable Example: translatable Bug: 119884572 Test: with a misspelled attribute Change-Id: If61412fe318a34191920781c4834584363080e11 --- tools/stringslint/stringslint.py | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'tools/stringslint/stringslint.py') diff --git a/tools/stringslint/stringslint.py b/tools/stringslint/stringslint.py index 03c0b9af66a0..afe91cda37b0 100644 --- a/tools/stringslint/stringslint.py +++ b/tools/stringslint/stringslint.py @@ -145,6 +145,13 @@ def lint(path): if "translatable" in child.attrib and child.attrib["translatable"].lower() == "false": continue + misspelled_attributes = [ + ("translateable", "translatable"), + ] + for misspelling, expected in misspelled_attributes: + if misspelling in child.attrib: + error(child, "Misspelled attribute.", misspelling, expected) + limit = re.search("CHAR[ _-]LIMIT=(\d+|NONE|none)", comment.text) if limit is None: info(child, "Missing CHAR LIMIT to aid translation", -- cgit v1.2.3-59-g8ed1b