From d336704eae2fe533e2c9dcd3c56ee687b0c41a85 Mon Sep 17 00:00:00 2001 From: Winson Date: Wed, 28 Jul 2021 15:50:47 -0700 Subject: Add generic import support for Codegen Supports any kind of DataClass or NonNull-type annotations instead of enforcing the Android framework package. Bug: 195012034 Test: manual, generate for DomainVerificationInfo, verify no change Test: manual, generate for mainline class, verify no internal import Change-Id: I0360281aa20b7f2c6e75dec88a92b810fa69b9b7 --- .../src/com/android/codegen/ImportsProvider.kt | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) (limited to 'tools/codegen/src') diff --git a/tools/codegen/src/com/android/codegen/ImportsProvider.kt b/tools/codegen/src/com/android/codegen/ImportsProvider.kt index 27dd9587db25..46df2739e59f 100644 --- a/tools/codegen/src/com/android/codegen/ImportsProvider.kt +++ b/tools/codegen/src/com/android/codegen/ImportsProvider.kt @@ -53,10 +53,25 @@ interface ImportsProvider { * Optionally shortens a class reference if there's a corresponding import present */ fun classRef(fullName: String): String { - val pkg = fullName.substringBeforeLast(".") val simpleName = fullName.substringAfterLast(".") - if (fileAst.imports.any { imprt -> + val imports = fileAst.imports + + // If an import of the same class name is available, + // use it instead of the internal Android package variants. + if (fullName.startsWith("com.android.internal.util.") + && imports.any { + it.nameAsString.endsWith(fullName.removePrefix("com.android.internal.util.")) + } + ) { + return fullName.removePrefix("com.android.internal.util.") + } else if (fullName.startsWith("android.annotation") + && imports.any { it.nameAsString.endsWith(simpleName) } + ) { + return simpleName + } + + if (imports.any { imprt -> imprt.nameAsString == fullName || (imprt.isAsterisk && imprt.nameAsString == pkg) }) { @@ -89,4 +104,4 @@ interface ImportsProvider { /** @see classRef */ inline fun ImportsProvider.classRef(): String { return classRef(T::class.java.name) -} \ No newline at end of file +} -- cgit v1.2.3-59-g8ed1b