From f2ef6579f2fe70ddca7fa3d443b3780d0264eb88 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Tue, 11 Feb 2020 14:27:11 -0800 Subject: Fix clang-tidy performance-faster-string-find warnings Bug: 30411878 Test: build with WITH_TIDY=1 Change-Id: I7fd815aa401fbcaff97b772f3ba5d6f1d2034011 --- tools/aapt2/dump/DumpManifest.cpp | 4 ++-- tools/aapt2/java/ManifestClassGenerator.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'tools/aapt2') diff --git a/tools/aapt2/dump/DumpManifest.cpp b/tools/aapt2/dump/DumpManifest.cpp index 92f1ddb292e1..42a64716701d 100644 --- a/tools/aapt2/dump/DumpManifest.cpp +++ b/tools/aapt2/dump/DumpManifest.cpp @@ -1175,7 +1175,7 @@ class Activity : public ManifestExtractor::Element { } // Fully qualify the activity name - ssize_t idx = name.find("."); + ssize_t idx = name.find('.'); if (idx == 0) { name = package + name; } else if (idx < 0) { @@ -2125,7 +2125,7 @@ bool ManifestExtractor::Dump(text::Printer* printer, IDiagnostics* diag) { size_t pos = file_path.find("lib/"); if (pos != std::string::npos) { file_path = file_path.substr(pos + 4); - pos = file_path.find("/"); + pos = file_path.find('/'); if (pos != std::string::npos) { file_path = file_path.substr(0, pos); } diff --git a/tools/aapt2/java/ManifestClassGenerator.cpp b/tools/aapt2/java/ManifestClassGenerator.cpp index 10e504ec0752..09ea03b23c9a 100644 --- a/tools/aapt2/java/ManifestClassGenerator.cpp +++ b/tools/aapt2/java/ManifestClassGenerator.cpp @@ -39,7 +39,7 @@ static Maybe ExtractJavaIdentifier(IDiagnostics* diag, const Source } // Normalize only the java identifier, leave the original value unchanged. - if (result.find("-") != std::string::npos) { + if (result.find('-') != std::string::npos) { result = JavaClassGenerator::TransformToFieldName(result); } -- cgit v1.2.3-59-g8ed1b