From 8bd37ba458633ee7b2aeec0a7593817000aa84b2 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 10 Aug 2016 14:15:30 -0700 Subject: Fix clang-tidy warnings in aapt and aapt2. * Add explicit keyword to conversion constructors. * Add NOLINT(implicit) comments for implicit conversion constructors. Bug: 28341362 * Use const reference type for read-only parameters. Bug: 30407689 * Use const reference type to avoid unnecessary copy. Bug: 30413862 Test: build with WITH_TIDY=1 Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1 Merged-In: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1 --- tools/aapt2/ManifestParser.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tools/aapt2/ManifestParser.cpp') diff --git a/tools/aapt2/ManifestParser.cpp b/tools/aapt2/ManifestParser.cpp index b8f0a430bcee..5b539c6a5d67 100644 --- a/tools/aapt2/ManifestParser.cpp +++ b/tools/aapt2/ManifestParser.cpp @@ -24,7 +24,7 @@ namespace aapt { -bool ManifestParser::parse(const Source& source, std::shared_ptr parser, +bool ManifestParser::parse(const Source& source, const std::shared_ptr& parser, AppInfo* outInfo) { SourceLogger logger = { source }; @@ -70,7 +70,7 @@ bool ManifestParser::parse(const Source& source, std::shared_ptr return true; } -bool ManifestParser::parseManifest(SourceLogger& logger, std::shared_ptr parser, +bool ManifestParser::parseManifest(SourceLogger& logger, const std::shared_ptr& parser, AppInfo* outInfo) { auto attrIter = parser->findAttribute(u"", u"package"); if (attrIter == parser->endAttributes() || attrIter->value.empty()) { -- cgit v1.2.3-59-g8ed1b