From 7c70cefcae2d6a096112d746ae72f515898a3f45 Mon Sep 17 00:00:00 2001 From: John Wang Date: Mon, 6 Feb 2012 13:58:26 -0800 Subject: Don't use SNR in the invalid check. Since some RILs use -1 instead of INVALID_SNR as invalid vlue for LTE SNR, SignalStrength will not use LTE SNR to check if LTE valid. bug:5970403 Change-Id: Ia948e076f8f5878e081e87680076b187857879c8 --- telephony/java/android/telephony/SignalStrength.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'telephony/java/android') diff --git a/telephony/java/android/telephony/SignalStrength.java b/telephony/java/android/telephony/SignalStrength.java index 1a4b574ce5dc..104966932ebe 100644 --- a/telephony/java/android/telephony/SignalStrength.java +++ b/telephony/java/android/telephony/SignalStrength.java @@ -293,10 +293,11 @@ public class SignalStrength implements Parcelable { int level; if (isGsm) { + // TODO Need solve the discrepancy of invalid values between + // RIL_LTE_SignalStrength and here. if ((mLteSignalStrength == -1) && (mLteRsrp == -1) && (mLteRsrq == -1) - && (mLteRssnr == INVALID_SNR) && (mLteCqi == -1)) { level = getGsmLevel(); } else { @@ -331,7 +332,6 @@ public class SignalStrength implements Parcelable { if ((mLteSignalStrength == -1) && (mLteRsrp == -1) && (mLteRsrq == -1) - && (mLteRssnr == INVALID_SNR) && (mLteCqi == -1)) { asuLevel = getGsmAsuLevel(); } else { @@ -367,7 +367,6 @@ public class SignalStrength implements Parcelable { if ((mLteSignalStrength == -1) && (mLteRsrp == -1) && (mLteRsrq == -1) - && (mLteRssnr == INVALID_SNR) && (mLteCqi == -1)) { dBm = getGsmDbm(); } else { -- cgit v1.2.3-59-g8ed1b