From 570260393ae5cd1c7a01715fc7f82e2af5e00fd8 Mon Sep 17 00:00:00 2001 From: Chiachang Wang Date: Fri, 10 Jan 2020 11:16:57 +0800 Subject: Add IpClientCallbacks.onNewDhcpResults(DhcpResultsParcelable) Add new callback to replace old one. Target to remove onNewDhcpResults(Dhcpresults). The previous onNewDhcpResults callback will be removed after clients are migrated. Bug: 135998869 Test: build Test: atest FrameworksNetTests NetworkStackTests Change-Id: Id6c72228560dc3c387755c27adacaa9aece6309a --- services/net/java/android/net/ip/IpClientCallbacks.java | 13 +++++++++++++ services/net/java/android/net/ip/IpClientUtil.java | 1 + 2 files changed, 14 insertions(+) (limited to 'services/net/java') diff --git a/services/net/java/android/net/ip/IpClientCallbacks.java b/services/net/java/android/net/ip/IpClientCallbacks.java index 61cd88aac921..c93e5c5e4759 100644 --- a/services/net/java/android/net/ip/IpClientCallbacks.java +++ b/services/net/java/android/net/ip/IpClientCallbacks.java @@ -17,6 +17,7 @@ package android.net.ip; import android.net.DhcpResults; +import android.net.DhcpResultsParcelable; import android.net.Layer2PacketParcelable; import android.net.LinkProperties; @@ -68,6 +69,18 @@ public class IpClientCallbacks { */ public void onNewDhcpResults(DhcpResults dhcpResults) {} + /** + * Callback called when new DHCP results are available. + * + *

This is purely advisory and not an indication of provisioning success or failure. This is + * only here for callers that want to expose DHCPv4 results to other APIs + * (e.g., WifiInfo#setInetAddress). + * + *

DHCPv4 or static IPv4 configuration failure or success can be determined by whether or not + * the passed-in DhcpResults object is null. + */ + public void onNewDhcpResults(DhcpResultsParcelable dhcpResults) {} + /** * Indicates that provisioning was successful. */ diff --git a/services/net/java/android/net/ip/IpClientUtil.java b/services/net/java/android/net/ip/IpClientUtil.java index 4d60e6239376..7f723b1c232b 100644 --- a/services/net/java/android/net/ip/IpClientUtil.java +++ b/services/net/java/android/net/ip/IpClientUtil.java @@ -119,6 +119,7 @@ public class IpClientUtil { @Override public void onNewDhcpResults(DhcpResultsParcelable dhcpResults) { mCb.onNewDhcpResults(fromStableParcelable(dhcpResults)); + mCb.onNewDhcpResults(dhcpResults); } @Override -- cgit v1.2.3-59-g8ed1b