From 5e3f68d1a936201f03250bf6d53e97f83a780b41 Mon Sep 17 00:00:00 2001 From: Vaibhav Devmurari Date: Tue, 4 Mar 2025 18:35:54 +0000 Subject: (3/n) Remove usage of isKeyGestureSupported() from KeyGestureController isKeyGestureSupported is synchronous API that makes system server dependent on handler and can cause ANR if handlers misbehave. It was added as a stop gap for multi-key gestures that require some SysUI info like keyguard state, display state, etc, to decide if the key needs to be consumed or not at the start of the gesture. Test: atest KeygestureControllerTests Bug: 358569822 Bug: 383602794 Flag: EXEMPT refactor Change-Id: I14abee92ede63e57c4c0d92c3d0eb501bd14a3bd --- .../server/accessibility/AccessibilityManagerService.java | 9 --------- 1 file changed, 9 deletions(-) (limited to 'services/accessibility') diff --git a/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java b/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java index c49151dd5e30..573c591cb504 100644 --- a/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java +++ b/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java @@ -521,15 +521,6 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub @Nullable IBinder focusedToken) { return AccessibilityManagerService.this.handleKeyGestureEvent(event); } - - @Override - public boolean isKeyGestureSupported(int gestureType) { - return switch (gestureType) { - case KeyGestureEvent.KEY_GESTURE_TYPE_TOGGLE_MAGNIFICATION, - KeyGestureEvent.KEY_GESTURE_TYPE_ACTIVATE_SELECT_TO_SPEAK -> true; - default -> false; - }; - } }; @VisibleForTesting -- cgit v1.2.3-59-g8ed1b