From 0d61c4f89dc8ef75aab1e475b923aeaf0d891bef Mon Sep 17 00:00:00 2001 From: Abhijeet Kaur Date: Tue, 30 Jul 2019 11:33:01 +0100 Subject: Leave error handling the same as old workflow using dumpstate Removing the TODO as won't be working on improving error handling as part of this bug. Created another bug (b/138576498) to work on better error handling. Bug: 123617758 Bug: 127431371 Test: builds (only removing comment) Change-Id: I8a7fea416e9871909cfb3cc801232bff6056536e --- packages/Shell/src/com/android/shell/BugreportProgressService.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'packages/Shell/src') diff --git a/packages/Shell/src/com/android/shell/BugreportProgressService.java b/packages/Shell/src/com/android/shell/BugreportProgressService.java index c9bb83c0b986..0a71db96b368 100644 --- a/packages/Shell/src/com/android/shell/BugreportProgressService.java +++ b/packages/Shell/src/com/android/shell/BugreportProgressService.java @@ -365,8 +365,10 @@ public class BugreportProgressService extends Service { checkProgressUpdated(mInfo, (int) progress); } - // TODO(b/127431371): Add error code handling for bugreport API errors. - // Logging errors and removing progress notification for now. + /** + * Logs errors and stops the service on which this bugreport was running. + * Also stops progress notification (if any). + */ @Override public void onError(@BugreportErrorCode int errorCode) { stopProgress(mId); -- cgit v1.2.3-59-g8ed1b