From f5c06a171c6eb51c6c914540b36a8211036fe735 Mon Sep 17 00:00:00 2001 From: Prabir Pradhan Date: Mon, 24 Apr 2023 16:12:38 +0000 Subject: Clean up KeyEvent JNI APIs Directly return a KeyEvent from KeyEvent_toNative, and change the KeyEvent parameter from a pointer to a reference in KeyEvent_fromNative. Bug: 279927189 Bug: 245989146 Test: Presubmit Change-Id: I9c98700ea4645c6c4cb975fabfa25d1ff959bfc3 --- native/android/input.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'native/android/input.cpp') diff --git a/native/android/input.cpp b/native/android/input.cpp index 1bff97dfdada..64e8efeaa4e8 100644 --- a/native/android/input.cpp +++ b/native/android/input.cpp @@ -87,11 +87,8 @@ int64_t AKeyEvent_getDownTime(const AInputEvent* key_event) { const AInputEvent* AKeyEvent_fromJava(JNIEnv* env, jobject keyEvent) { std::unique_ptr event = std::make_unique(); - android::status_t ret = android::android_view_KeyEvent_toNative(env, keyEvent, event.get()); - if (ret == android::OK) { - return event.release(); - } - return nullptr; + *event = android::android_view_KeyEvent_toNative(env, keyEvent); + return event.release(); } int64_t AKeyEvent_getEventTime(const AInputEvent* key_event) { -- cgit v1.2.3-59-g8ed1b