From 43c34c8991e5d2a11296d9449b3348189df8f616 Mon Sep 17 00:00:00 2001 From: Arpit Singh Date: Wed, 21 Feb 2024 17:25:23 +0000 Subject: Use ScopedLocalRef in InputEvent jni function This CL updates some jni functions that manipulate Key and Motion events to use ScopedLocalRef instead of plain jobject for better life-cycle tracking. Test: presubmit Bug: 324375527 Change-Id: I154b0606d3c0912f0df7a890faf7246b575863f5 --- native/android/input.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'native/android/input.cpp') diff --git a/native/android/input.cpp b/native/android/input.cpp index 4708e69447ec..53699bc706ea 100644 --- a/native/android/input.cpp +++ b/native/android/input.cpp @@ -321,11 +321,13 @@ jobject AInputEvent_toJava(JNIEnv* env, const AInputEvent* aInputEvent) { case AINPUT_EVENT_TYPE_MOTION: return android::android_view_MotionEvent_obtainAsCopy(env, static_cast( - *aInputEvent)); + *aInputEvent)) + .release(); case AINPUT_EVENT_TYPE_KEY: return android::android_view_KeyEvent_obtainAsCopy(env, static_cast( - *aInputEvent)); + *aInputEvent)) + .release(); default: LOG_ALWAYS_FATAL("Unexpected event type %d in AInputEvent_toJava.", eventType); } -- cgit v1.2.3-59-g8ed1b