From 91f0d2d205a3348eb3ee1412f28e97eb307a2c1c Mon Sep 17 00:00:00 2001 From: Soonil Nagarkar Date: Fri, 22 Feb 2019 11:55:36 -0800 Subject: Remove cross process dump() call This call has never worked in testing, and adds a significant penalty to dumping LocationManagerService. Bug: 125313528 Test: manually Change-Id: Ia455578e2b941c5a0888abb79a13adc0bb55729a --- .../java/com/android/location/provider/LocationProviderBase.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'location/lib/java') diff --git a/location/lib/java/com/android/location/provider/LocationProviderBase.java b/location/lib/java/com/android/location/provider/LocationProviderBase.java index 7cd7207c26a0..fa113a8aa3ef 100644 --- a/location/lib/java/com/android/location/provider/LocationProviderBase.java +++ b/location/lib/java/com/android/location/provider/LocationProviderBase.java @@ -240,8 +240,10 @@ public abstract class LocationProviderBase { protected abstract void onSetRequest(ProviderRequestUnbundled request, WorkSource source); /** - * Dump debug information. + * @deprecated This callback will never be invoked on Android Q and above. This method may be + * removed in the future. Prefer to dump provider state via the containing service instead. */ + @Deprecated protected void onDump(FileDescriptor fd, PrintWriter pw, String[] args) {} /** @@ -336,10 +338,5 @@ public abstract class LocationProviderBase { public void sendExtraCommand(String command, Bundle extras) { onSendExtraCommand(command, extras); } - - @Override - public void dump(FileDescriptor fd, PrintWriter pw, String[] args) { - onDump(fd, pw, args); - } } } -- cgit v1.2.3-59-g8ed1b