From 02a19b14f879e96232db37f881f367eabfac0fe3 Mon Sep 17 00:00:00 2001
From: Maryam Dehaini <mdehaini@google.com>
Date: Tue, 18 Mar 2025 14:16:44 -0700
Subject: Fix caption visibility for car window decoration

Test: open apps with and without caption visible
Bug: 375252977
Bug: 404642416
Flag: com.android.window.flags.enable_desktop_app_handle_animation
Change-Id: I51dc76737803898c2ebf728380a18bc82bc282a8
---
 .../wm/shell/windowdecor/CarWindowDecoration.java     | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

(limited to 'libs')

diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/CarWindowDecoration.java b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/CarWindowDecoration.java
index f6acca95916f..dc1b94e80ed7 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/CarWindowDecoration.java
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/CarWindowDecoration.java
@@ -89,9 +89,6 @@ public class CarWindowDecoration extends WindowDecoration<WindowDecorLinearLayou
         updateRelayoutParams(mRelayoutParams, taskInfo, isCaptionVisible);
 
         relayout(mRelayoutParams, startT, finishT, wct, mRootView, mResult);
-        if (DesktopModeFlags.ENABLE_DESKTOP_APP_HANDLE_ANIMATION.isTrue()) {
-            setCaptionVisibility(isCaptionVisible);
-        }
         // After this line, mTaskInfo is up-to-date and should be used instead of taskInfo
         mBgExecutor.execute(() -> mTaskOrganizer.applyTransaction(wct));
 
@@ -100,19 +97,23 @@ public class CarWindowDecoration extends WindowDecoration<WindowDecorLinearLayou
             // Nothing is set up in this case including the decoration surface.
             return;
         }
+
         if (mRootView != mResult.mRootView) {
             mRootView = mResult.mRootView;
             setupRootView(mResult.mRootView, mClickListener);
         }
-    }
 
-    private void setCaptionVisibility(boolean visible) {
-        if (mRootView == null) {
-            return;
+        if (DesktopModeFlags.ENABLE_DESKTOP_APP_HANDLE_ANIMATION.isTrue()) {
+            setCaptionVisibility(mRootView, mRelayoutParams.mIsCaptionVisible);
         }
+    }
+
+    private void setCaptionVisibility(@NonNull View rootView, boolean visible) {
         final int v = visible ? View.VISIBLE : View.GONE;
-        final View captionView = mRootView.findViewById(getCaptionViewId());
-        captionView.setVisibility(v);
+        final View captionView = rootView.findViewById(getCaptionViewId());
+        if (captionView != null) {
+            captionView.setVisibility(v);
+        }
     }
 
     @Override
-- 
cgit v1.2.3-59-g8ed1b