From 1bf1f8df178170ee3d4224f3c92a1b724d783178 Mon Sep 17 00:00:00 2001 From: Stephen Hines Date: Tue, 1 Mar 2011 17:34:59 -0800 Subject: DO NOT MERGE: Almost all warnings are now errors in RS build. Change-Id: Ie4952cdf5c75bf1b7a7899a32b3b1f8747686356 --- libs/rs/Android.mk | 3 +++ libs/rs/rsAllocation.cpp | 4 ++-- libs/rs/rsContext.cpp | 2 +- libs/rs/rsHandcode.h | 1 - libs/rs/rsScript.cpp | 1 - libs/rs/rsScriptC_Lib.cpp | 2 ++ libs/rs/rsScriptC_LibCL.cpp | 2 ++ libs/rs/rsScriptC_LibGL.cpp | 2 ++ 8 files changed, 12 insertions(+), 5 deletions(-) (limited to 'libs/rs') diff --git a/libs/rs/Android.mk b/libs/rs/Android.mk index 5ab4804b69e3..083688771dac 100644 --- a/libs/rs/Android.mk +++ b/libs/rs/Android.mk @@ -124,6 +124,8 @@ LOCAL_STATIC_LIBRARIES := libdex libft2 LOCAL_C_INCLUDES += external/freetype/include external/zlib dalvik LOCAL_C_INCLUDES += frameworks/compile/libbcc/include +LOCAL_CFLAGS += -Werror -Wall -Wno-unused-parameter -Wno-unused-variable + LOCAL_LDLIBS := -lpthread -ldl LOCAL_MODULE:= libRS LOCAL_MODULE_TAGS := optional @@ -132,6 +134,7 @@ include $(BUILD_SHARED_LIBRARY) # Now build a host version for serialization include $(CLEAR_VARS) +LOCAL_CFLAGS += -Werror -Wall -Wno-unused-parameter -Wno-unused-variable LOCAL_CFLAGS += -DANDROID_RS_SERIALIZE LOCAL_SRC_FILES:= \ diff --git a/libs/rs/rsAllocation.cpp b/libs/rs/rsAllocation.cpp index 54dcbcbefc30..ec03a158871f 100644 --- a/libs/rs/rsAllocation.cpp +++ b/libs/rs/rsAllocation.cpp @@ -21,8 +21,6 @@ #include #endif //ANDROID_RS_SERIALIZE -static void rsaAllocationGenerateScriptMips(RsContext con, RsAllocation va); - using namespace android; using namespace android::renderscript; @@ -602,6 +600,8 @@ void Allocation::resize2D(Context *rsc, uint32_t dimX, uint32_t dimY) { // #ifndef ANDROID_RS_SERIALIZE +static void rsaAllocationGenerateScriptMips(RsContext con, RsAllocation va); + namespace android { namespace renderscript { diff --git a/libs/rs/rsContext.cpp b/libs/rs/rsContext.cpp index 2e6ea1243d9c..4a5620d098fc 100644 --- a/libs/rs/rsContext.cpp +++ b/libs/rs/rsContext.cpp @@ -741,7 +741,7 @@ Context::~Context() { mWorkers.mLaunchSignals[ct].set(); } for (uint32_t ct = 0; ct < mWorkers.mCount; ct++) { - int status = pthread_join(mWorkers.mThreadId[ct], &res); + status = pthread_join(mWorkers.mThreadId[ct], &res); } rsAssert(!mWorkers.mRunningCount); diff --git a/libs/rs/rsHandcode.h b/libs/rs/rsHandcode.h index 6f21a35c5505..57da10a65b1f 100644 --- a/libs/rs/rsHandcode.h +++ b/libs/rs/rsHandcode.h @@ -4,7 +4,6 @@ static inline void rsHCAPI_ContextFinish (RsContext rsc) { ThreadIO *io = &((Context *)rsc)->mIO; uint32_t size = sizeof(RS_CMD_ContextFinish); - RS_CMD_ContextFinish *cmd = static_cast(io->mToCore.reserve(size)); io->mToCore.commitSync(RS_CMD_ID_ContextFinish, size); } diff --git a/libs/rs/rsScript.cpp b/libs/rs/rsScript.cpp index 9ada9c299ac4..afee2a314809 100644 --- a/libs/rs/rsScript.cpp +++ b/libs/rs/rsScript.cpp @@ -139,7 +139,6 @@ void rsi_ScriptSetVarD(Context *rsc, RsScript vs, uint32_t slot, double value) { } void rsi_ScriptSetVarV(Context *rsc, RsScript vs, uint32_t slot, const void *data, uint32_t len) { - const float *fp = (const float *)data; Script *s = static_cast