From 32f05e343c5ffb17f3235942bcda651bd3b9f1d6 Mon Sep 17 00:00:00 2001 From: Chris Craik Date: Tue, 17 Sep 2013 16:20:29 -0700 Subject: Conservatively estimate geometry bounds bug:10761696 Avoids a case where a rect with top coordinate of (e.g.) 0.51f is assumed to not draw in the first row of pixels, which leads to it not being clipped. Since rounding can cause it to render in this first pixel anyway, we very slightly expand geometry bounds. Now, in ambiguous cases, the geometry bounds are expanded so clipping is more likely to happen. Change-Id: I119b7c7720de07bac1634549724ffb63935567fc --- libs/hwui/Program.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libs/hwui/Program.cpp') diff --git a/libs/hwui/Program.cpp b/libs/hwui/Program.cpp index 9e4670e62dcd..7814a01ad929 100644 --- a/libs/hwui/Program.cpp +++ b/libs/hwui/Program.cpp @@ -20,6 +20,7 @@ #include #include "Program.h" +#include "Vertex.h" namespace android { namespace uirenderer { @@ -172,7 +173,7 @@ void Program::set(const mat4& projectionMatrix, const mat4& modelViewMatrix, // up and to the left. // This offset value is based on an assumption that some hardware may use as // little as 12.4 precision, so we offset by slightly more than 1/16. - p.translate(.065, .065); + p.translate(Vertex::gGeometryFudgeFactor, Vertex::gGeometryFudgeFactor); glUniformMatrix4fv(projection, 1, GL_FALSE, &p.data[0]); } mProjection = projectionMatrix; -- cgit v1.2.3-59-g8ed1b