From 906d47fd2bcedb9674b5765d01bd9c758069074c Mon Sep 17 00:00:00 2001 From: Chris Craik Date: Fri, 27 Jun 2014 18:30:23 -0700 Subject: Deep copy SkPath parameter to PathCache task bug:15440706 Change-Id: I2b5b25f620df838cb1155cc8502d86ad3644c212 --- libs/hwui/PathCache.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'libs/hwui/PathCache.h') diff --git a/libs/hwui/PathCache.h b/libs/hwui/PathCache.h index eee138b8fddf..bc34188f061c 100644 --- a/libs/hwui/PathCache.h +++ b/libs/hwui/PathCache.h @@ -272,15 +272,18 @@ private: class PathTask: public Task { public: PathTask(const SkPath* path, const SkPaint* paint, PathTexture* texture): - path(path), paint(*paint), texture(texture) { + path(*path), paint(*paint), texture(texture) { } ~PathTask() { delete future()->get(); } - const SkPath* path; - //copied, since input paint may not be immutable + // copied, since input path not refcounted / guaranteed to survive for duration of task + // TODO: avoid deep copy with refcounting + const SkPath path; + + // copied, since input paint may not be immutable const SkPaint paint; PathTexture* texture; }; -- cgit v1.2.3-59-g8ed1b