From dabcf4151adeb1376ce3b6c9f4b060f9b7fd8a16 Mon Sep 17 00:00:00 2001 From: Jason Parks Date: Tue, 3 Nov 2009 12:14:38 -0800 Subject: Add a warning when we leave threads in the binder thread pool in the background scheduling group. --- libs/binder/IPCThreadState.cpp | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'libs/binder/IPCThreadState.cpp') diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp index c371a23b85f4..86c3df6abea0 100644 --- a/libs/binder/IPCThreadState.cpp +++ b/libs/binder/IPCThreadState.cpp @@ -14,10 +14,13 @@ * limitations under the License. */ +#define LOG_TAG "IPCThreadState" + #include #include #include +#include #include #include #include @@ -418,7 +421,32 @@ void IPCThreadState::joinThreadPool(bool isMain) alog << "Processing top-level Command: " << getReturnString(cmd) << endl; } + + bool isTainted = false; + + { + SchedPolicy policy; + get_sched_policy(getpid(), &policy); + + if (policy == SP_BACKGROUND) { + isTainted = true; + } + } + result = executeCommand(cmd); + + // Make sure that after executing the commands that we put the thread back into the + // default cgroup. + { + int pid = getpid(); + SchedPolicy policy; + get_sched_policy(pid, &policy); + + if (!isTainted && policy == SP_BACKGROUND) { + LOGW("*** THREAD %p (PID %p) was left in SP_BACKGROUND with a priority of %d\n", + (void*)pthread_self(), pid, getpriority(PRIO_PROCESS, pid)); + } + } } // Let this thread exit the thread pool if it is no longer -- cgit v1.2.3-59-g8ed1b