From 95af4cae9771735ed490aa8ca2a6e42fd34be415 Mon Sep 17 00:00:00 2001 From: Yi Kong Date: Mon, 12 Aug 2024 07:03:29 +0800 Subject: Remove unnecessary std::move Moving a temporary object prevents copy elision, and could reduce performance. This fixes -Wpessimizing-move compiler warning. Test: presubmit Bug: 154270751 Change-Id: I4c769b174bb2a1fab2928c4887dcb70d82f264fa --- libs/androidfw/PosixUtils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libs/androidfw/PosixUtils.cpp') diff --git a/libs/androidfw/PosixUtils.cpp b/libs/androidfw/PosixUtils.cpp index 8ddc57240129..49ee8f7ac4eb 100644 --- a/libs/androidfw/PosixUtils.cpp +++ b/libs/androidfw/PosixUtils.cpp @@ -119,7 +119,7 @@ ProcResult ExecuteBinary(const std::vector& argv) { auto err = ReadFile(stderr[0]); result.stderr_str = err ? std::move(*err) : ""; close(stderr[0]); - return std::move(result); + return result; } } -- cgit v1.2.3-59-g8ed1b