From 0ae49d300d13d831e0d3617099f6836faf1786bd Mon Sep 17 00:00:00 2001 From: Ryan Mitchell Date: Fri, 5 Mar 2021 15:12:52 -0800 Subject: Prevent Theme#dump from restricting minimum severity After Theme#dump is used, all logs with a lower severity than "info" were not being shown. Removing base::ScopedLogSeverity fixes this issue. ScopedLogSeverity does not have any purpose in these code blocks since the dump command is doing the theme logging at a fixed severity. Bug: 175070283 Test: use debugger to invoke dump and verify that it does not limit minimum severity Change-Id: I4564d119b3672398c6b1d11cd946080cca458218 --- libs/androidfw/AssetManager2.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'libs/androidfw/AssetManager2.cpp') diff --git a/libs/androidfw/AssetManager2.cpp b/libs/androidfw/AssetManager2.cpp index c0ef7be8b673..7e45f952d389 100644 --- a/libs/androidfw/AssetManager2.cpp +++ b/libs/androidfw/AssetManager2.cpp @@ -226,8 +226,6 @@ void AssetManager2::BuildDynamicRefTable() { } void AssetManager2::DumpToLog() const { - base::ScopedLogSeverity _log(base::INFO); - LOG(INFO) << base::StringPrintf("AssetManager2(this=%p)", this); std::string list; @@ -1721,7 +1719,6 @@ base::expected Theme::SetTo(const Theme& o) { } void Theme::Dump() const { - base::ScopedLogSeverity _log(base::INFO); LOG(INFO) << base::StringPrintf("Theme(this=%p, AssetManager2=%p)", this, asset_manager_); for (int p = 0; p < packages_.size(); p++) { -- cgit v1.2.3-59-g8ed1b