From 1c509615592635ed1551901915ab63b5cc80f8c7 Mon Sep 17 00:00:00 2001 From: Sudheer Shanka Date: Thu, 24 Sep 2020 15:51:24 -0700 Subject: Disable use of RevocableFileDescriptor for blob reads. We are using RevocableFileDescriptor as a precaution to make sure when blobs get deleted, apps are not holding onto those fds and preventing disk space from getting freed but this might not be much of a concern since non-system apps cannot be persistent (so they eventually gets killed) and apps can already fill up disk space if they want and given that we are seeing issues with fuse reads, disabling the use of RevocableFileDescriptor for blob reads. Bug: 162662834 Test: atest --test-mapping apex/blobstore Change-Id: I13a504fac154e2a3cacfb37e83a9cfec4ae80b63 --- .../blobstore/service/java/com/android/server/blob/BlobStoreConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'apex/blobstore') diff --git a/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java b/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java index bb9f13f1712c..5cebf8d91cfc 100644 --- a/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java +++ b/apex/blobstore/service/java/com/android/server/blob/BlobStoreConfig.java @@ -128,7 +128,7 @@ class BlobStoreConfig { */ public static final String KEY_USE_REVOCABLE_FD_FOR_READS = "use_revocable_fd_for_reads"; - public static final boolean DEFAULT_USE_REVOCABLE_FD_FOR_READS = true; + public static final boolean DEFAULT_USE_REVOCABLE_FD_FOR_READS = false; public static boolean USE_REVOCABLE_FD_FOR_READS = DEFAULT_USE_REVOCABLE_FD_FOR_READS; -- cgit v1.2.3-59-g8ed1b