From ae1aadc04f9cee280c3c328a533e2ceeb4b71d47 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 29 Aug 2016 14:53:50 -0700 Subject: Fix google-explicit-constructor warnings in soundpool. * Add explicit keyword to conversion constructors. Bug: 28341362 Test: build with WITH_TIDY=1 Change-Id: Id1183b2929242cdf1fd0a1558d0e70194a1de9bb --- media/jni/soundpool/SoundPool.h | 2 +- media/jni/soundpool/SoundPoolThread.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/media/jni/soundpool/SoundPool.h b/media/jni/soundpool/SoundPool.h index 98d2fa25207c..aff101f06748 100644 --- a/media/jni/soundpool/SoundPool.h +++ b/media/jni/soundpool/SoundPool.h @@ -37,7 +37,7 @@ class SoundPool; // for queued events class SoundPoolEvent { public: - SoundPoolEvent(int msg, int arg1=0, int arg2=0) : + explicit SoundPoolEvent(int msg, int arg1=0, int arg2=0) : mMsg(msg), mArg1(arg1), mArg2(arg2) {} int mMsg; int mArg1; diff --git a/media/jni/soundpool/SoundPoolThread.h b/media/jni/soundpool/SoundPoolThread.h index 9096aeb3e30e..7b3e1dda0a23 100644 --- a/media/jni/soundpool/SoundPoolThread.h +++ b/media/jni/soundpool/SoundPoolThread.h @@ -40,7 +40,7 @@ public: */ class SoundPoolThread { public: - SoundPoolThread(SoundPool* SoundPool); + explicit SoundPoolThread(SoundPool* SoundPool); ~SoundPoolThread(); void loadSample(int sampleID); void quit(); -- cgit v1.2.3-59-g8ed1b