From fece2ab2f73af098430b10fa0979e49f97079ab5 Mon Sep 17 00:00:00 2001 From: Jason Monk Date: Thu, 4 Feb 2016 11:41:18 -0500 Subject: Adjust QS Header in landscape Give some padding on the expand arrow. Change-Id: Ia2f88beb453634bfc82a17033f2e7a76d12e2620 --- packages/SystemUI/res/values-sw600dp/dimens.xml | 2 ++ .../SystemUI/res/values-w550dp-land/dimens.xml | 2 ++ packages/SystemUI/res/values/dimens.xml | 1 + .../src/com/android/systemui/qs/QuickQSPanel.java | 29 +++++++++++++++++----- 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/res/values-sw600dp/dimens.xml b/packages/SystemUI/res/values-sw600dp/dimens.xml index 71f92fd18587..c0652d8a8e8b 100644 --- a/packages/SystemUI/res/values-sw600dp/dimens.xml +++ b/packages/SystemUI/res/values-sw600dp/dimens.xml @@ -93,4 +93,6 @@ 128dp 25dp + + 0dp diff --git a/packages/SystemUI/res/values-w550dp-land/dimens.xml b/packages/SystemUI/res/values-w550dp-land/dimens.xml index eaca9d718fd2..4160c83683cc 100644 --- a/packages/SystemUI/res/values-w550dp-land/dimens.xml +++ b/packages/SystemUI/res/values-w550dp-land/dimens.xml @@ -18,4 +18,6 @@ 544dp + + 32dp diff --git a/packages/SystemUI/res/values/dimens.xml b/packages/SystemUI/res/values/dimens.xml index e79a82a3d187..ae2b961c6ce3 100644 --- a/packages/SystemUI/res/values/dimens.xml +++ b/packages/SystemUI/res/values/dimens.xml @@ -186,6 +186,7 @@ 14sp 14sp 36sp + 0dp 0dp 2dp diff --git a/packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java b/packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java index e4b8a6c5f936..f208470a2927 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java @@ -18,6 +18,7 @@ package com.android.systemui.qs; import android.content.Context; import android.content.res.ColorStateList; +import android.content.res.Configuration; import android.util.AttributeSet; import android.view.Gravity; import android.view.View; @@ -102,6 +103,8 @@ public class QuickQSPanel extends QSPanel { private static class HeaderTileLayout extends LinearLayout implements QSTileLayout { + private final ImageView mDownArrow; + public HeaderTileLayout(Context context) { super(context); setClipChildren(false); @@ -111,16 +114,30 @@ public class QuickQSPanel extends QSPanel { int padding = mContext.getResources().getDimensionPixelSize(R.dimen.qs_quick_tile_padding); - ImageView downArrow = new ImageView(context); - downArrow.setImageResource(R.drawable.ic_expand_more); - downArrow.setImageTintList(ColorStateList.valueOf(context.getResources().getColor( + mDownArrow = new ImageView(context); + mDownArrow.setImageResource(R.drawable.ic_expand_more); + mDownArrow.setImageTintList(ColorStateList.valueOf(context.getResources().getColor( android.R.color.white, null))); - downArrow.setLayoutParams(generateLayoutParams()); - downArrow.setPadding(padding, padding, padding, padding); - addView(downArrow); + mDownArrow.setLayoutParams(generateLayoutParams()); + mDownArrow.setPadding(padding, padding, padding, padding); + updateDownArrowMargin(); + addView(mDownArrow); setOrientation(LinearLayout.HORIZONTAL); } + @Override + protected void onConfigurationChanged(Configuration newConfig) { + super.onConfigurationChanged(newConfig); + updateDownArrowMargin(); + } + + private void updateDownArrowMargin() { + LayoutParams params = (LayoutParams) mDownArrow.getLayoutParams(); + params.setMarginStart(mContext.getResources().getDimensionPixelSize( + R.dimen.qs_expand_margin)); + mDownArrow.setLayoutParams(params); + } + @Override public void addTile(TileRecord tile) { addView(tile.tileView, getChildCount() - 1 /* Leave icon at end */, -- cgit v1.2.3-59-g8ed1b