From 85930a321d3553af1137d9259f848f2889f85c00 Mon Sep 17 00:00:00 2001 From: mattgilbride Date: Mon, 5 Dec 2022 15:32:53 +0000 Subject: Fix: update Binder#getCallingUidOrWtf to use wtfStack Change I11ea3fdf889689d76211506e81420e694238ee68 introduced Binder#getCallingUidOrWtf. It should have used Log.wtfStack instead of Log.wtf. The stack trace is important for diagnosing the origin of a given binder call. Bug: 252975769 Test: TH Change-Id: I6946b1aea536f4b662ffffe8024dbc54d3dc36e0 --- core/java/android/os/Binder.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/android/os/Binder.java b/core/java/android/os/Binder.java index 2d244a9b469d..aa561050c919 100644 --- a/core/java/android/os/Binder.java +++ b/core/java/android/os/Binder.java @@ -366,7 +366,7 @@ public class Binder implements IBinder { */ public static final int getCallingUidOrWtf() { if (!isDirectlyHandlingTransaction() && !hasExplicitIdentity()) { - Log.wtf(TAG, + Log.wtfStack(TAG, "Thread is not in a binder transaction, " + "and the calling identity has not been " + "explicitly set with clearCallingIdentity"); -- cgit v1.2.3-59-g8ed1b